[IMPROVEMENT] Ease white labelling for Android (#2685)

* improve white labelling for Android

* Move application ID to gradle properties

* Fix CI

* Point foss sufix to main app

* Use npx on android-whitelabel script

Co-authored-by: Diego Mello <diegolmello@gmail.com>

.circleci/config.yml

@@ -151,6 +151,9 @@ jobs:
             echo -e "android.useAndroidX=true" >> ./gradle.properties
             echo -e "android.enableJetifier=true" >> ./gradle.properties
             echo -e "FLIPPER_VERSION=0.51.0" >> ./gradle.properties
+            echo -e "APPLICATION_ID=chat.rocket.reactnative" >> ./gradle.properties
+            echo -e "VERSIONCODE=$CIRCLE_BUILD_NUM" >> ./gradle.properties
+            echo -e "BugsnagAPIKey=$BUGSNAG_KEY" >> ./gradle.properties
 
             if [[ $KEYSTORE ]]; then
               echo $KEYSTORE_BASE64 | base64 --decode > ./app/$KEYSTORE
@@ -159,9 +162,6 @@ jobs:
               echo -e "KEY_ALIAS=$KEY_ALIAS" >> ./gradle.properties
               echo -e "KEY_PASSWORD=$KEYSTORE_PASSWORD" >> ./gradle.properties
             fi
-
-            echo -e "VERSIONCODE=$CIRCLE_BUILD_NUM" >> ./gradle.properties
-            echo -e "BugsnagAPIKey=$BUGSNAG_KEY" >> ./gradle.properties
           working_directory: android
 
       - run:
@@ -246,6 +246,7 @@ jobs:
             echo -e "android.enableJetifier=true" >> ./gradle.properties
             echo -e "FLIPPER_VERSION=0.51.0" >> ./gradle.properties
             echo -e "VERSIONCODE=$CIRCLE_BUILD_NUM" >> ./gradle.properties
+            echo -e "APPLICATION_ID=chat.rocket.android" >> ./gradle.properties
 
             if [[ $KEYSTORE ]]; then
               echo $KEYSTORE_BASE64 | base64 --decode > ./app/$KEYSTORE

android/app/build.gradle

@@ -140,7 +140,7 @@ android {
     }
 
     defaultConfig {
-        applicationId "chat.rocket.reactnative"
+        applicationId APPLICATION_ID
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         versionCode VERSIONCODE as Integer
@@ -196,7 +196,7 @@ android {
     flavorDimensions "type"
     productFlavors {
         foss {
-            applicationId "chat.rocket.android"
+            applicationId APPLICATION_ID
             dimension = "type"
             buildConfigField "boolean", "FDROID_BUILD", "true"
         }

android/app/src/debug/AndroidManifest.xml

@@ -1,10 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
+    xmlns:tools="http://schemas.android.com/tools">
-    package="chat.rocket.reactnative">
 
     <application
-        android:name=".MainDebugApplication"
+        android:name="chat.rocket.reactnative.MainDebugApplication"
         tools:ignore="GoogleAppIndexingWarning"
         tools:replace="android:name"
         tools:targetApi="28"

android/app/src/main/AndroidManifest.xml

@@ -3,20 +3,19 @@
     package="chat.rocket.reactnative">
 
     <uses-permission android:name="android.permission.INTERNET" />
-	<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
 
     <application
-		android:name=".MainApplication"
+        android:name="chat.rocket.reactnative.MainApplication"
-		android:label="@string/app_name"
-		android:icon="@mipmap/ic_launcher"
-		android:theme="@style/AppTheme"
-		android:networkSecurityConfig="@xml/network_security_config"
-		android:supportsRtl="true"
-		android:requestLegacyExternalStorage="true"
         android:allowBackup="false"
-		tools:replace="android:allowBackup"
+        android:icon="@mipmap/ic_launcher"
-	>
+        android:label="@string/app_name"
+        android:networkSecurityConfig="@xml/network_security_config"
+        android:requestLegacyExternalStorage="true"
+        android:supportsRtl="true"
+        android:theme="@style/AppTheme"
+        tools:replace="android:allowBackup">
         <activity
             android:name="com.zoontek.rnbootsplash.RNBootSplashActivity"
             android:theme="@style/BootTheme">
@@ -26,37 +25,50 @@
             </intent-filter>
         </activity>
         <activity
-			android:name=".MainActivity"
+            android:name="chat.rocket.reactnative.MainActivity"
-			android:label="@string/app_name"
             android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
+            android:exported="true"
+            android:label="@string/app_name"
             android:launchMode="singleTask"
-			android:windowSoftInputMode="adjustResize"
+            android:windowSoftInputMode="adjustResize">
-			android:exported="true">
             <intent-filter>
-				<action android:name="android.intent.action.DOWNLOAD_COMPLETE"/>
+                <action android:name="android.intent.action.DOWNLOAD_COMPLETE" />
             </intent-filter>
             <intent-filter android:label="@string/app_name">
                 <action android:name="android.intent.action.VIEW" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
-				<data android:scheme="https" android:host="go.rocket.chat" />
+
-				<data android:scheme="https" android:host="jitsi.rocket.chat" />
+                <data
-				<data android:scheme="rocketchat" android:host="room" />
+                    android:host="go.rocket.chat"
-				<data android:scheme="rocketchat" android:host="auth" />
+                    android:scheme="https" />
-				<data android:scheme="rocketchat" android:host="jitsi.rocket.chat" />
+                <data
+                    android:host="jitsi.rocket.chat"
+                    android:scheme="https" />
+                <data
+                    android:host="room"
+                    android:scheme="rocketchat" />
+                <data
+                    android:host="auth"
+                    android:scheme="rocketchat" />
+                <data
+                    android:host="jitsi.rocket.chat"
+                    android:scheme="rocketchat" />
             </intent-filter>
         </activity>
         <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
         <activity
-				android:noHistory="true"
+            android:name="chat.rocket.reactnative.share.ShareActivity"
-				android:name=".share.ShareActivity"
             android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
             android:label="@string/share_extension_name"
+            android:noHistory="true"
             android:screenOrientation="portrait"
-				android:theme="@style/AppTheme" >
+            android:theme="@style/AppTheme">
             <intent-filter>
                 <action android:name="android.intent.action.SEND" />
                 <action android:name="android.intent.action.SEND_MULTIPLE" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <data android:mimeType="*/*" />
             </intent-filter>

android/app/src/main/java/chat/rocket/reactnative/MainApplication.java

@@ -19,6 +19,7 @@ import java.util.Arrays;
 import java.util.List;
 
 import chat.rocket.reactnative.generated.BasePackageList;
+import chat.rocket.reactnative.networking.SSLPinningPackage;
 
 public class MainApplication extends Application implements ReactApplication {
 

android/app/src/main/java/chat/rocket/reactnative/networking/SSLPinningModule.java

@@ -1,4 +1,4 @@
-package chat.rocket.reactnative;
+package chat.rocket.reactnative.networking;
 
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContextBaseJavaModule;

android/app/src/main/java/chat/rocket/reactnative/networking/SSLPinningPackage.java

@@ -1,4 +1,4 @@
-package chat.rocket.reactnative;
+package chat.rocket.reactnative.networking;
 
 import java.util.Arrays;
 import java.util.Collections;

android/app/src/play/AndroidManifest.xml

@@ -1,10 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-		  xmlns:tools="http://schemas.android.com/tools"
+		  xmlns:tools="http://schemas.android.com/tools">
-	package="chat.rocket.reactnative">
 
 	<application
-		android:name=".MainPlayApplication"
+		android:name="chat.rocket.reactnative.MainPlayApplication"
 		android:label="@string/app_name"
 		android:icon="@mipmap/ic_launcher"
 		android:theme="@style/AppTheme"
@@ -12,11 +11,11 @@
 		tools:replace="android:name"
 	>
 		<receiver
-			android:name=".ReplyBroadcast"
+			android:name="chat.rocket.reactnative.ReplyBroadcast"
 			android:enabled="true"
 			android:exported="false" />
 		<receiver
-			android:name=".DismissNotification"
+			android:name="chat.rocket.reactnative.DismissNotification"
 			android:enabled="true"
 			android:exported="false" >
 		</receiver>

android/gradle.properties

@@ -29,6 +29,9 @@ android.enableJetifier=true
 # Version of flipper SDK to use with React Native
 FLIPPER_VERSION=0.51.0
 
+# Application ID
+APPLICATION_ID=chat.rocket.reactnative
+
 # App properties
 VERSIONCODE=999999999
 BugsnagAPIKey=""

package.json

@@ -10,6 +10,7 @@
     "ci": "npm run precommit && codecov",
     "ios": "npx react-native run-ios",
     "android": "npx react-native run-android --variant=playDebug",
+    "android-whitelabel": "npx react-native run-android --main-activity chat.rocket.reactnative.MainActivity --variant=playDebug --appId",
     "log-android": "react-native log-android",
     "snyk-protect": "snyk protect",
     "precommit": "eslint . && jest",