Chore: Migrate CreateDiscussionView to Typescript (#3378)

* [improve] - migrate the view: CreateDiscussionView to typescript

* minor changes

Co-authored-by: Diego Mello <diegolmello@gmail.com>

app/containers/HeaderButton/Common.tsx

@@ -7,8 +7,8 @@ import Item from './HeaderButtonItem';
 
 interface IHeaderButtonCommon {
 	navigation: any;
-	onPress(): void;
-	testID: string;
+	onPress?(): void;
+	testID?: string;
 }
 
 // Left

app/containers/UIKit/MultiSelect/index.tsx

@@ -14,19 +14,19 @@ import Input from './Input';
 import styles from './styles';
 
 interface IMultiSelect {
-	options: [];
+	options: any[];
 	onChange: Function;
 	placeholder: {
 		text: string;
 	};
-	context: number;
-	loading: boolean;
-	multiselect: boolean;
+	context?: number;
+	loading?: boolean;
+	multiselect?: boolean;
 	onSearch: Function;
 	onClose: Function;
 	inputStyle: object;
-	value: { text: any }[];
-	disabled: boolean;
+	value?: any[];
+	disabled?: boolean | object;
 	theme: string;
 }
 

app/views/CreateDiscussionView/SelectChannel.tsx

@@ -1,6 +1,5 @@
 import React, { useState } from 'react';
 import { Text } from 'react-native';
-import PropTypes from 'prop-types';
 
 import debounce from '../../utils/debounce';
 import { avatarURL } from '../../utils/avatar';
@@ -9,8 +8,18 @@ import I18n from '../../i18n';
 import { MultiSelect } from '../../containers/UIKit/MultiSelect';
 import { themes } from '../../constants/colors';
 import styles from './styles';
+import { ICreateDiscussionViewSelectChannel } from './interfaces';
 
-const SelectChannel = ({ server, token, userId, onChannelSelect, initial, blockUnauthenticatedAccess, serverVersion, theme }) => {
+const SelectChannel = ({
+	server,
+	token,
+	userId,
+	onChannelSelect,
+	initial,
+	blockUnauthenticatedAccess,
+	serverVersion,
+	theme
+}: ICreateDiscussionViewSelectChannel): JSX.Element => {
 	const [channels, setChannels] = useState([]);
 
 	const getChannels = debounce(async (keyword = '') => {
@@ -22,7 +31,9 @@ const SelectChannel = ({ server, token, userId, onChannelSelect, initial, blockU
 		}
 	}, 300);
 
-	const getAvatar = item =>
+	const getAvatar = (item: any) =>
+		// TODO: remove this ts-ignore when migrate the file: app/utils/avatar.js
+		// @ts-ignore
 		avatarURL({
 			text: RocketChat.getRoomAvatar(item),
 			type: item.t,
@@ -55,15 +66,5 @@ const SelectChannel = ({ server, token, userId, onChannelSelect, initial, blockU
 		</>
 	);
 };
-SelectChannel.propTypes = {
-	server: PropTypes.string,
-	token: PropTypes.string,
-	userId: PropTypes.string,
-	initial: PropTypes.object,
-	onChannelSelect: PropTypes.func,
-	blockUnauthenticatedAccess: PropTypes.bool,
-	serverVersion: PropTypes.string,
-	theme: PropTypes.string
-};
 
 export default SelectChannel;

app/views/CreateDiscussionView/SelectUsers.tsx

@@ -1,6 +1,5 @@
 import React, { useState } from 'react';
 import { Text } from 'react-native';
-import PropTypes from 'prop-types';
 import { BLOCK_CONTEXT } from '@rocket.chat/ui-kit';
 import { Q } from '@nozbe/watermelondb';
 
@@ -12,19 +11,37 @@ import I18n from '../../i18n';
 import { MultiSelect } from '../../containers/UIKit/MultiSelect';
 import { themes } from '../../constants/colors';
 import styles from './styles';
+import { ICreateDiscussionViewSelectUsers } from './interfaces';
 
-const SelectUsers = ({ server, token, userId, selected, onUserSelect, blockUnauthenticatedAccess, serverVersion, theme }) => {
-	const [users, setUsers] = useState([]);
+interface IUser {
+	name: string;
+	username: string;
+}
+
+const SelectUsers = ({
+	server,
+	token,
+	userId,
+	selected,
+	onUserSelect,
+	blockUnauthenticatedAccess,
+	serverVersion,
+	theme
+}: ICreateDiscussionViewSelectUsers): JSX.Element => {
+	const [users, setUsers] = useState<any[]>([]);
 
 	const getUsers = debounce(async (keyword = '') => {
 		try {
 			const db = database.active;
 			const usersCollection = db.get('users');
 			const res = await RocketChat.search({ text: keyword, filterRooms: false });
-			let items = [...users.filter(u => selected.includes(u.name)), ...res.filter(r => !users.find(u => u.name === r.name))];
+			let items = [
+				...users.filter((u: IUser) => selected.includes(u.name)),
+				...res.filter((r: IUser) => !users.find((u: IUser) => u.name === r.name))
+			];
 			const records = await usersCollection.query(Q.where('username', Q.oneOf(items.map(u => u.name)))).fetch();
 			items = items.map(item => {
-				const index = records.findIndex(r => r.username === item.name);
+				const index = records.findIndex((r: IUser) => r.username === item.name);
 				if (index > -1) {
 					const record = records[index];
 					return {
@@ -44,7 +61,9 @@ const SelectUsers = ({ server, token, userId, selected, onUserSelect, blockUnaut
 		}
 	}, 300);
 
-	const getAvatar = item =>
+	const getAvatar = (item: any) =>
+		// TODO: remove this ts-ignore when migrate the file: app/utils/avatar.js
+		// @ts-ignore
 		avatarURL({
 			text: RocketChat.getRoomAvatar(item),
 			type: 'd',
@@ -63,12 +82,12 @@ const SelectUsers = ({ server, token, userId, selected, onUserSelect, blockUnaut
 				inputStyle={styles.inputStyle}
 				onSearch={getUsers}
 				onChange={onUserSelect}
-				options={users.map(user => ({
+				options={users.map((user: IUser) => ({
 					value: user.name,
 					text: { text: RocketChat.getRoomTitle(user) },
 					imageUrl: getAvatar(user)
 				}))}
-				onClose={() => setUsers(users.filter(u => selected.includes(u.name)))}
+				onClose={() => setUsers(users.filter((u: IUser) => selected.includes(u.name)))}
 				placeholder={{ text: `${I18n.t('Select_Users')}...` }}
 				context={BLOCK_CONTEXT.FORM}
 				multiselect
@@ -76,15 +95,5 @@ const SelectUsers = ({ server, token, userId, selected, onUserSelect, blockUnaut
 		</>
 	);
 };
-SelectUsers.propTypes = {
-	server: PropTypes.string,
-	token: PropTypes.string,
-	userId: PropTypes.string,
-	selected: PropTypes.array,
-	onUserSelect: PropTypes.func,
-	blockUnauthenticatedAccess: PropTypes.bool,
-	serverVersion: PropTypes.string,
-	theme: PropTypes.string
-};
 
 export default SelectUsers;

app/views/CreateDiscussionView/index.tsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { connect } from 'react-redux';
-import PropTypes from 'prop-types';
 import { ScrollView, Switch, Text } from 'react-native';
 
 import Loading from '../../containers/Loading';
@@ -24,30 +23,16 @@ import { E2E_ROOM_TYPES } from '../../lib/encryption/constants';
 import styles from './styles';
 import SelectUsers from './SelectUsers';
 import SelectChannel from './SelectChannel';
+import { ICreateChannelViewProps } from './interfaces';
 
-class CreateChannelView extends React.Component {
-	propTypes = {
-		navigation: PropTypes.object,
-		route: PropTypes.object,
-		server: PropTypes.string,
-		user: PropTypes.object,
-		create: PropTypes.func,
-		loading: PropTypes.bool,
-		result: PropTypes.object,
-		failure: PropTypes.bool,
-		error: PropTypes.object,
-		theme: PropTypes.string,
-		isMasterDetail: PropTypes.bool,
-		blockUnauthenticatedAccess: PropTypes.bool,
-		serverVersion: PropTypes.string,
-		encryptionEnabled: PropTypes.bool
-	};
+class CreateChannelView extends React.Component<ICreateChannelViewProps, any> {
+	private channel: any;
 
-	constructor(props) {
+	constructor(props: ICreateChannelViewProps) {
 		super(props);
 		const { route } = props;
 		this.channel = route.params?.channel;
-		const message = route.params?.message ?? {};
+		const message: any = route.params?.message ?? {};
 		this.state = {
 			channel: this.channel,
 			message,
@@ -59,7 +44,7 @@ class CreateChannelView extends React.Component {
 		this.setHeader();
 	}
 
-	componentDidUpdate(prevProps, prevState) {
+	componentDidUpdate(prevProps: any, prevState: any) {
 		const { channel, name } = this.state;
 		const { loading, failure, error, result, isMasterDetail } = this.props;
 
@@ -118,7 +103,7 @@ class CreateChannelView extends React.Component {
 		} = this.state;
 		const { create } = this.props;
 
-		const params = {
+		const params: any = {
 			prid: prid || rid,
 			pmid,
 			t_name,
@@ -138,12 +123,12 @@ class CreateChannelView extends React.Component {
 		return channel && channel.rid && channel.rid.trim().length && name.trim().length;
 	};
 
-	selectChannel = ({ value }) => {
+	selectChannel = ({ value }: any) => {
 		logEvent(events.CD_SELECT_CHANNEL);
 		this.setState({ channel: value, encrypted: value?.encrypted });
 	};
 
-	selectUsers = ({ value }) => {
+	selectUsers = ({ value }: any) => {
 		logEvent(events.CD_SELECT_USERS);
 		this.setState({ users: value });
 	};
@@ -151,10 +136,12 @@ class CreateChannelView extends React.Component {
 	get isEncryptionEnabled() {
 		const { channel } = this.state;
 		const { encryptionEnabled } = this.props;
+		// TODO: remove this ts-ignore when migrate the file: app/lib/encryption/constants.js
+		// @ts-ignore
 		return encryptionEnabled && E2E_ROOM_TYPES[channel?.t];
 	}
 
-	onEncryptedChange = value => {
+	onEncryptedChange = (value: any) => {
 		logEvent(events.CD_TOGGLE_ENCRY);
 		this.setState({ encrypted: value });
 	};
@@ -163,12 +150,14 @@ class CreateChannelView extends React.Component {
 		const { name, users, encrypted } = this.state;
 		const { server, user, loading, blockUnauthenticatedAccess, theme, serverVersion } = this.props;
 		return (
+			// @ts-ignore
 			<KeyboardView
 				style={{ backgroundColor: themes[theme].auxiliaryBackground }}
 				contentContainerStyle={styles.container}
 				keyboardVerticalOffset={128}>
 				<StatusBar />
 				<SafeAreaView testID='create-discussion-view' style={styles.container}>
+					{/* @ts-ignore*/}
 					<ScrollView {...scrollPersistTaps}>
 						<Text style={[styles.description, { color: themes[theme].auxiliaryText }]}>{I18n.t('Discussion_Desc')}</Text>
 						<SelectChannel
@@ -186,8 +175,9 @@ class CreateChannelView extends React.Component {
 							testID='multi-select-discussion-name'
 							placeholder={I18n.t('A_meaningful_name_for_the_discussion_room')}
 							containerStyle={styles.inputStyle}
+							/* @ts-ignore*/
 							defaultValue={name}
-							onChangeText={text => this.setState({ name: text })}
+							onChangeText={(text: string) => this.setState({ name: text })}
 							theme={theme}
 						/>
 						<SelectUsers
@@ -214,7 +204,7 @@ class CreateChannelView extends React.Component {
 	}
 }
 
-const mapStateToProps = state => ({
+const mapStateToProps = (state: any) => ({
 	user: getUserSelector(state),
 	server: state.server.server,
 	error: state.createDiscussion.error,
@@ -227,8 +217,8 @@ const mapStateToProps = state => ({
 	encryptionEnabled: state.encryption.enabled
 });
 
-const mapDispatchToProps = dispatch => ({
-	create: data => dispatch(createDiscussionRequest(data))
+const mapDispatchToProps = (dispatch: any) => ({
+	create: (data: any) => dispatch(createDiscussionRequest(data))
 });
 
 export default connect(mapStateToProps, mapDispatchToProps)(withTheme(CreateChannelView));

app/views/CreateDiscussionView/interfaces.ts

@@ -0,0 +1,55 @@
+export interface ICreateChannelViewProps {
+	navigation: any;
+	route: {
+		params?: {
+			channel: string;
+			message: {
+				msg: string;
+			};
+			showCloseModal: boolean;
+		};
+	};
+	server: string;
+	user: {
+		id: string;
+		token: string;
+	};
+	create: Function;
+	loading: boolean;
+	result: {
+		rid: string;
+		t: string;
+		prid: string;
+	};
+	failure: boolean;
+	error: {
+		reason: string;
+	};
+	theme: string;
+	isMasterDetail: boolean;
+	blockUnauthenticatedAccess: boolean;
+	serverVersion: string;
+	encryptionEnabled: boolean;
+}
+
+export interface ICreateDiscussionViewSelectChannel {
+	server: string;
+	token: string;
+	userId: string;
+	initial: object;
+	onChannelSelect: Function;
+	blockUnauthenticatedAccess: boolean;
+	serverVersion: string;
+	theme: string;
+}
+
+export interface ICreateDiscussionViewSelectUsers {
+	server: string;
+	token: string;
+	userId: string;
+	selected: any[];
+	onUserSelect: Function;
+	blockUnauthenticatedAccess: boolean;
+	serverVersion: string;
+	theme: string;
+}