From 8823734d437bba8981dae24773ced72ccfffe292 Mon Sep 17 00:00:00 2001 From: Diego Mello Date: Wed, 11 Dec 2019 16:23:16 -0300 Subject: [PATCH] [NEW] Enable Hermes (#1446) --- .circleci/config.yml | 3 ++- android/app/build.gradle | 2 +- android/build.gradle | 26 +++++++++++++------------- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 206b41d8d..7d612de47 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -197,7 +197,8 @@ jobs: npx jetify cd android if [[ $KEYSTORE ]]; then - ./gradlew bundleRelease + # TODO: enable app bundle again + ./gradlew assembleRelease else ./gradlew assembleDebug fi diff --git a/android/app/build.gradle b/android/app/build.gradle index a82db6d19..6f38fda7d 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -83,7 +83,7 @@ project.ext.react = [ entryFile: "index.js", bundleAssetName: "app.bundle", iconFontNames: [ 'custom.ttf' ], - enableHermes: false, // clean and rebuild if changing + enableHermes: true, // clean and rebuild if changing ] apply from: "../../node_modules/react-native/react.gradle" diff --git a/android/build.gradle b/android/build.gradle index 62a22d81d..aaef31e10 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -55,16 +55,16 @@ allprojects { } } -// subprojects { subproject -> -// afterEvaluate { -// if ((subproject.plugins.hasPlugin('android') || subproject.plugins.hasPlugin('android-library'))) { -// android { -// compileSdkVersion 28 -// buildToolsVersion "28.0.3" -// defaultConfig { -// targetSdkVersion 28 -// } -// } -// } -// } -// } +subprojects { subproject -> + afterEvaluate { + if ((subproject.plugins.hasPlugin('android') || subproject.plugins.hasPlugin('android-library'))) { + android { + compileSdkVersion 28 + buildToolsVersion "28.0.3" + defaultConfig { + targetSdkVersion 28 + } + } + } + } +}