From 986acfd0fcb976a5337c20c473a3f97ead68a199 Mon Sep 17 00:00:00 2001
From: Reinaldo Neto <reinaldonetof@hotmail.com>
Date: Tue, 17 Jan 2023 17:57:22 -0300
Subject: [PATCH] refactor how to test if it's an image

---
 app/containers/message/Urls.tsx       | 23 ++++++++++++++++++-----
 app/lib/methods/helpers/image.test.ts | 26 --------------------------
 app/lib/methods/helpers/image.ts      | 16 ++++++++++------
 3 files changed, 28 insertions(+), 37 deletions(-)
 delete mode 100644 app/lib/methods/helpers/image.test.ts

diff --git a/app/containers/message/Urls.tsx b/app/containers/message/Urls.tsx
index 756d17c11..bfad394e8 100644
--- a/app/containers/message/Urls.tsx
+++ b/app/containers/message/Urls.tsx
@@ -1,4 +1,4 @@
-import React, { useContext } from 'react';
+import React, { useContext, useEffect, useState } from 'react';
 import { StyleSheet, Text, View } from 'react-native';
 import Clipboard from '@react-native-clipboard/clipboard';
 import FastImage from 'react-native-fast-image';
@@ -14,7 +14,7 @@ import EventEmitter from '../../lib/methods/helpers/events';
 import I18n from '../../i18n';
 import MessageContext from './Context';
 import { IUrl } from '../../definitions';
-import { isImage, isValidURL } from '../../lib/methods/helpers';
+import { isImageURL } from '../../lib/methods/helpers';
 
 const styles = StyleSheet.create({
 	button: {
@@ -103,6 +103,18 @@ const UrlContent = React.memo(
 
 const Url = React.memo(
 	({ url, index, theme }: { url: IUrl; index: number; theme: TSupportedThemes }) => {
+		const [isImageUrlFromParamUrl, setIsImageUrlFromParamUrl] = useState(false);
+
+		useEffect(() => {
+			if (!url.image && url.url) {
+				const testImageUrl = async () => {
+					const result = await isImageURL(url.url);
+					setIsImageUrlFromParamUrl(result);
+				};
+				testImageUrl();
+			}
+		}, []);
+
 		if (!url || url?.ignoreParse) {
 			return null;
 		}
@@ -114,12 +126,13 @@ const Url = React.memo(
 			EventEmitter.emit(LISTENER, { message: I18n.t('Copied_to_clipboard') });
 		};
 
-		let imageUrl;
+		let imageUrl = '';
 
 		if (url.image) {
 			imageUrl = url.image;
-		} else {
-			imageUrl = isImage(url.url) && isValidURL(url.url) ? url.url : '';
+		}
+		if (isImageUrlFromParamUrl) {
+			imageUrl = url.url;
 		}
 
 		const hasContent = !!url.title || !!url.description;
diff --git a/app/lib/methods/helpers/image.test.ts b/app/lib/methods/helpers/image.test.ts
deleted file mode 100644
index cbbba984b..000000000
--- a/app/lib/methods/helpers/image.test.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-import { isImage } from './image';
-
-const imageJPG = 'https://i.redd.it/t2mul61342l91.jpg';
-const imagePNG = 'https://user-images.githubusercontent.com/47038980/205175493-fc1f7fdd-d10a-4099-88c4-146bac69e223.png';
-const imageSVG = 'https://i.redd.it/t2mul61342l91.svg';
-const imageUrlWithQueryParams =
-	'https://i.ytimg.com/vi/suFuJZCfC7g/hqdefault.jpg?sqp=-oaymwE2CNACELwBSFXyq4qpAygIARUAAIhCGAFwAcABBvABAfgB_gmAAtAFigIMCAAQARhlIGUoZTAP&rs=AOn4CLB_0OCFNuoCRBlaTJEa2PPOOHxkbQ';
-
-describe("Evaluate if the link is returning an image's type", () => {
-	test('return true when the link ends with .jpg', () => {
-		const result = isImage(imageJPG);
-		expect(result).toBe(true);
-	});
-	test('return true when the link ends with .png', () => {
-		const result = isImage(imagePNG);
-		expect(result).toBe(true);
-	});
-	test('return false when the link ends with .svg', () => {
-		const result = isImage(imageSVG);
-		expect(result).toBe(false);
-	});
-	test('return true when the link ends with .jpg and query params', () => {
-		const result = isImage(imageUrlWithQueryParams);
-		expect(result).toBe(true);
-	});
-});
diff --git a/app/lib/methods/helpers/image.ts b/app/lib/methods/helpers/image.ts
index 363d80115..63ce69c99 100644
--- a/app/lib/methods/helpers/image.ts
+++ b/app/lib/methods/helpers/image.ts
@@ -1,6 +1,10 @@
-// Fast Image can't render a svg image from a uri yet, because of that we aren't test the svg within the RegEx
-const regExpUrlImage = new RegExp(
-	'.(jpg|jpeg|png|webp|avif|gif)' + // type of the URL
-		'(\\?[;&a-z\\d%_.~+=-]*)?' // query string
-);
-export const isImage = (url: string) => regExpUrlImage.test(url);
+import { Image } from 'react-native';
+
+export const isImageURL = async (url: string) => {
+	try {
+		const result = await Image.prefetch(url);
+		return result;
+	} catch {
+		return false;
+	}
+};