From fb11932d0b9a62222f3e6d4c6f4f774da96169af Mon Sep 17 00:00:00 2001 From: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Date: Wed, 11 May 2022 13:59:57 -0300 Subject: [PATCH] Chore: Evaluate AuthenticationWebView - TypeScript (#4158) --- app/definitions/ICredentials.ts | 3 +++ app/views/AuthenticationWebView.tsx | 13 +++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/app/definitions/ICredentials.ts b/app/definitions/ICredentials.ts index e5f96f0a5..7ac0b241b 100644 --- a/app/definitions/ICredentials.ts +++ b/app/definitions/ICredentials.ts @@ -18,4 +18,7 @@ export interface ICredentials { fullName?: AppleAuthenticationFullName | null; email?: string | null; identityToken?: string | null; + credentialToken?: string; + saml?: boolean; + cas?: { credentialToken?: string }; } diff --git a/app/views/AuthenticationWebView.tsx b/app/views/AuthenticationWebView.tsx index 71d449117..ee2590050 100644 --- a/app/views/AuthenticationWebView.tsx +++ b/app/views/AuthenticationWebView.tsx @@ -14,6 +14,7 @@ import { TSupportedThemes, withTheme } from '../theme'; import debounce from '../utils/debounce'; import * as HeaderButton from '../containers/HeaderButton'; import { Services } from '../lib/services'; +import { IApplicationState, ICredentials } from '../definitions'; const userAgent = isIOS ? 'Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_1 like Mac OS X) AppleWebKit/603.1.30 (KHTML, like Gecko) Version/10.0 Mobile/14E304 Safari/602.1' @@ -93,7 +94,7 @@ class AuthenticationWebView extends React.PureComponent { + login = (params: ICredentials) => { const { logging } = this.state; if (logging) { return; @@ -111,7 +112,7 @@ class AuthenticationWebView extends React.PureComponent this.login(params), 3000); + debouncedLogin = debounce((params: ICredentials) => this.login(params), 3000); tryLogin = debounce( async () => { @@ -135,7 +136,7 @@ class AuthenticationWebView extends React.PureComponent cas / validate & saml_idp_credentialToken -> saml if (parsedUrl.pathname?.includes('validate') || parsedUrl.query?.ticket || parsedUrl.query?.saml_idp_credentialToken) { - let payload; + let payload: ICredentials; if (authType === 'saml') { const token = parsedUrl.query?.saml_idp_credentialToken || ssoToken; const credentialToken = { credentialToken: token }; @@ -202,10 +203,10 @@ class AuthenticationWebView extends React.PureComponent ({ +const mapStateToProps = (state: IApplicationState) => ({ server: state.server.server, - Accounts_Iframe_api_url: state.settings.Accounts_Iframe_api_url, - Accounts_Iframe_api_method: state.settings.Accounts_Iframe_api_method + Accounts_Iframe_api_url: state.settings.Accounts_Iframe_api_url as string, + Accounts_Iframe_api_method: state.settings.Accounts_Iframe_api_method as string }); export default connect(mapStateToProps)(withTheme(AuthenticationWebView));