Commit Graph

1342 Commits

Author SHA1 Message Date
Djorkaeff Alexandre 8cd38d5e19
[FIX] Add missing keys to push get payload (#2358) 2020-07-30 14:10:13 -03:00
Youssef Muhamad e05aa1eb52
[NEW] Log events from RoomsList, SideDrawer and Profile (#2190)
* Create method to track user event to isolate the logic to improve future refactoring

* Track Onboarding view

* Track NewServer view

* Refactor track method due to firebase already send the current screen

* Track default login and all the oAuth options

* Track default sign up in RegisterView

* Change trackUserEvent signature and update all the files

* Track the remaining login services

* track add server, change server and search

* Track SidebarView and refactor to use react-navigation

* Track profile events and handle exceptions

* Track create channel flux

* Track send message to user via NewMessageView

* Track create direct message flux

* Handle failure of create channel and group in the saga

* Track create discussion flux

* Track navigate to directory and its actions

* Track read, favorite and hide a channel, handling its errors

* Track all channels sorting and grouping

* Resolve requests to improve the importing logs and events

* Remove unused events file

* Leave a bugsnag breadcrumb when logging an event

* Move all logEvent to the top of code block and log remaining fail events

* Move all the non-logic-dependent logEvent to the top of code block

* Improve the logging of sidebar events

* Improve events from onboarding and newserver

* Improve events from login and register view, and log enter with apple

* Improve NewMessageView events

* Improve CreateChannel events

* Improve CreateDiscussion and SelectedUsers create group events

* Improve RoomsList events and log trivial events

* Improve ProfileView events

* Remove single line function body for the sidebarNavigate

* Navigate to Status and AdminPanel View using the defined sidebarNavigate method

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-30 10:26:17 -03:00
Graham Smith 0a6e0f6f78
[CHORE] Update Flipper to 0.51.0 (#2356)
* Only run Flipper in debug via MainApplication is debug

* ReactNativeFlipper package rename + gradle bump

* Update Flipper to latest 0.51 for Android

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-30 09:23:23 -03:00
Graham Smith 72f7471560
[CHORE] Only run Flipper in debug via MainApplication is debug (#2347)
* Only run Flipper in debug via MainApplication is debug

* ReactNativeFlipper package rename + gradle bump
2020-07-30 09:18:48 -03:00
Youssef Muhamad 052d91eae7
[FIX] In-app notification showing while in a Jitsi call (#2345)
* Hide in app notification when focused on JitsiMeetView

* Hide notifications from different rooms

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-29 18:04:04 -03:00
Diego Mello a584e68bbe
[FIX] Long press gestures not working properly on Android (#2354) 2020-07-29 18:03:17 -03:00
Diego Mello c37eb99e55
[FIX] Missing icons (#2353) 2020-07-29 18:02:51 -03:00
Diego Mello 54bddf035d
[IMPROVEMENT] Apply new mention colors (#2351)
* New mention colors

* Increase letterSpacing for mentions

* Refactor

* UnreadBadge

* Add migration
2020-07-29 17:49:08 -03:00
Djorkaeff Alexandre b68b0b84df
[NEW] Push notification data privacy (#2213)
* [WIP] Notification Service

* [WIP] Android push notification privacy

* [WIP] Retry request when it fails (iOS)

* [WIP] Override notification bundle

* [CHORE] Remove unnecessary import

* [WIP] Check notification Type (iOS)

* [WIP] Change to notification endpoint

* eof

* fix unwrap conditional value

* turn run request synchronous

* fix bundle info

* eof

* remove extra tab

* undo unnecessary change

* remove not working code for a while

* fix notification title

* change endpoint and received/sent data

* message-id-only working properly on android

* notification privacy working on ios

* invalidate circleCI yarn cache

* Fix provisioning profiles

* fix notification service version

* fix unwrap nil

* compatibility older servers android

* show received notification when cant fetch content from server

* undo some android changes

* prevent group & reply fallback notifications

* dont show more than one fallback notification by server

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-28 10:43:43 -03:00
Dan Caseley 72ec569029
[CHORE] Move Detox to Github Actions (#2340)
* Initial workflow for iOS detox tests

* Increase timeout

* Parallelise tests and optimise when to build

* Refine GH Actions logic

* Improve Detox App caching

* Upload failed test artifacts

* Rate limiting aware data setup

* Remove detox tests from Circle CI

* Revert "Rate limiting aware data setup"

This reverts commit d115604270f719de775018b9b06e89f2bfdc2dc7.

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-27 17:51:35 -03:00
Diego Mello 74ecab858f
[CHORE] Update icon names (#2318) 2020-07-27 16:53:33 -03:00
Dan Caseley 3cc4b51258
[TESTS] Stabilise Room Actions test (#2333)
* Stabilise Room Actions test

* Fix Create Room test

* Be more tolerant of slow starting apps in CI

* Be more tolerant of slow running apps in CI

* Switch visibility checks ti stabilise Room Create test in CI

* Move slow simulator readiness waiting to initial navigateToX methods rather than repeatedly in tests without description of purpose
2020-07-26 11:28:48 -03:00
Ezequiel de Oliveira e5aaa667e7
[FIX] MessagesView title not working (#2294)
* Set title in header of room actions view items

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

* Remove unneeded spaces

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

* Set header title on constructor

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

* Remove unused navigation options

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-24 16:58:14 -03:00
Ezequiel de Oliveira 5532d0f368
[FIX] i18n being called outside render (#2334)
* Fix I18n usage in ThemeView

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

* Fix I18n usage in NotificationPreferencesView

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

* Fix some I18n wrong uses

Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-24 16:23:34 -03:00
Dan Caseley b4e353c3d3
[TESTS] Fix some simple text (#2332)
* Clearer infrastructure wait message

* Use a generic mailbox rather than spamming Diego

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-24 16:19:30 -03:00
Diego Mello 09a8be8b59
[REGRESSION] Invite links stopped working after #2154 (#2338)
* [REGRESSION] Invite links stopped working after #2154

* Clear invite links token when close NewServerView

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-24 12:41:59 -03:00
Diego Mello c91cd0b963
[CHORE] Update react-native-firebase (#2336)
* Remove firebase

* Install firebase/app

* Install analytics

* Crashlytics

* Android

* Fix mocks

* Edit scheme to Debug build configuration

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-24 10:19:17 -03:00
Diego Mello a00e3c7769
[CHORE] Skip waiting for build processing on TestFlight upload (#2320) 2020-07-22 18:05:24 -03:00
dependabot[bot] 7491df6109
Bump codecov from 3.6.5 to 3.7.1 (#2323)
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.6.5 to 3.7.1.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Commits](https://github.com/codecov/codecov-node/compare/v3.6.5...v3.7.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:42:54 -03:00
Djorkaeff Alexandre 17b4084c6c
[FIX] Admin panel not logging in automatically (#2330)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:41:36 -03:00
Youssef Muhamad 95e228e590
[IMPROVEMENT] TwoFactor component styling (#2328)
* Improve 2fa visual hierarchy

* Show 2fa keyboard by scheduling focus method after all interactions

* Remove unrelated styling improvements

* Improve 2fa component title hierarchy

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:37:42 -03:00
Youssef Muhamad 8c8062ac01
[FIX] Keyboard not focusing on TwoFactor component (#2314)
* Improve 2fa visual hierarchy

* Show 2fa keyboard by scheduling focus method after all interactions

* Remove unrelated styling improvements

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:36:15 -03:00
Youssef Muhamad fc324edafe
[NEW] Log events from Onboarding, NewServer, Login and Register screens (#2169)
* Create method to track user event to isolate the logic to improve future refactoring

* Track Onboarding view

* Track NewServer view

* Refactor track method due to firebase already send the current screen

* Track default login and all the oAuth options

* Track default sign up in RegisterView

* Change trackUserEvent signature and update all the files

* Track the remaining login services

* Resolve requests to improve the importing logs and events

* Leave a bugsnag breadcrumb when logging an event

* Move all logEvent to the top of code block and log remaining fail events

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:31:38 -03:00
Dan Caseley df6c2c5424
[TESTS] Idempotence for e2e tests (#2308)
* Idempotence for Assorted

* Idempotence for Onboarding

* Idempotence for Rooms

* Remove redundant expects

* Fixes and improvements

* Remove unneeded sleeps

* Make stable following merge

* Try solving early taps without long sleep

Try solving early taps without long sleep (cont)

Temporary CircleCI hack for quicker testing

Add screenshots to CircleCI for failed tests

Try solving early taps without long sleep (cont. 2)

Revert "Temporary CircleCI hack for quicker testing"

This reverts commit 4abef3a5827910c05b12ac8b8380275b60e8af4f.

* Fix flaky test with a fluent wait on the tap

* Add some new sleeps to workaround #2324

* Add test artifacts to gitignore

* More longpress for dodgy taps, wait for pin response

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 13:32:21 -03:00
Diego Mello a5c81b2687
Revert "[CHORE] Update commonmark.js " (#2331) 2020-07-22 11:04:33 -03:00
Neil Agarwal a4b43e9cda
[IMPROVEMENT] Improve our PR Template (#1893)
* [IMPROVEMENT] Improve our PR Template

* Few changes

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-21 11:18:11 -03:00
Diego Mello 7a5a92f33f
[FIX] Style not being applied on RoomsListView header subtitle (#2319) 2020-07-21 11:06:17 -03:00
Diego Mello 9dbe10bcf8
[IMPROVEMENT] Native sort and limit queries (#2249)
* Update WatermelonDB to 0.18.0

* Low onEndReachedThreshold

* Query experiment

* QUERY_SIZE

* Query or fetch data

* Reorder class functions

* Reset variables

* Hide system messages

* Change this.count behaviour

* Starting on RoomsListView

* unsubscribeQuery

* onEndReached

* Separate queries

* Reusable where clause

* Refactoring

* Refactor RoomItem to accept item as prop

* Comment RoomItem tests just so jest passes

* Fix alert and status

* onPress

* Unnecessary diff

* react-fast-compare

* Native limit on ShareListView

* Tweak item description

* Lint

* Fix on foreground crash

* Suggested changes
2020-07-20 13:44:54 -03:00
Diego Mello 9882ace694
Update dependencies (#2301)
* Update RN to 0.63.0-rc.1

* Updating

* Fix keyboard

* Fix native stuff on Messagebox

* Update to RN 0.63.1

* Update pods

* Update patches

* Update minors

* Majors

* Remove base-64 in favour of js-base64

* others

* Pods

* Flipper

* Yarn

* Fix setInput
2020-07-20 13:35:17 -03:00
Rohit Verma 42df5ddbc1
[FIX] MessagesView duplicating content (#2307)
* Fix Pagination duplicacy

* Fix MessageView Duplicate Content

* [FIX] Return fetch func

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-17 15:59:18 -03:00
dependabot[bot] 52b82e5809
Bump lodash from 4.17.16 to 4.17.19 (#2310)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.16 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.16...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-07-17 14:55:53 -03:00
Djorkaeff Alexandre ff8899c39f
[CHORE] Update commonmark libs (#2306)
* [CHORE] Update commonmark fork and relateds

* [CHORE] Update commonmark.js

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:53:13 -03:00
Djorkaeff Alexandre 45cc350a8c
[FIX] Markdown preview causes app stuck (#2303)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:45:39 -03:00
Diego Mello 9b71a785aa
[FIX] In-app notification tap when deep in the stack not redirecting to the room (#2302) 2020-07-17 14:39:59 -03:00
Djorkaeff Alexandre cbe51e2d18
[IMPROVEMENT] Clear image cache when clear cache (#2300)
* [IMPROVEMENT] Clear image cache when clear cache

* use fork instead

* react-native-fast-image -> @rocket.chat/react-native-fast-image

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:39:06 -03:00
phriedrich 812535da43
[FIX] Read receipts on tablet (#2297)
* fixes not working read receipts on tablet (#2295)

* fixing last commit it to make it work on both tablet and phone

* fix missing close button on tablet's modal view

* Update app/views/ReadReceiptView/index.js

* remove unnecessary param

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:13:44 -03:00
Djorkaeff Alexandre c6401a2d39
[FIX] Room Info actions doesn't check permissions/settings enabled (#2292)
* [FIX] Show Call Button only when Jitsi Enabled (RoomInfoView)

* [FIX] Show user info

* [FIX] Show message button only if it's possible

* [FIX] Create direct only when needed

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:08:15 -03:00
Diego Mello c62346fb2d Merge branch 'develop' into single-server
# Conflicts:
#	android/app/build.gradle
#	app/views/RoomsListView/Header/Header.ios.js
2020-07-17 10:41:23 -03:00
Djorkaeff Alexandre fa6897f339
Bump version to 4.10.0 (#2305) 2020-07-16 17:06:37 -03:00
Dan Caseley 97cd2235df
[CHORE] Consistent Rocket.Chat Branding (#2293)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-15 13:57:36 -03:00
Dan Caseley 3f83daa31a
[TESTS] Test in docker (#2290)
* Add docker env with orchestration

* Update detox, update mocha config format

* One simulator at a time - mocha won't run parallel

* Docker runner, with test changes to match RC data

* Better error trapping in infrastructure control script

* Swap user provisioning from Mongo to RC API to work against existing servers

* Add docker to e2e readme

* Stop using example.com for emails

* Default detox to the tests directory

* Add working configs for both run scenarios

* Add some optional forcing of data.js version for Docker
2020-07-15 13:28:34 -03:00
Diego Mello bbe15b7e41
[FIX] MessageBox not being shown on ShareView when Preview is a video (#2283)
* Wrap video preview with ScrollView so Messagebox is shown properly

* Fix border color
2020-07-14 13:43:15 -03:00
Diego Mello 8a24eb0722
[NEW] Sign in with Apple (#2282)
* Add expo-apple-authentication

* Button

* Create new provisioning profiles

* Login with Apple

* Change provisioning profile

* Button color based on theme

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-14 13:07:45 -03:00
Dan Caseley 6436199780
[CHORE] CircleCI Upgrades (#2269)
* Upgrade nvm

* Upgrade XCode

* Use nvm's default installed version of node (LTS)

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-13 13:52:14 -03:00
phriedrich 7275314854
[i18n] Add missing german strings (#2278)
* cleaned mixed usage of "du" and "Sie"

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-13 13:49:25 -03:00
Snyk bot ab9b0b0f9c
fix: package.json & yarn.lock to reduce vulnerabilities (#2275)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-JPEGJS-570039
- https://snyk.io/vuln/SNYK-JS-LODASH-567746

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-13 13:47:18 -03:00
Heng Sok d3ab125dd4
[FIX] Messages hidden behind MessageBox (#2281) 2020-07-13 13:43:08 -03:00
Djorkaeff Alexandre 146babc3dd
[REGRESSION] Jitsi Call doesn't send message link (#2277) 2020-07-10 09:52:03 -03:00
Diego Mello f3b02a6a88
[FIX] getSettings not catching errors (#2271) 2020-07-09 10:33:04 -03:00
Djorkaeff Alexandre aef7125887
[FIX] Create discussion not working from MessageActions (#2265) 2020-07-08 17:57:05 -03:00