Commit Graph

1556 Commits

Author SHA1 Message Date
Youssef Muhamad 95e228e590
[IMPROVEMENT] TwoFactor component styling (#2328)
* Improve 2fa visual hierarchy

* Show 2fa keyboard by scheduling focus method after all interactions

* Remove unrelated styling improvements

* Improve 2fa component title hierarchy

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:37:42 -03:00
Youssef Muhamad 8c8062ac01
[FIX] Keyboard not focusing on TwoFactor component (#2314)
* Improve 2fa visual hierarchy

* Show 2fa keyboard by scheduling focus method after all interactions

* Remove unrelated styling improvements

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:36:15 -03:00
Youssef Muhamad fc324edafe
[NEW] Log events from Onboarding, NewServer, Login and Register screens (#2169)
* Create method to track user event to isolate the logic to improve future refactoring

* Track Onboarding view

* Track NewServer view

* Refactor track method due to firebase already send the current screen

* Track default login and all the oAuth options

* Track default sign up in RegisterView

* Change trackUserEvent signature and update all the files

* Track the remaining login services

* Resolve requests to improve the importing logs and events

* Leave a bugsnag breadcrumb when logging an event

* Move all logEvent to the top of code block and log remaining fail events

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 16:31:38 -03:00
Dan Caseley df6c2c5424
[TESTS] Idempotence for e2e tests (#2308)
* Idempotence for Assorted

* Idempotence for Onboarding

* Idempotence for Rooms

* Remove redundant expects

* Fixes and improvements

* Remove unneeded sleeps

* Make stable following merge

* Try solving early taps without long sleep

Try solving early taps without long sleep (cont)

Temporary CircleCI hack for quicker testing

Add screenshots to CircleCI for failed tests

Try solving early taps without long sleep (cont. 2)

Revert "Temporary CircleCI hack for quicker testing"

This reverts commit 4abef3a5827910c05b12ac8b8380275b60e8af4f.

* Fix flaky test with a fluent wait on the tap

* Add some new sleeps to workaround #2324

* Add test artifacts to gitignore

* More longpress for dodgy taps, wait for pin response

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-22 13:32:21 -03:00
Diego Mello a5c81b2687
Revert "[CHORE] Update commonmark.js " (#2331) 2020-07-22 11:04:33 -03:00
Neil Agarwal a4b43e9cda
[IMPROVEMENT] Improve our PR Template (#1893)
* [IMPROVEMENT] Improve our PR Template

* Few changes

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-21 11:18:11 -03:00
Diego Mello 7a5a92f33f
[FIX] Style not being applied on RoomsListView header subtitle (#2319) 2020-07-21 11:06:17 -03:00
Diego Mello 9dbe10bcf8
[IMPROVEMENT] Native sort and limit queries (#2249)
* Update WatermelonDB to 0.18.0

* Low onEndReachedThreshold

* Query experiment

* QUERY_SIZE

* Query or fetch data

* Reorder class functions

* Reset variables

* Hide system messages

* Change this.count behaviour

* Starting on RoomsListView

* unsubscribeQuery

* onEndReached

* Separate queries

* Reusable where clause

* Refactoring

* Refactor RoomItem to accept item as prop

* Comment RoomItem tests just so jest passes

* Fix alert and status

* onPress

* Unnecessary diff

* react-fast-compare

* Native limit on ShareListView

* Tweak item description

* Lint

* Fix on foreground crash

* Suggested changes
2020-07-20 13:44:54 -03:00
Diego Mello 9882ace694
Update dependencies (#2301)
* Update RN to 0.63.0-rc.1

* Updating

* Fix keyboard

* Fix native stuff on Messagebox

* Update to RN 0.63.1

* Update pods

* Update patches

* Update minors

* Majors

* Remove base-64 in favour of js-base64

* others

* Pods

* Flipper

* Yarn

* Fix setInput
2020-07-20 13:35:17 -03:00
Rohit Verma 42df5ddbc1
[FIX] MessagesView duplicating content (#2307)
* Fix Pagination duplicacy

* Fix MessageView Duplicate Content

* [FIX] Return fetch func

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-17 15:59:18 -03:00
dependabot[bot] 52b82e5809
Bump lodash from 4.17.16 to 4.17.19 (#2310)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.16 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.16...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-07-17 14:55:53 -03:00
Djorkaeff Alexandre ff8899c39f
[CHORE] Update commonmark libs (#2306)
* [CHORE] Update commonmark fork and relateds

* [CHORE] Update commonmark.js

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:53:13 -03:00
Djorkaeff Alexandre 45cc350a8c
[FIX] Markdown preview causes app stuck (#2303)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:45:39 -03:00
Diego Mello 9b71a785aa
[FIX] In-app notification tap when deep in the stack not redirecting to the room (#2302) 2020-07-17 14:39:59 -03:00
Djorkaeff Alexandre cbe51e2d18
[IMPROVEMENT] Clear image cache when clear cache (#2300)
* [IMPROVEMENT] Clear image cache when clear cache

* use fork instead

* react-native-fast-image -> @rocket.chat/react-native-fast-image

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:39:06 -03:00
phriedrich 812535da43
[FIX] Read receipts on tablet (#2297)
* fixes not working read receipts on tablet (#2295)

* fixing last commit it to make it work on both tablet and phone

* fix missing close button on tablet's modal view

* Update app/views/ReadReceiptView/index.js

* remove unnecessary param

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:13:44 -03:00
Djorkaeff Alexandre c6401a2d39
[FIX] Room Info actions doesn't check permissions/settings enabled (#2292)
* [FIX] Show Call Button only when Jitsi Enabled (RoomInfoView)

* [FIX] Show user info

* [FIX] Show message button only if it's possible

* [FIX] Create direct only when needed

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-17 14:08:15 -03:00
Djorkaeff Alexandre fa6897f339
Bump version to 4.10.0 (#2305) 2020-07-16 17:06:37 -03:00
Dan Caseley 97cd2235df
[CHORE] Consistent Rocket.Chat Branding (#2293)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-15 13:57:36 -03:00
Dan Caseley 3f83daa31a
[TESTS] Test in docker (#2290)
* Add docker env with orchestration

* Update detox, update mocha config format

* One simulator at a time - mocha won't run parallel

* Docker runner, with test changes to match RC data

* Better error trapping in infrastructure control script

* Swap user provisioning from Mongo to RC API to work against existing servers

* Add docker to e2e readme

* Stop using example.com for emails

* Default detox to the tests directory

* Add working configs for both run scenarios

* Add some optional forcing of data.js version for Docker
2020-07-15 13:28:34 -03:00
Diego Mello bbe15b7e41
[FIX] MessageBox not being shown on ShareView when Preview is a video (#2283)
* Wrap video preview with ScrollView so Messagebox is shown properly

* Fix border color
2020-07-14 13:43:15 -03:00
Diego Mello 8a24eb0722
[NEW] Sign in with Apple (#2282)
* Add expo-apple-authentication

* Button

* Create new provisioning profiles

* Login with Apple

* Change provisioning profile

* Button color based on theme

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-14 13:07:45 -03:00
Dan Caseley 6436199780
[CHORE] CircleCI Upgrades (#2269)
* Upgrade nvm

* Upgrade XCode

* Use nvm's default installed version of node (LTS)

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-13 13:52:14 -03:00
phriedrich 7275314854
[i18n] Add missing german strings (#2278)
* cleaned mixed usage of "du" and "Sie"

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-13 13:49:25 -03:00
Snyk bot ab9b0b0f9c
fix: package.json & yarn.lock to reduce vulnerabilities (#2275)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-JPEGJS-570039
- https://snyk.io/vuln/SNYK-JS-LODASH-567746

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-13 13:47:18 -03:00
Heng Sok d3ab125dd4
[FIX] Messages hidden behind MessageBox (#2281) 2020-07-13 13:43:08 -03:00
Djorkaeff Alexandre 146babc3dd
[REGRESSION] Jitsi Call doesn't send message link (#2277) 2020-07-10 09:52:03 -03:00
Diego Mello f3b02a6a88
[FIX] getSettings not catching errors (#2271) 2020-07-09 10:33:04 -03:00
Djorkaeff Alexandre aef7125887
[FIX] Create discussion not working from MessageActions (#2265) 2020-07-08 17:57:05 -03:00
Diego Mello 5782a3363b
[FIX] Notification preferences update crashing the app (#2262) 2020-07-08 17:46:05 -03:00
Diego Mello f70d8285c9
[FIX] Mime type check crashing the app (#2264) 2020-07-08 17:45:38 -03:00
Diego Mello fc8432488e
[FIX] Action sheet cutting emojis on the header (#2263)
* [FIX] Action sheet cutting emojis on the header

* fix tablet case

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
2020-07-08 17:45:13 -03:00
Diego Mello afb0707028
[FIX] Navigation object undefined when tapping sidebar's user header on tablet (#2259) 2020-07-08 16:40:10 -03:00
Diego Mello b8f87f7006
[FIX] Android stack animation throwing illegal node ID (#2260) 2020-07-08 16:38:36 -03:00
Djorkaeff Alexandre 0923851072
[FIX] ImageViewer not recognising gestures after zoomed (#2261)
* [FIX] Zoomed in images must react to gestures

* AnimatedFastImage -> AnimatedImage

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 16:38:09 -03:00
Djorkaeff Alexandre 53cc823dbc
[FIX] Get active route returning undefined (#2257)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 14:00:23 -03:00
Djorkaeff Alexandre ea10693c40
[FIX] Register crashing when error data is undefined (#2256)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 13:52:20 -03:00
Djorkaeff Alexandre ef68f1644a
[FIX] ThreadMessagesView throwing error when subscription wasn't found (#2255)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 13:50:07 -03:00
Djorkaeff Alexandre e1153deb57
[FIX] Command previews crashing when API returns an error (#2254)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 13:42:49 -03:00
Djorkaeff Alexandre 5b3be4ef0b
[FIX] AttachmentView crashing during title decode (#2253)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 13:40:51 -03:00
Djorkaeff Alexandre 362ef0085e
[FIX] Scroll to top crashing when ref is undefined (#2252)
* [FIX] Check if exists scroll ref

* Remove scrollTo

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-08 13:36:37 -03:00
Djorkaeff Alexandre 83fbb8c304
[FIX] Emoji keyboard not showing custom and frequently used emojis on Share Extension (#2251) 2020-07-08 13:19:41 -03:00
Youssef Muhamad 20604c4695
[FIX] Check for UI_Use_Real_Name when sorting rooms (#2230)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-07 10:06:48 -03:00
Diego Mello 7c52e6eada
Bump version to 4.9.0 (#2248) 2020-07-06 17:58:40 -03:00
Diego Mello 5834ab5e22
[IMPROVEMENT] Unified header UX (#2234)
* Change drawer icon

* Removed iOS variation

* Patch to react-navigation-header-buttons... easier to patch then to overwrite its behaviour :(

* Correctly position title

* Header subtitle

* Layout

* Alignment

* RoomView header

* Renamed RoomHeaderLeft to LeftButtons

* RoomView back button

* Search icon on RoomView

* Refactor

* Fix header on tablet

* Fix search messages close button on tablet

* Search key command

* Network status on RoomView header subtitle

* Update tests

* Scale content

* SearchBox cancel color
2020-07-06 17:56:28 -03:00
Neil Agarwal 2ec2a52f45
[IMPROVEMENT] Expo-av audio recorder (#2195)
* [NEW] MessageBox: Expo-av audio recorder

* Refactor MessageBox to accommodate recording button even when recording
* Rename Recording.js -> RecordAudio.js as we could implement video recording in the future

* RecordAudio: Introduce cancel and send buttons

* RecordAudio: Introduce recorderBusy state, refactor MessageBox, remove useless SafeAreaView

* RecordAudio: Better audio quality 🎉, stop recording on unmount

* RecordAudio: Use FileSystem from expo-file-system instead of RNFetchBlob

* chore: flush out react-native-audio

* fix(MessageBox): bring back some missed styles during refactor

* refactor(RecordAudio): use class component

* refactor(RecordAudio): recorder busy to class property, styling changes

* recorder initialisation changes

* fix(RecordAudio): missing await in isRecordingPermissionGranted

* fix(RecordAudio): set isRecording = false on cancel/finish, refactor perms

Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-06 16:23:46 -03:00
Djorkaeff Alexandre f4118b6312
[REGRESSION] Audio Recording (#2240)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-03 11:32:22 -03:00
Djorkaeff Alexandre c1f3f89c09
[FIX] Iframe auth Login Button (#2241)
Co-authored-by: Diego Mello <diegolmello@gmail.com>
2020-07-03 11:23:33 -03:00
Djorkaeff Alexandre 6abfbf615f
[FIX] Send thread attachment (#2242) 2020-07-03 11:07:29 -03:00
Diego Mello a7e7d1fdcb
[FIX] Android crashing when restoring from background (#2238) 2020-07-02 14:14:12 -03:00