fix: Unhandled connection in closed state
gitea/mylogger/pipeline/head This commit looks good Details

This commit is contained in:
Guillermo Bonet 2024-08-28 10:56:16 +02:00
parent 4e709c2091
commit 5857c2294e
2 changed files with 14 additions and 21 deletions

View File

@ -57,12 +57,9 @@ module.exports = class MyLogger {
async init() {
const {conf} = this;
this.debug('MyLogger', 'Initializing.');
this.onErrorListener = err => this.onError(err);
// DB connection
const db = this.db = await mysql.createConnection(conf.dstDb);
db.on('error', this.onErrorListener);
await this.modelLoader.loadSchema();
await this.showDb.loadSchema();
@ -135,8 +132,6 @@ module.exports = class MyLogger {
this.running = false;
this.debug('MyLogger', 'Ending.');
this.db.off('error', this.onErrorListener);
clearInterval(this.flushInterval);
clearInterval(this.pingInterval);
clearInterval(this.flushTimeout);
@ -206,7 +201,6 @@ module.exports = class MyLogger {
zongji.once('error', onError);
zongji.start(zongjiOpts);
});
zongji.on('error', this.onErrorListener);
this.zongji = zongji;
this.debug('Zongji', 'Started.');
}
@ -220,7 +214,6 @@ module.exports = class MyLogger {
this.zongji = null;
zongji.off('binlog', this.onBinlogListener);
zongji.off('error', this.onErrorListener);
// FIXME: Cannot call Zongji.stop(), it doesn't wait to end connection
zongji.connection.destroy(() => {
@ -250,7 +243,7 @@ module.exports = class MyLogger {
}
}
async onError(err) {
async handleError(err) {
if (!this.isOk) return;
this.isOk = false;
console.log(`Error: ${err.code}: ${err.message}`);
@ -259,6 +252,10 @@ module.exports = class MyLogger {
await this.end(true);
} catch(e) {}
// FIXME: Error of mysql2/promise
if (err.message === `Can't add new command when connection is in closed state`)
await this.tryRestart();
else
switch (err.code) {
case 'PROTOCOL_CONNECTION_LOST':
case 'ECONNRESET':
@ -270,10 +267,6 @@ module.exports = class MyLogger {
}
}
handleError(err) {
console.error(err);
}
async onBinlog(evt) {
//evt.dump();
try {

View File

@ -1,6 +1,6 @@
{
"name": "mylogger",
"version": "1.1.4",
"version": "1.1.5",
"author": "Verdnatura Levante SL",
"description": "MySQL and MariaDB logger using binary log",
"license": "GPL-3.0",