refs #5541 Fixes: Cast values before compare, don't cast boolean nulls

mylogger.js

@@ -320,13 +320,12 @@ module.exports = class MyLogger {
       return rowExcludeField && row[rowExcludeField];
     }
 
-    function castValue(col, value) {
+    function cast(value, type) {
-      switch(tableInfo.castTypes.get(col)) {
+      if (value == null || !type)
-        case 'boolean':
+        return value;
-          return !!value;
+
-        default:
+      const fn = castFn[type];
-          return value;
+      return fn ? fn(value) : value;
-      }
     }
 
     function equals(a, b) {
@@ -350,6 +349,8 @@ module.exports = class MyLogger {
       return false;
     }
 
+    const {castTypes} = tableInfo;
+
     if (action == 'update') {
       const cols = tableInfo.columns;
 
@@ -363,13 +364,17 @@ module.exports = class MyLogger {
         let nColsChanged = 0;
 
         for (const col in before) {
-          if (cols.has(col)
+          if (!cols.has(col)) continue;
-          && !equals(after[col], before[col])) {
+          const type = castTypes.get(col);
-            oldI[col] = castValue(col, before[col]);
+          const oldValue = cast(before[col], type);
-            newI[col] = castValue(col, after[col]);
+          const newValue = cast(after[col], type);
+          if (!equals(oldValue, newValue)) {
+            oldI[col] = oldValue;
+            newI[col] = newValue;
             nColsChanged++;
           }
         }
+
         if (nColsChanged)
           changes.push({row: after, oldI, newI});
       }
@@ -381,9 +386,11 @@ module.exports = class MyLogger {
 
         const instance = {};
         for (const col of cols) {
-          if (row[col] !== null)
+          if (row[col] == null) continue;
-            instance[col] = castValue(col, row[col]);
+          const type = castTypes.get(col);
+          instance[col] = cast(row[col], type);
         }
+
         changes.push({row, instance});
       }
     }
@@ -619,3 +626,9 @@ const actionColor = {
   update: 'yellow',
   delete: 'red'
 };
+
+const castFn = {
+  boolean: function(value) {
+    return !!value;
+  }
+};

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "mylogger",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "mylogger",
-      "version": "1.1.1",
+      "version": "1.1.2",
       "license": "GPL-3.0",
       "dependencies": {
         "colors": "^1.4.0",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "mylogger",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "author": "Verdnatura Levante SL",
   "description": "MySQL and MariaDB logger using binary log",
   "license": "GPL-3.0",