verdnatura/myt
verdnatura
/
myt
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

6204-fixturesByEnvironment #2

Merged
jgallego merged 7 commits from 6204-fixturesByEnvironment into master 2023-10-30 06:57:37 +00:00
Conversation 1 Commits 7 Files Changed 5 +5 -21
1 changed files with 5 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b95b593292 - Show all commits

22
myt-push.js
View File

@ -151,21 +151,6 @@ class Push extends Command {
function isUndoScript(script) {
return /\.undo\.sql$/.test(script);
}
function isOtherRealmScript(script, realm) {
const splitScript = script.split('.');
const realmPart = splitScript[splitScript.length - 2];
if (splitScript.length <= 2) {
return false;
}
if (!realm) {
return !!realmPart;
}
return realmPart && realmPart !== realm;
}
jgallego marked this conversation as resolved Outdated
juan commented 2023-09-26 06:56:45 +00:00
Outdated
Review
Copy Link

No es necesario declarar una función, el código solo se utiliza una vez

No es necesario declarar una función, el código solo se utiliza una vez
jgallego commented 2023-09-26 07:58:39 +00:00
Outdated
Review
Copy Link

Cierto te paso una propuesta de como queda sin funcion, pero creo que es bastante menos legible

// Reemplazo de la función isOtherRealmScript
const splitScript = script.split('.');
const realmPart = splitScript[splitScript.length - 2];

if (splitScript.length > 2) {
    if (!realm && realmPart) {
        continue;
    }
    
    if (realmPart && realmPart !== realm) {
        continue;
    }
}
Cierto te paso una propuesta de como queda sin funcion, pero creo que es bastante menos legible ``` // Reemplazo de la función isOtherRealmScript const splitScript = script.split('.'); const realmPart = splitScript[splitScript.length - 2]; if (splitScript.length > 2) { if (!realm && realmPart) { continue; } if (realmPart && realmPart !== realm) { continue; } } ```
const skipFiles = new Set([
'README.md',
@ -235,13 +220,12 @@ class Push extends Command {
continue;
if (match[1]) {
if (skipRealm) {
if (skipRealm)
jgallego marked this conversation as resolved Outdated
juan commented 2023-09-26 06:51:43 +00:00
Outdated
Review
Copy Link

/^[0-9]{2}-[a-zA-Z0-9_]+(\.[a-zA-Z0-9_]+)?\.sql$/

`/^[0-9]{2}-[a-zA-Z0-9_]+(\.[a-zA-Z0-9_]+)?\.sql$/`
juan commented 2023-09-27 09:39:21 +00:00
Outdated
Review
Copy Link
const match = script.match(/^[0-9]{2}-[a-zA-Z0-9_]+(?:\.(?!undo)([a-zA-Z0-9_]+))?(?:\.undo)?\.sql$/);
const skipRealm = match[1] && match[1] !== realm;
``` const match = script.match(/^[0-9]{2}-[a-zA-Z0-9_]+(?:\.(?!undo)([a-zA-Z0-9_]+))?(?:\.undo)?\.sql$/); const skipRealm = match[1] && match[1] !== realm; ```
continue;
}
if (!realm) {
if (!realm)
continue;
}
}
const [[row]] = await conn.query(
`SELECT errorNumber FROM versionLog