From 007b95a616b1519a4876034e11a6c6460de3efa2 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 2 Dec 2024 00:50:31 +0100
Subject: [PATCH] test: remove #q-

---
 src/components/CreateNewCityForm.vue          |  2 +
 src/components/CreateNewPostcodeForm.vue      |  6 +--
 src/components/CreateNewProvinceForm.vue      |  2 +
 .../vnComponent/VnLocation.spec.js            | 50 +++++++++----------
 4 files changed, 31 insertions(+), 29 deletions(-)

diff --git a/src/components/CreateNewCityForm.vue b/src/components/CreateNewCityForm.vue
index 1cbba42fc..9ab942dda 100644
--- a/src/components/CreateNewCityForm.vue
+++ b/src/components/CreateNewCityForm.vue
@@ -48,12 +48,14 @@ const onDataSaved = (...args) => {
                     v-model="data.name"
                     :rules="validate('city.name')"
                     required
+                    data-cy="cityName"
                 />
                 <VnSelectProvince
                     :province-selected="$props.provinceSelected"
                     :country-fk="$props.countryFk"
                     v-model="data.provinceFk"
                     required
+                    data-cy="provinceCity"
                 />
             </VnRow>
         </template>
diff --git a/src/components/CreateNewPostcodeForm.vue b/src/components/CreateNewPostcodeForm.vue
index 8000aac52..d3d6708f0 100644
--- a/src/components/CreateNewPostcodeForm.vue
+++ b/src/components/CreateNewPostcodeForm.vue
@@ -129,7 +129,7 @@ async function filterTowns(name) {
         ref="provincesFetchDataRef"
         @on-fetch="handleProvinces"
         :sort-by="['name ASC']"
-        :limit="2"
+        :limit="30"
         auto-load
         url="Provinces/location"
     />
@@ -153,7 +153,6 @@ async function filterTowns(name) {
         @on-data-saved="onDataSaved"
     >
         <template #form-inputs="{ data, validate }">
-            {{ whereTowns }}
             <VnRow>
                 <VnInput
                     :label="t('Postcode')"
@@ -172,7 +171,6 @@ async function filterTowns(name) {
                     :options="townsOptions"
                     option-label="name"
                     option-value="id"
-                    @input-value="(evt) => (whereTowns.name = { like: `%${evt}%` })"
                     :rules="validate('postcode.city')"
                     :acls="[{ model: 'Town', props: '*', accessType: 'WRITE' }]"
                     :emit-value="false"
@@ -213,7 +211,7 @@ async function filterTowns(name) {
                 />
                 <VnSelect
                     ref="countriesRef"
-                    :limit="2"
+                    :limit="30"
                     :filter="countryFilter"
                     :sort-by="['name ASC']"
                     auto-load
diff --git a/src/components/CreateNewProvinceForm.vue b/src/components/CreateNewProvinceForm.vue
index 887ca957c..d35690eeb 100644
--- a/src/components/CreateNewProvinceForm.vue
+++ b/src/components/CreateNewProvinceForm.vue
@@ -53,8 +53,10 @@ const where = computed(() => {
                     v-model="data.name"
                     :rules="validate('province.name')"
                     required
+                    data-cy="provinceName"
                 />
                 <VnSelect
+                    data-cy="autonomyProvince"
                     required
                     ref="autonomiesRef"
                     auto-load
diff --git a/test/cypress/integration/vnComponent/VnLocation.spec.js b/test/cypress/integration/vnComponent/VnLocation.spec.js
index 1fea8f738..eab5d63b9 100644
--- a/test/cypress/integration/vnComponent/VnLocation.spec.js
+++ b/test/cypress/integration/vnComponent/VnLocation.spec.js
@@ -116,7 +116,7 @@ describe('VnLocation', () => {
             checkVnLocation(postCode, province);
         });
 
-        it('Create city without country', () => {
+        it.only('Create city without country', () => {
             const postCode = randomNumber();
             const province = randomString({ length: 4 });
             cy.get(createLocationButton).click();
@@ -124,8 +124,8 @@ describe('VnLocation', () => {
             cy.get(
                 `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2) `
             ).click();
-            cy.selectOption('#q-portal--dialog--3 .q-select', 'one');
-            cy.get('#q-portal--dialog--3 .q-input').type(province);
+            cy.selectOption('[data-cy="locationProvince"]:last', 'Province one');
+            cy.get('[data-cy="cityName"]').type(province);
             cy.dataCy('FormModelPopup_save').eq(1).click();
             cy.dataCy('FormModelPopup_save').eq(0).click();
 
@@ -133,22 +133,7 @@ describe('VnLocation', () => {
             checkVnLocation(postCode, province);
         });
 
-        it.only('Create province without country', () => {
-            const provinceName = 'Saskatchew'.concat(Math.random(1 * 100));
-            cy.get(createLocationButton).click();
-            cy.get(
-                `${createForm.prefix} > :nth-child(5) > .q-select > ${createForm.sufix} > :nth-child(2) `
-            )
-                .eq(0)
-                .click();
-            cy.selectOption('#q-portal--dialog--3 .q-select', 'one');
-            cy.countSelectOptions('#q-portal--dialog--3 .q-select', 4);
-            cy.get('#q-portal--dialog--3 .q-input').type(provinceName);
-
-            cy.dataCy('FormModelPopup_save').eq(1).click();
-        });
-
-        it('Create city with country', () => {
+        it.only('Create city with country', () => {
             const cityName = 'Saskatchew'.concat(Math.random(1 * 100));
             cy.get(createLocationButton).click();
             cy.selectOption(
@@ -158,10 +143,25 @@ describe('VnLocation', () => {
             cy.get(
                 `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2)  `
             ).click();
-            cy.selectOption('#q-portal--dialog--4 .q-select', 'Province four');
-            cy.countSelectOptions('#q-portal--dialog--4 .q-select', 1);
+            cy.selectOption('[data-cy="locationProvince"]:last', 'Province four');
+            cy.countSelectOptions('[data-cy="locationProvince"]:last', 1);
+
+            cy.get('[data-cy="cityName"]').type(cityName);
+            cy.dataCy('FormModelPopup_save').eq(1).click();
+        });
+
+        it('Create province without country', () => {
+            const provinceName = 'Saskatchew'.concat(Math.random(1 * 100));
+            cy.get(createLocationButton).click();
+            cy.get(
+                `${createForm.prefix} > :nth-child(5) > .q-select > ${createForm.sufix} > :nth-child(2) `
+            )
+                .eq(0)
+                .click();
+            cy.selectOption('[data-cy="autonomyProvince"] ', 'Autonomy one');
+            cy.countSelectOptions('[data-cy="autonomyProvince"]', 4);
+            cy.get('[data-cy="provinceName"]').type(provinceName);
 
-            cy.get('#q-portal--dialog--4 .q-input').type(cityName);
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 
@@ -178,10 +178,10 @@ describe('VnLocation', () => {
                 .eq(0)
                 .click();
 
-            cy.selectOption('#q-portal--dialog--4 .q-select', 'one');
-            cy.countSelectOptions('#q-portal--dialog--4 .q-select', 2);
+            cy.selectOption('[data-cy="autonomyProvince"] ', 'Autonomy one');
+            cy.countSelectOptions('[data-cy="autonomyProvince"]', 2);
 
-            cy.get('#q-portal--dialog--4 .q-input').type(provinceName);
+            cy.get('[data-cy="provinceName"]').type(provinceName);
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });