From 68d2b97ced380f09b25fe44e6c7e986f06128c0e Mon Sep 17 00:00:00 2001 From: jorgep Date: Thu, 6 Feb 2025 13:28:46 +0100 Subject: [PATCH 1/5] refactor: refs #7524 remove limit and sort parameters from FetchData components --- src/components/CreateNewPostcodeForm.vue | 47 +------------------ src/components/CreateNewProvinceForm.vue | 5 +- src/components/ItemsFilterPanel.vue | 15 +----- src/pages/Entry/EntryLatestBuysFilter.vue | 29 +++--------- src/pages/InvoiceIn/Card/InvoiceInDueDay.vue | 17 ++----- src/pages/Item/ItemFixedPriceFilter.vue | 20 ++------ .../Route/Roadmap/RoadmapAddStopForm.vue | 1 - src/pages/Route/Roadmap/RoadmapBasicData.vue | 20 ++------ src/pages/Route/Roadmap/RoadmapFilter.vue | 14 ++---- 9 files changed, 25 insertions(+), 143 deletions(-) diff --git a/src/components/CreateNewPostcodeForm.vue b/src/components/CreateNewPostcodeForm.vue index 39ebfe540..8c9fb5a7c 100644 --- a/src/components/CreateNewPostcodeForm.vue +++ b/src/components/CreateNewPostcodeForm.vue @@ -21,14 +21,11 @@ const postcodeFormData = reactive({ provinceFk: null, townFk: null, }); -const townsFetchDataRef = ref(false); const townFilter = ref({}); const countriesRef = ref(false); const provincesOptions = ref([]); -const townsOptions = ref([]); const town = ref({}); -const countryFilter = ref({}); function onDataSaved(formData) { const newPostcode = { @@ -51,7 +48,6 @@ async function setCountry(countryFk, data) { data.townFk = null; data.provinceFk = null; data.countryFk = countryFk; - await fetchTowns(); } // Province @@ -60,22 +56,11 @@ async function setProvince(id, data) { const newProvince = provincesOptions.value.find((province) => province.id == id); if (newProvince) data.countryFk = newProvince.countryFk; postcodeFormData.provinceFk = id; - await fetchTowns(); } async function onProvinceCreated(data) { postcodeFormData.provinceFk = data.id; } -function provinceByCountry(countryFk = postcodeFormData.countryFk) { - return provincesOptions.value - .filter((province) => province.countryFk === countryFk) - .map(({ id }) => id); -} - -// Town -async function handleTowns(data) { - townsOptions.value = data; -} function setTown(newTown, data) { town.value = newTown; data.provinceFk = newTown?.provinceFk ?? newTown; @@ -88,18 +73,6 @@ async function onCityCreated(newTown, formData) { formData.townFk = newTown; setTown(newTown, formData); } -async function fetchTowns(countryFk = postcodeFormData.countryFk) { - if (!countryFk) return; - const provinces = postcodeFormData.provinceFk - ? [postcodeFormData.provinceFk] - : provinceByCountry(); - townFilter.value.where = { - provinceFk: { - inq: provinces, - }, - }; - await townsFetchDataRef.value?.fetch(); -} async function filterTowns(name) { if (name !== '') { @@ -108,22 +81,11 @@ async function filterTowns(name) { like: `%${name}%`, }, }; - await townsFetchDataRef.value?.fetch(); } }