From 25b8535f192cfc5bb0dad7ecb1e0bb034df6eefc Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Wed, 27 Nov 2024 12:54:11 +0100
Subject: [PATCH 1/5] refactor: refs #6818 check prefix

---
 src/components/ui/VnLinkPhone.vue             | 16 ++++++++---
 src/filters/parsePhone.js                     | 18 ++++++-------
 src/pages/Customer/Card/CustomerSummary.vue   |  1 +
 .../components/common/VnLinkPhone.spec.js     | 27 +++++++++++--------
 4 files changed, 37 insertions(+), 25 deletions(-)

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index 4068498cd..6fefd1914 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -1,10 +1,10 @@
 <script setup>
 import { reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
 import axios from 'axios';
-import { parsePhone } from 'src/filters';
 const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
     channel: { type: Number, default: null },
+    country: { type: String, default: null },
 });
 
 const config = reactive({
@@ -25,11 +25,19 @@ onBeforeMount(async () => {
             .data;
         if (!channel) channel = defaultChannel;
 
-        config[type].href = `${url}?customerIdentity=%2B${parsePhone(
-            props.phoneNumber
-        )}&channelId=${channel}`;
+        const phone = await parsePhone(props.phoneNumber, props.country.toLowerCase());
+        config[type].href = `${url}?customerIdentity=%2B${phone}&channelId=${channel}`;
     }
 });
+
+async function parsePhone(phone, country) {
+    if (phone.startsWith('+')) return `${phone.slice(1)}`;
+    if (phone.startsWith('00')) return `${phone.slice(2)}`;
+
+    const prefix = (await axios.get(`Prefixes/${country.toLowerCase()}`)).data?.prefix;
+    if (phone.startsWith(prefix)) return phone;
+    return `${prefix}${phone}`;
+}
 </script>
 <template>
     <QBtn
diff --git a/src/filters/parsePhone.js b/src/filters/parsePhone.js
index 696f55007..f99ab0646 100644
--- a/src/filters/parsePhone.js
+++ b/src/filters/parsePhone.js
@@ -1,12 +1,10 @@
-export default function (phone, prefix = 34) {
-    if (phone.startsWith('+')) {
-        return `${phone.slice(1)}`;
-    }
-    if (phone.startsWith('00')) {
-        return `${phone.slice(2)}`;
-    }
-    if (phone.startsWith(prefix) && phone.length === prefix.length + 9) {
-        return `${prefix}${phone.slice(prefix.length)}`;
-    }
+import axios from 'axios';
+
+export default async function parsePhone(phone, country) {
+    if (phone.startsWith('+')) return `${phone.slice(1)}`;
+    if (phone.startsWith('00')) return `${phone.slice(2)}`;
+
+    const prefix = (await axios.get(`Prefixes/${country.toLowerCase()}`)).data?.prefix;
+    if (phone.startsWith(prefix)) return phone;
     return `${prefix}${phone}`;
 }
diff --git a/src/pages/Customer/Card/CustomerSummary.vue b/src/pages/Customer/Card/CustomerSummary.vue
index 4fa7b9bdc..2cad13115 100644
--- a/src/pages/Customer/Card/CustomerSummary.vue
+++ b/src/pages/Customer/Card/CustomerSummary.vue
@@ -95,6 +95,7 @@ const sumRisk = ({ clientRisks }) => {
                             :phone-number="entity.mobile"
                             :channel="entity.country?.saySimpleCountry?.channel"
                             class="q-ml-xs"
+                            :country="entity.country?.code"
                         />
                     </template>
                 </VnLv>
diff --git a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
index e460ab2fc..a14e509ae 100644
--- a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
+++ b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
@@ -1,29 +1,34 @@
-import { describe, it, expect } from 'vitest';
+import { describe, it, expect, beforeAll, vi } from 'vitest';
+import { axios } from 'app/test/vitest/helper';
 import parsePhone from 'src/filters/parsePhone';
 
 describe('parsePhone filter', () => {
-    it("adds prefix +34 if it doesn't have one", () => {
-        const resultado = parsePhone('123456789', '34');
+    beforeAll(async () => {
+        vi.spyOn(axios, 'get').mockReturnValue({ data: { prefix: '34' } });
+    });
+
+    it("adds prefix +34 if it doesn't have one", async () => {
+        const resultado = await parsePhone('123456789', '34');
         expect(resultado).toBe('34123456789');
     });
 
-    it('maintains prefix +34 if it is already correct', () => {
-        const resultado = parsePhone('+34123456789', '34');
+    it('maintains prefix +34 if it is already correct', async () => {
+        const resultado = await parsePhone('+34123456789', '34');
         expect(resultado).toBe('34123456789');
     });
 
-    it('converts prefix 0034 to +34', () => {
-        const resultado = parsePhone('0034123456789', '34');
+    it('converts prefix 0034 to +34', async () => {
+        const resultado = await parsePhone('0034123456789', '34');
         expect(resultado).toBe('34123456789');
     });
 
-    it('converts prefix 34 without symbol to +34', () => {
-        const resultado = parsePhone('34123456789', '34');
+    it('converts prefix 34 without symbol to +34', async () => {
+        const resultado = await parsePhone('34123456789', '34');
         expect(resultado).toBe('34123456789');
     });
 
-    it('replaces incorrect prefix with the correct one', () => {
-        const resultado = parsePhone('+44123456789', '34');
+    it('replaces incorrect prefix with the correct one', async () => {
+        const resultado = await parsePhone('+44123456789', '34');
         expect(resultado).toBe('44123456789');
     });
 });

From d4028da92e976b68dae1032b95ae33d5002fd68b Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Thu, 28 Nov 2024 10:25:50 +0100
Subject: [PATCH 2/5] fix: refs #6818 refactor phone parsing and improve error
 handling

---
 src/components/ui/VnLinkPhone.vue | 22 +++++++++-------------
 src/filters/parsePhone.js         | 13 +++++++++----
 2 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index 6fefd1914..c5023f69e 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -1,12 +1,15 @@
 <script setup>
-import { reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
+import { ref, reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
 import axios from 'axios';
+import { parsePhone } from 'src/filters';
+
 const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
     channel: { type: Number, default: null },
     country: { type: String, default: null },
 });
 
+const phone = ref(props.phoneNumber);
 const config = reactive({
     sip: { icon: 'phone', href: `sip:${props.phoneNumber}` },
     'say-simple': {
@@ -25,23 +28,16 @@ onBeforeMount(async () => {
             .data;
         if (!channel) channel = defaultChannel;
 
-        const phone = await parsePhone(props.phoneNumber, props.country.toLowerCase());
-        config[type].href = `${url}?customerIdentity=%2B${phone}&channelId=${channel}`;
+        phone.value = await parsePhone(props.phoneNumber, props.country.toLowerCase());
+        config[
+            type
+        ].href = `${url}?customerIdentity=%2B${phone.value}&channelId=${channel}`;
     }
 });
-
-async function parsePhone(phone, country) {
-    if (phone.startsWith('+')) return `${phone.slice(1)}`;
-    if (phone.startsWith('00')) return `${phone.slice(2)}`;
-
-    const prefix = (await axios.get(`Prefixes/${country.toLowerCase()}`)).data?.prefix;
-    if (phone.startsWith(prefix)) return phone;
-    return `${prefix}${phone}`;
-}
 </script>
 <template>
     <QBtn
-        v-if="phoneNumber"
+        v-if="phone"
         flat
         round
         :icon="config[type].icon"
diff --git a/src/filters/parsePhone.js b/src/filters/parsePhone.js
index f99ab0646..4fcf1386d 100644
--- a/src/filters/parsePhone.js
+++ b/src/filters/parsePhone.js
@@ -3,8 +3,13 @@ import axios from 'axios';
 export default async function parsePhone(phone, country) {
     if (phone.startsWith('+')) return `${phone.slice(1)}`;
     if (phone.startsWith('00')) return `${phone.slice(2)}`;
-
-    const prefix = (await axios.get(`Prefixes/${country.toLowerCase()}`)).data?.prefix;
-    if (phone.startsWith(prefix)) return phone;
-    return `${prefix}${phone}`;
+    try {
+        const prefix = (
+            await axios.get(`Prefixes/${country.toLowerCase()}`)
+        ).data?.prefix.replace(/^0+/, '');
+        if (phone.startsWith(prefix)) return phone;
+        return `${prefix}${phone}`;
+    } catch (e) {
+        return null;
+    }
 }

From 6745c15b0efe762aa9403b97252ed2aa3c7747f1 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Thu, 28 Nov 2024 10:28:06 +0100
Subject: [PATCH 3/5] fix: refs #6818 add early return for empty phone input in
 parsePhone function

---
 src/filters/parsePhone.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/filters/parsePhone.js b/src/filters/parsePhone.js
index 4fcf1386d..27474321f 100644
--- a/src/filters/parsePhone.js
+++ b/src/filters/parsePhone.js
@@ -1,6 +1,7 @@
 import axios from 'axios';
 
 export default async function parsePhone(phone, country) {
+    if (!phone) return;
     if (phone.startsWith('+')) return `${phone.slice(1)}`;
     if (phone.startsWith('00')) return `${phone.slice(2)}`;
     try {

From 7693d193f03c504efdc2278be8799c278f0a73ca Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Mon, 2 Dec 2024 10:36:18 +0100
Subject: [PATCH 4/5] feat: refs #6818 add URL handling vn-link-phone

---
 src/components/ui/VnLinkPhone.vue             | 14 ++++++++---
 .../components/common/VnLinkPhone.spec.js     | 25 +++++++++++--------
 2 files changed, 25 insertions(+), 14 deletions(-)

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index c5023f69e..c5d5df394 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -2,6 +2,7 @@
 import { ref, reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
 import axios from 'axios';
 import { parsePhone } from 'src/filters';
+import useOpenURL from 'src/composables/useOpenURL';
 
 const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
@@ -14,13 +15,14 @@ const config = reactive({
     sip: { icon: 'phone', href: `sip:${props.phoneNumber}` },
     'say-simple': {
         icon: 'vn:saysimple',
-        href: null,
+        url: null,
         channel: props.channel,
     },
 });
 const type = Object.keys(config).find((key) => key in useAttrs()) || 'sip';
 
 onBeforeMount(async () => {
+    if (!phone.value) return;
     let { channel } = config[type];
 
     if (type === 'say-simple') {
@@ -31,9 +33,14 @@ onBeforeMount(async () => {
         phone.value = await parsePhone(props.phoneNumber, props.country.toLowerCase());
         config[
             type
-        ].href = `${url}?customerIdentity=%2B${phone.value}&channelId=${channel}`;
+        ].url = `${url}?customerIdentity=%2B${phone.value}&channelId=${channel}`;
     }
 });
+
+function handleClick() {
+    if (config[type].url) useOpenURL(config[type].url);
+    else if (config[type].href) window.location.href = config[type].href;
+}
 </script>
 <template>
     <QBtn
@@ -44,8 +51,7 @@ onBeforeMount(async () => {
         size="sm"
         color="primary"
         padding="none"
-        :href="config[type].href"
-        @click.stop
+        @click.stop="handleClick"
     >
         <QTooltip>
             {{ capitalize(type).replace('-', '') }}
diff --git a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
index a14e509ae..8b59ed1dc 100644
--- a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
+++ b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
@@ -7,28 +7,33 @@ describe('parsePhone filter', () => {
         vi.spyOn(axios, 'get').mockReturnValue({ data: { prefix: '34' } });
     });
 
+    it('no phone', () => {
+        const phone = parsePhone(null, '34');
+        expect(phone).toBe(undefined);
+    });
+
     it("adds prefix +34 if it doesn't have one", async () => {
-        const resultado = await parsePhone('123456789', '34');
-        expect(resultado).toBe('34123456789');
+        const phone = await parsePhone('123456789', '34');
+        expect(phone).toBe('34123456789');
     });
 
     it('maintains prefix +34 if it is already correct', async () => {
-        const resultado = await parsePhone('+34123456789', '34');
-        expect(resultado).toBe('34123456789');
+        const phone = await parsePhone('+34123456789', '34');
+        expect(phone).toBe('34123456789');
     });
 
     it('converts prefix 0034 to +34', async () => {
-        const resultado = await parsePhone('0034123456789', '34');
-        expect(resultado).toBe('34123456789');
+        const phone = await parsePhone('0034123456789', '34');
+        expect(phone).toBe('34123456789');
     });
 
     it('converts prefix 34 without symbol to +34', async () => {
-        const resultado = await parsePhone('34123456789', '34');
-        expect(resultado).toBe('34123456789');
+        const phone = await parsePhone('34123456789', '34');
+        expect(phone).toBe('34123456789');
     });
 
     it('replaces incorrect prefix with the correct one', async () => {
-        const resultado = await parsePhone('+44123456789', '34');
-        expect(resultado).toBe('44123456789');
+        const phone = await parsePhone('+44123456789', '34');
+        expect(phone).toBe('44123456789');
     });
 });

From c341c0617089dfcf1b21965ac79806b9aa870877 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Mon, 2 Dec 2024 10:36:30 +0100
Subject: [PATCH 5/5] fix: refs #6818 test

---
 test/vitest/__tests__/components/common/VnLinkPhone.spec.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
index 8b59ed1dc..1505e32f7 100644
--- a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
+++ b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
@@ -7,8 +7,8 @@ describe('parsePhone filter', () => {
         vi.spyOn(axios, 'get').mockReturnValue({ data: { prefix: '34' } });
     });
 
-    it('no phone', () => {
-        const phone = parsePhone(null, '34');
+    it('no phone', async () => {
+        const phone = await parsePhone(null, '34');
         expect(phone).toBe(undefined);
     });