From 21eda340a8c5dad2f9b70456cab471aa9e389f3b Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Tue, 26 Nov 2024 22:57:47 +0100
Subject: [PATCH 1/3] fix: #6818 VnLinkPhone using spanish prefix

---
 src/components/ui/VnLinkPhone.vue |  7 ++++---
 src/filters/index.js              |  2 ++
 src/filters/parsePhone.js         | 15 +++++++++++++++
 3 files changed, 21 insertions(+), 3 deletions(-)
 create mode 100644 src/filters/parsePhone.js

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index 4c045968f..4068498cd 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -1,6 +1,7 @@
 <script setup>
 import { reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
 import axios from 'axios';
+import { parsePhone } from 'src/filters';
 const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
     channel: { type: Number, default: null },
@@ -24,9 +25,9 @@ onBeforeMount(async () => {
             .data;
         if (!channel) channel = defaultChannel;
 
-        config[
-            type
-        ].href = `${url}?customerIdentity=%2B${props.phoneNumber}&channelId=${channel}`;
+        config[type].href = `${url}?customerIdentity=%2B${parsePhone(
+            props.phoneNumber
+        )}&channelId=${channel}`;
     }
 });
 </script>
diff --git a/src/filters/index.js b/src/filters/index.js
index ce5c44706..1f7ac77dd 100644
--- a/src/filters/index.js
+++ b/src/filters/index.js
@@ -12,10 +12,12 @@ import dateRange from './dateRange';
 import toHour from './toHour';
 import dashOrCurrency from './dashOrCurrency';
 import getParamWhere from './getParamWhere';
+import parsePhone from './parsePhone';
 import isDialogOpened from './isDialogOpened';
 
 export {
     isDialogOpened,
+    parsePhone,
     toLowerCase,
     toLowerCamel,
     toDate,
diff --git a/src/filters/parsePhone.js b/src/filters/parsePhone.js
new file mode 100644
index 000000000..b2d1ed7b8
--- /dev/null
+++ b/src/filters/parsePhone.js
@@ -0,0 +1,15 @@
+export default function (phone, prefix = 34) {
+    if (phone.startsWith('+')) {
+        console.log('a');
+        return `${phone.slice(1)}`;
+    }
+    if (phone.startsWith('00')) {
+        console.log('b');
+        return `${phone.slice(2)}`;
+    }
+    if (phone.startsWith(prefix) && phone.length === prefix.length + 9) {
+        console.log('c');
+        return `${prefix}${phone.slice(prefix.length)}`;
+    }
+    return `${prefix}${phone}`;
+}

From 1b3500bbce1cdfcf84bb91e11b648beb892a80e1 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Tue, 26 Nov 2024 22:58:36 +0100
Subject: [PATCH 2/3] test: add vitest VnLinkPhone filter

---
 src/filters/parsePhone.js                     |  3 --
 .../components/common/VnLinkPhone.spec.js     | 29 +++++++++++++++++++
 2 files changed, 29 insertions(+), 3 deletions(-)
 create mode 100644 test/vitest/__tests__/components/common/VnLinkPhone.spec.js

diff --git a/src/filters/parsePhone.js b/src/filters/parsePhone.js
index b2d1ed7b8..696f55007 100644
--- a/src/filters/parsePhone.js
+++ b/src/filters/parsePhone.js
@@ -1,14 +1,11 @@
 export default function (phone, prefix = 34) {
     if (phone.startsWith('+')) {
-        console.log('a');
         return `${phone.slice(1)}`;
     }
     if (phone.startsWith('00')) {
-        console.log('b');
         return `${phone.slice(2)}`;
     }
     if (phone.startsWith(prefix) && phone.length === prefix.length + 9) {
-        console.log('c');
         return `${prefix}${phone.slice(prefix.length)}`;
     }
     return `${prefix}${phone}`;
diff --git a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
new file mode 100644
index 000000000..1d679d979
--- /dev/null
+++ b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
@@ -0,0 +1,29 @@
+import { describe, it, expect } from 'vitest';
+import parsePhone from 'src/filters/parsePhone';
+
+describe.only('parsePhone filter', () => {
+    it("adds prefix +34 if it doesn't have one", () => {
+        const resultado = parsePhone('123456789', '34');
+        expect(resultado).toBe('34123456789');
+    });
+
+    it('maintains prefix +34 if it is already correct', () => {
+        const resultado = parsePhone('+34123456789', '34');
+        expect(resultado).toBe('34123456789');
+    });
+
+    it('converts prefix 0034 to +34', () => {
+        const resultado = parsePhone('0034123456789', '34');
+        expect(resultado).toBe('34123456789');
+    });
+
+    it('converts prefix 34 without symbol to +34', () => {
+        const resultado = parsePhone('34123456789', '34');
+        expect(resultado).toBe('34123456789');
+    });
+
+    it.only('replaces incorrect prefix with the correct one', () => {
+        const resultado = parsePhone('+44123456789', '34');
+        expect(resultado).toBe('44123456789');
+    });
+});

From 72a481ae5b4aed6768b7db6be2fdbb3c7520093b Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 27 Nov 2024 01:30:42 +0100
Subject: [PATCH 3/3] test: remove only

---
 test/vitest/__tests__/components/common/VnLinkPhone.spec.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
index 1d679d979..e460ab2fc 100644
--- a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
+++ b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
@@ -1,7 +1,7 @@
 import { describe, it, expect } from 'vitest';
 import parsePhone from 'src/filters/parsePhone';
 
-describe.only('parsePhone filter', () => {
+describe('parsePhone filter', () => {
     it("adds prefix +34 if it doesn't have one", () => {
         const resultado = parsePhone('123456789', '34');
         expect(resultado).toBe('34123456789');
@@ -22,7 +22,7 @@ describe.only('parsePhone filter', () => {
         expect(resultado).toBe('34123456789');
     });
 
-    it.only('replaces incorrect prefix with the correct one', () => {
+    it('replaces incorrect prefix with the correct one', () => {
         const resultado = parsePhone('+44123456789', '34');
         expect(resultado).toBe('44123456789');
     });