From 21c7b2088bbc98757cb2a337df6fe0f2e5ace524 Mon Sep 17 00:00:00 2001
From: pablone <pablone@verdnatura.es>
Date: Thu, 24 Apr 2025 13:57:36 +0200
Subject: [PATCH] refactor: refs #8684 improve slot usage and clean up ItemTags
 and ItemListFilter components

---
 src/components/common/VnSection.vue |  2 +-
 src/pages/Item/Card/ItemTags.vue    |  4 +-
 src/pages/Item/ItemListFilter.vue   | 78 ++++-------------------------
 3 files changed, 13 insertions(+), 71 deletions(-)

diff --git a/src/components/common/VnSection.vue b/src/components/common/VnSection.vue
index 66329d3e9..34eb14601 100644
--- a/src/components/common/VnSection.vue
+++ b/src/components/common/VnSection.vue
@@ -106,7 +106,7 @@ function checkIsMain() {
                         <slot
                             name="moreFilterPanel"
                             v-bind="{ params, orders, searchFn }"
-                        ></slot>
+                        />
                     </template>
                 </VnTableFilter>
             </slot>
diff --git a/src/pages/Item/Card/ItemTags.vue b/src/pages/Item/Card/ItemTags.vue
index 1efeeadea..2ee1fe692 100644
--- a/src/pages/Item/Card/ItemTags.vue
+++ b/src/pages/Item/Card/ItemTags.vue
@@ -17,7 +17,7 @@ const itemTagsRef = ref();
 const tagOptions = ref([]);
 const valueOptionsMap = ref(new Map());
 const getSelectedTagValues = async (tag) => {
-    if (!tag.tagFk && tag.tag.isFree) return;
+    if (!tag.tagFk && tag.tag?.isFree) return;
     const filter = {
         fields: ['value'],
         order: 'value ASC',
@@ -25,6 +25,7 @@ const getSelectedTagValues = async (tag) => {
     };
 
     const params = { filter: JSON.stringify(filter) };
+    if (!tag.tagFk) return;
     const { data } = await axios.get(`Tags/${tag.tagFk}/filterValue`, {
         params,
     });
@@ -143,7 +144,6 @@ const insertTag = (rows) => {
                                 v-model="row.priority"
                                 :required="true"
                                 :rules="validate('itemTag.priority')"
-                                style="max-width: 60%"
                             />
                             <div class="row justify-center" style="flex: 0">
                                 <QIcon
diff --git a/src/pages/Item/ItemListFilter.vue b/src/pages/Item/ItemListFilter.vue
index b32b3910f..bb4e5f70f 100644
--- a/src/pages/Item/ItemListFilter.vue
+++ b/src/pages/Item/ItemListFilter.vue
@@ -227,6 +227,16 @@ onMounted(async () => {
                     />
                 </QItemSection>
             </QItem>
+            <QItem>
+                <QItemSection>
+                    <QCheckbox
+                        :label="t('params.isFloramondo')"
+                        v-model="params.isFloramondo"
+                        toggle-indeterminate
+                        @update:model-value="searchFn()"
+                    />
+                </QItemSection>
+            </QItem>
             <!-- Tags filter -->
             <QItemLabel header>
                 {{ t('params.tags') }}
@@ -293,74 +303,6 @@ onMounted(async () => {
                     @click="removeTag(index, params, searchFn)"
                 />
             </QItem>
-            <!-- Filter fields -->
-            <QItemLabel header
-                >{{ t('More fields') }}
-                <QIcon
-                    name="add_circle"
-                    class="fill-icon-on-hover q-ml-md"
-                    size="sm"
-                    color="primary"
-                    @click="fieldFiltersValues.push({})"
-            /></QItemLabel>
-            <QItem v-for="(fieldFilter, index) in fieldFiltersValues" :key="index">
-                <QItemSection class="col">
-                    <VnSelect
-                        class="full-width"
-                        :label="t('params.tag')"
-                        :model-value="fieldFilter.selectedField"
-                        :options="moreFields"
-                        option-label="label"
-                        option-value="label"
-                        dense
-                        filled
-                        :emit-value="false"
-                        use-input
-                        :is-clearable="false"
-                        @update:model-value="
-                            ($event) => {
-                                fieldFilter.name = $event.name;
-                                fieldFilter.value = null;
-                                fieldFilter.selectedField = $event;
-                            }
-                        "
-                    />
-                </QItemSection>
-                <QItemSection class="col">
-                    <VnCheckbox
-                        v-if="fieldFilter.selectedField?.type === 'boolean'"
-                        v-model="fieldFilter.value"
-                        :label="t('params.value')"
-                        @update:model-value="applyFieldFilters(params, searchFn)"
-                    />
-                    <VnInput
-                        v-else
-                        v-model="fieldFilter.value"
-                        :label="t('params.value')"
-                        :disable="!fieldFilter.selectedField"
-                        filled
-                        @keydown.enter="applyFieldFilters(params, searchFn)"
-                    />
-                </QItemSection>
-                <QItemSection side
-                    ><QIcon
-                        name="delete"
-                        class="fill-icon-on-hover q-ml-xs"
-                        size="sm"
-                        color="primary"
-                        @click="removeFieldFilter(index, params, searchFn)"
-                /></QItemSection>
-            </QItem>
-            <QItem>
-                <QItemSection>
-                    <QCheckbox
-                        :label="t('params.isFloramondo')"
-                        v-model="params.isFloramondo"
-                        toggle-indeterminate
-                        @update:model-value="searchFn()"
-                    />
-                </QItemSection>
-            </QItem>
         </template>
     </VnFilterPanel>
 </template>