From 2c134f9935221bef7b4d153fae71e50e2b2feca1 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Tue, 11 Mar 2025 12:52:02 +0100
Subject: [PATCH] refactor: refs #8581 simplify createCorrective function and
 update assertions for invoice creation

---
 .../invoiceIn/invoiceInDescriptor.spec.js     | 21 ++++++-------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/test/cypress/integration/invoiceIn/invoiceInDescriptor.spec.js b/test/cypress/integration/invoiceIn/invoiceInDescriptor.spec.js
index 44b44d271..d6964868f 100644
--- a/test/cypress/integration/invoiceIn/invoiceInDescriptor.spec.js
+++ b/test/cypress/integration/invoiceIn/invoiceInDescriptor.spec.js
@@ -85,12 +85,12 @@ describe('InvoiceInDescriptor', () => {
         beforeEach(() => cy.visit(`/#/invoice-in/${originalId}/summary`));
 
         it('should create a correcting invoice and redirect to original invoice', () => {
-            createCorrective({ class: 'R5', type: 'sustitución', reason: 'VAT' });
+            createCorrective();
             redirect(originalId);
         });
 
         it('should create a correcting invoice and navigate to list filtered by corrective', () => {
-            createCorrective({ class: 'R3', type: 'diferencias', reason: 'customer' });
+            createCorrective();
             redirect(originalId);
 
             cy.clicDescriptorAction(4);
@@ -123,28 +123,19 @@ describe('InvoiceInDescriptor', () => {
     });
 });
 
-function createCorrective(opts = {}) {
+function createCorrective() {
     cy.intercept('POST', '/api/InvoiceIns/corrective').as('corrective');
-    const { type, reason, class: classVal } = opts;
 
     cy.selectDescriptorOption(4);
-    cy.fillInForm(
-        {
-            invoiceInDescriptorMenu_class: { val: classVal, type: 'select' },
-            invoiceInDescriptorMenu_type: { val: type, type: 'select' },
-            invoiceInDescriptorMenu_reason: { val: reason, type: 'select' },
-        },
-        { form: '[data-cy="correctiveInvoiceDialog"]', attr: 'data-cy' },
-    );
     cy.dataCy('saveCorrectiveInvoice').click();
 
     cy.wait('@corrective').then(({ response }) => {
         const correctingId = response.body;
         cy.url().should('include', `/invoice-in/${correctingId}/summary`);
         cy.visit(`/#/invoice-in/${correctingId}/corrective`);
-        cy.dataCy('invoiceInCorrective_class').should('contain.value', classVal);
-        cy.dataCy('invoiceInCorrective_type').should('contain.value', type);
-        cy.dataCy('invoiceInCorrective_reason').should('contain.value', reason);
+        cy.dataCy('invoiceInCorrective_class').should('contain.value', 'R2');
+        cy.dataCy('invoiceInCorrective_type').should('contain.value', 'diferencias');
+        cy.dataCy('invoiceInCorrective_reason').should('contain.value', 'sales details');
     });
 }