From 3fafb15eb8cd0da28757a9d1a20a5518b021824e Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Tue, 10 Sep 2024 09:18:57 +0200
Subject: [PATCH] refactor: refs #4074 use fn

---
 src/pages/Item/Card/ItemSummary.vue            | 18 ++++++++----------
 .../cypress/integration/outLogin/login.spec.js |  2 +-
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/pages/Item/Card/ItemSummary.vue b/src/pages/Item/Card/ItemSummary.vue
index 081eb2afb..7b6015c30 100644
--- a/src/pages/Item/Card/ItemSummary.vue
+++ b/src/pages/Item/Card/ItemSummary.vue
@@ -20,6 +20,7 @@ const route = useRoute();
 const { t } = useI18n();
 
 const entityId = computed(() => $props.id || route.params.id);
+const getUrl = (id, param) => `#/Item/${id}/${param}`;
 </script>
 <template>
     <CardSummary
@@ -53,7 +54,7 @@ const entityId = computed(() => $props.id || route.params.id);
             </QCard>
             <QCard class="vn-one">
                 <VnTitle
-                    :url="`#/item/${entityId}/basic-data`"
+                    :url="getUrl(entityId, 'basic-data')"
                     :text="t('item.summary.basicData')"
                 />
                 <VnLv :label="t('item.summary.name')" :value="item.name" />
@@ -87,7 +88,7 @@ const entityId = computed(() => $props.id || route.params.id);
             </QCard>
             <QCard class="vn-one">
                 <VnTitle
-                    :url="`#/item/${entityId}/basic-data`"
+                    :url="getUrl(entityId, 'basic-data')"
                     :text="t('item.summary.otherData')"
                 />
                 <VnLv
@@ -114,10 +115,7 @@ const entityId = computed(() => $props.id || route.params.id);
                 />
             </QCard>
             <QCard class="vn-one">
-                <VnTitle
-                    :url="`#/item/${entityId}/tags`"
-                    :text="t('item.summary.tags')"
-                />
+                <VnTitle :url="getUrl(entityId, 'tags')" :text="t('item.summary.tags')" />
                 <VnLv
                     v-for="(tag, index) in tags"
                     :key="index"
@@ -127,13 +125,13 @@ const entityId = computed(() => $props.id || route.params.id);
             </QCard>
             <QCard class="vn-one" v-if="item.description">
                 <VnTitle
-                    :url="`#/item/${entityId}/basic-data`"
+                    :url="getUrl(entityId, 'basic-data')"
                     :text="t('item.summary.description')"
                 />
                 <p v-text="item.description" />
             </QCard>
             <QCard class="vn-one">
-                <VnTitle :url="`#/item/${entityId}/tax`" :text="t('item.summary.tax')" />
+                <VnTitle :url="getUrl(entityId, 'tax')" :text="t('item.summary.tax')" />
                 <VnLv
                     v-for="(tax, index) in item.taxes"
                     :key="index"
@@ -143,7 +141,7 @@ const entityId = computed(() => $props.id || route.params.id);
             </QCard>
             <QCard class="vn-one">
                 <VnTitle
-                    :url="`#/item/${entityId}/botanical`"
+                    :url="getUrl(entityId, 'botanical')"
                     :text="t('item.summary.botanical')"
                 />
                 <VnLv :label="t('item.summary.genus')" :value="botanical?.genus?.name" />
@@ -154,7 +152,7 @@ const entityId = computed(() => $props.id || route.params.id);
             </QCard>
             <QCard class="vn-one">
                 <VnTitle
-                    :url="`#/item/${entityId}/barcode`"
+                    :url="getUrl(entityId, 'barcode')"
                     :text="t('item.summary.barcode')"
                 />
                 <p
diff --git a/test/cypress/integration/outLogin/login.spec.js b/test/cypress/integration/outLogin/login.spec.js
index 6757ba7d0..3db223cdb 100755
--- a/test/cypress/integration/outLogin/login.spec.js
+++ b/test/cypress/integration/outLogin/login.spec.js
@@ -52,7 +52,7 @@ describe('Login', () => {
         cy.url().should('contain', '/login');
     });
 
-    it(`should get redirected to dashboard since employee can't create tickets`, () => {
+    it(`should be redirected to dashboard since the employee is not enabled to see ldap`, () => {
         cy.visit('/#/account/ldap', { failOnStatusCode: false });
         cy.url().should('contain', '/#/login?redirect=/account/ldap');
         cy.get('input[aria-label="Username"]').type('employee');