From 413d567ffb136e851b400bc88e5177227a81ca7c Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Mon, 13 Jan 2025 08:34:32 +0100
Subject: [PATCH] refactor: refs #8225 requested changes

---
 src/pages/Account/Card/AccountDescriptor.vue    |  1 -
 .../Account/Card/AccountDescriptorMenu.vue      |  3 ++-
 .../InvoiceIn/Card/InvoiceInDescriptor.vue      |  8 ++++----
 .../InvoiceIn/Card/InvoiceInDescriptorMenu.vue  | 17 ++++++++++++++---
 src/pages/InvoiceIn/locale/en.yml               |  7 ++-----
 src/pages/InvoiceIn/locale/es.yml               |  7 ++-----
 .../invoiceIn/invoiceInCorrective.spec.js       |  4 ++--
 7 files changed, 26 insertions(+), 21 deletions(-)

diff --git a/src/pages/Account/Card/AccountDescriptor.vue b/src/pages/Account/Card/AccountDescriptor.vue
index e96b4e0c5..4e5328de6 100644
--- a/src/pages/Account/Card/AccountDescriptor.vue
+++ b/src/pages/Account/Card/AccountDescriptor.vue
@@ -52,7 +52,6 @@ onMounted(async () => {
             <AccountDescriptorMenu :entity-id="entityId" />
         </template>
         <template #before>
-            <!-- falla id :id="entityId.value" collection="user" size="160x160" -->
             <VnImg :id="entityId" collection="user" resolution="520x520" class="photo">
                 <template #error>
                     <div
diff --git a/src/pages/Account/Card/AccountDescriptorMenu.vue b/src/pages/Account/Card/AccountDescriptorMenu.vue
index a71fbe931..aa49dabe8 100644
--- a/src/pages/Account/Card/AccountDescriptorMenu.vue
+++ b/src/pages/Account/Card/AccountDescriptorMenu.vue
@@ -9,6 +9,7 @@ import VnConfirm from 'src/components/ui/VnConfirm.vue';
 import VnChangePassword from 'src/components/common/VnChangePassword.vue';
 import useNotify from 'src/composables/useNotify.js';
 import useHasAccount from 'src/composables/useHasAccount.js';
+import VnInputPassword from 'src/components/common/VnInputPassword.vue';
 
 const $props = defineProps({
     entityId: {
@@ -97,7 +98,7 @@ async function sync() {
                     <QTooltip>{{ t('account.card.actions.sync.tooltip') }}</QTooltip>
                 </QIcon></QCheckbox
             >
-            <QInput
+            <VnInputPassword
                 v-if="shouldSyncPassword"
                 :label="t('login.password')"
                 v-model="syncPassword"
diff --git a/src/pages/InvoiceIn/Card/InvoiceInDescriptor.vue b/src/pages/InvoiceIn/Card/InvoiceInDescriptor.vue
index 89b1f9e7e..9ba0df395 100644
--- a/src/pages/InvoiceIn/Card/InvoiceInDescriptor.vue
+++ b/src/pages/InvoiceIn/Card/InvoiceInDescriptor.vue
@@ -22,7 +22,7 @@ const entityId = computed(() => $props.id || +currentRoute.value.params.id);
 const totalAmount = ref();
 const config = ref();
 const cplusRectificationTypes = ref([]);
-const siiTypeInvoiceOuts = ref([]);
+const siiTypeInvoiceIns = ref([]);
 const invoiceCorrectionTypes = ref([]);
 
 const filter = {
@@ -144,9 +144,9 @@ const createInvoiceInCorrection = async () => {
         auto-load
     />
     <FetchData
-        url="SiiTypeInvoiceOuts"
+        url="SiiTypeInvoiceIns"
         :where="{ code: { like: 'R%' } }"
-        @on-fetch="(data) => (siiTypeInvoiceOuts = data)"
+        @on-fetch="(data) => (siiTypeInvoiceIns = data)"
         auto-load
     />
     <FetchData
@@ -248,7 +248,7 @@ const createInvoiceInCorrection = async () => {
                         <VnSelect
                             :label="`${useCapitalize(t('globals.class'))}`"
                             v-model="correctionFormData.invoiceClass"
-                            :options="siiTypeInvoiceOuts"
+                            :options="siiTypeInvoiceIns"
                             option-value="id"
                             option-label="code"
                             :required="true"
diff --git a/src/pages/InvoiceIn/Card/InvoiceInDescriptorMenu.vue b/src/pages/InvoiceIn/Card/InvoiceInDescriptorMenu.vue
index 8c715c795..3b7de7308 100644
--- a/src/pages/InvoiceIn/Card/InvoiceInDescriptorMenu.vue
+++ b/src/pages/InvoiceIn/Card/InvoiceInDescriptorMenu.vue
@@ -73,8 +73,8 @@ async function toUnbook() {
 
     const type = isLinked ? 'warning' : 'positive';
     const message = isLinked
-        ? t('InvoiceIn.descriptorMenu.isLinked', { bookEntry, accountingEntries })
-        : t('InvoiceIn.descriptorMenu.isNotLinked', { bookEntry });
+        ? t('isLinked', { bookEntry })
+        : t('isNotLinked', { bookEntry, accountingEntries });
 
     quasar.notify({ type, message });
     if (!isLinked) arrayData.store.data.isBooked = false;
@@ -186,10 +186,21 @@ function sendPdfInvoice({ address }) {
         @click="triggerMenu('correct')"
     >
         <QItemSection
-            >{{ t('InvoiceIn.descriptorMenu.createRectificative') }}...</QItemSection
+            >{{ t('InvoiceIn.descriptorMenu.createCorrective') }}...</QItemSection
         >
     </QItem>
     <QItem v-if="invoice.dmsFk" v-ripple clickable @click="downloadFile(invoice.dmsFk)">
         <QItemSection>{{ t('components.smartCard.downloadFile') }}</QItemSection>
     </QItem>
 </template>
+
+<i18n>
+en:
+    isNotLinked: The entry {bookEntry} has been deleted with {accountingEntries} entries		
+    isLinked: The entry has been linked to Sage. Please contact administration for further information		
+    assertAction: Are you sure you want to {action} this invoice?
+es:
+    isNotLinked: Se ha eliminado el asiento nº {bookEntry} con {accountingEntries} apuntes		
+    isLinked: El asiento fue enlazado a Sage, por favor contacta con administración		
+    assertAction: Estas seguro de querer {action} esta factura?
+</i18n>
diff --git a/src/pages/InvoiceIn/locale/en.yml b/src/pages/InvoiceIn/locale/en.yml
index 1ac9c46e9..2d1458290 100644
--- a/src/pages/InvoiceIn/locale/en.yml
+++ b/src/pages/InvoiceIn/locale/en.yml
@@ -27,13 +27,10 @@ InvoiceIn:
         sendAgriculturalPdf: Send agricultural receipt as PDF
         checkSendInvoice: Are you sure you want to send it?
         sendPdfInvoice: Send PDF invoice
-        createRectificative: Create rectificative invoice
-        rectificativeInvoice: Rectificative invoice
+        createCorrective: Create rectificative invoice
+        correctiveInvoice: Rectificative invoice
         originalInvoice: Original invoice
         entry: Entry
-        isNotLinked: The entry {bookEntry} has been deleted with {accountingEntries} entries
-        isLinked: The entry {bookEntry} has been linked to Sage. Please contact administration for further information
-        assertAction: Are you sure you want to {action} this invoice?
         emailEmpty: The email can't be empty
     card:
         client: Client
diff --git a/src/pages/InvoiceIn/locale/es.yml b/src/pages/InvoiceIn/locale/es.yml
index 9ffe09aa5..e6b323a73 100644
--- a/src/pages/InvoiceIn/locale/es.yml
+++ b/src/pages/InvoiceIn/locale/es.yml
@@ -27,13 +27,10 @@ InvoiceIn:
         sendAgriculturalPdf: Enviar recibo agrícola como PDF
         checkSendInvoice: ¿Estás seguro que quieres enviarlo?
         sendPdfInvoice: Enviar factura a PDF
-        createRectificative: Crear factura rectificativa
-        rectificativeInvoice: Factura rectificativa
+        createCorrective: Crear factura rectificativa
+        correctiveInvoice: Factura rectificativa
         originalInvoice: Factura origen
         entry: Entrada
-        isNotLinked: Se ha eliminado el asiento nº {bookEntry} con {accountingEntries} apuntes
-        isLinked: El asiento {bookEntry} fue enlazado a Sage, por favor contacta con administración
-        assertAction: Estas seguro de querer {action} esta factura?
         emailEmpty: El email no puede estar vacío
     card:
         client: Cliente
diff --git a/test/cypress/integration/invoiceIn/invoiceInCorrective.spec.js b/test/cypress/integration/invoiceIn/invoiceInCorrective.spec.js
index a64f98c10..0eb873355 100644
--- a/test/cypress/integration/invoiceIn/invoiceInCorrective.spec.js
+++ b/test/cypress/integration/invoiceIn/invoiceInCorrective.spec.js
@@ -1,7 +1,7 @@
 /// <reference types="cypress" />
 
 describe('InvoiceInCorrective', () => {
-    const createRectificative = '.q-menu > .q-list > :nth-child(6) > .q-item__section';
+    const createCorrective = '.q-menu > .q-list > :nth-child(6) > .q-item__section';
     const rectificativeSection = '.q-drawer-container .q-list > a:nth-child(6)';
     const saveDialog = '.q-card > .q-card__actions > .q-btn--standard ';
 
@@ -13,7 +13,7 @@ describe('InvoiceInCorrective', () => {
 
         cy.openActionsDescriptor();
 
-        cy.get(createRectificative).click();
+        cy.get(createCorrective).click();
         cy.get(saveDialog).click();
         cy.wait('@corrective').then((interception) => {
             const correctingId = interception.response.body;