From 42462757597f7b86be94a5145140339b33be2038 Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Fri, 31 Jan 2025 07:56:40 +0100
Subject: [PATCH] refactor: request changes

---
 src/components/common/VnSelectWorker.vue      |  1 +
 src/pages/Item/ItemTypeList.vue               |  6 +-----
 .../integration/item/itemBarcodes.spec.js     |  2 +-
 .../cypress/integration/item/itemType.spec.js | 21 ++++++++++++-------
 4 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/src/components/common/VnSelectWorker.vue b/src/components/common/VnSelectWorker.vue
index 8d60eb014..961804be1 100644
--- a/src/components/common/VnSelectWorker.vue
+++ b/src/components/common/VnSelectWorker.vue
@@ -53,6 +53,7 @@ const url = computed(() => {
         :fields="['id', 'name', 'nickname', 'code']"
         :filter-options="['id', 'name', 'nickname', 'code']"
         sort-by="nickname ASC"
+        data-cy="vnWorkerSelect"
     >
         <template #prepend v-if="$props.hasAvatar">
             <VnAvatar :worker-id="value" color="primary" v-bind="$attrs" />
diff --git a/src/pages/Item/ItemTypeList.vue b/src/pages/Item/ItemTypeList.vue
index 7173d993f..d4030e1d8 100644
--- a/src/pages/Item/ItemTypeList.vue
+++ b/src/pages/Item/ItemTypeList.vue
@@ -185,13 +185,11 @@ const columns = computed(() => [
                         :label="t('globals.name')"
                         data-cy="nameInput"
                     />
-                    <VnSelectWorker v-model="data.workerFk" data-cy="workerSelect" />
+                    <VnSelectWorker v-model="data.workerFk" />
                     <VnSelect
                         :label="t('ItemCategory')"
                         v-model="data.categoryFk"
                         :options="itemCategoriesOptions"
-                        option-value="id"
-                        option-label="name"
                         hide-selected
                         data-cy="itemCategorySelect"
                     />
@@ -199,8 +197,6 @@ const columns = computed(() => [
                         :label="t('Temperature')"
                         v-model="data.temperatureFk"
                         :options="temperatureOptions"
-                        option-value="id"
-                        option-label="name"
                         hide-selected
                         data-cy="temperatureSelect"
                     />
diff --git a/test/cypress/integration/item/itemBarcodes.spec.js b/test/cypress/integration/item/itemBarcodes.spec.js
index 4d17fa260..844768d9e 100644
--- a/test/cypress/integration/item/itemBarcodes.spec.js
+++ b/test/cypress/integration/item/itemBarcodes.spec.js
@@ -1,5 +1,5 @@
 /// <reference types="cypress" />
-describe('Item shelving', () => {
+describe('ItemBarcodes', () => {
     beforeEach(() => {
         cy.viewport(1920, 1080);
         cy.login('developer');
diff --git a/test/cypress/integration/item/itemType.spec.js b/test/cypress/integration/item/itemType.spec.js
index 85e054e28..466a49708 100644
--- a/test/cypress/integration/item/itemType.spec.js
+++ b/test/cypress/integration/item/itemType.spec.js
@@ -1,5 +1,10 @@
 /// <reference types="cypress" />
 describe('Item type', () => {
+    const workerError = 'employeeNick';
+    const worker = 'buyerNick';
+    const category = 'Artificial';
+    const type = 'Flower';
+
     beforeEach(() => {
         cy.viewport(1920, 1080);
         cy.login('developer');
@@ -10,10 +15,10 @@ describe('Item type', () => {
         cy.dataCy('vnTableCreateBtn').click();
         cy.dataCy('codeInput').type('ALS');
         cy.dataCy('nameInput').type('Alstroemeria');
-        cy.dataCy('workerSelect').type('employeeNick');
-        cy.get('.q-menu .q-item').contains('employeeNick').click();
-        cy.dataCy('itemCategorySelect').type('Artificial');
-        cy.get('.q-menu .q-item').contains('Artificial').click();
+        cy.dataCy('vnWorkerSelect').type(workerError);
+        cy.get('.q-menu .q-item').contains(workerError).click();
+        cy.dataCy('itemCategorySelect').type(category);
+        cy.get('.q-menu .q-item').contains(category).click();
         cy.dataCy('FormModelPopup_save').click();
         cy.checkNotification('An item type with the same code already exists');
     });
@@ -22,10 +27,10 @@ describe('Item type', () => {
         cy.dataCy('vnTableCreateBtn').click();
         cy.dataCy('codeInput').type('LIL');
         cy.dataCy('nameInput').type('Lilium');
-        cy.dataCy('workerSelect').type('buyerNick');
-        cy.get('.q-menu .q-item').contains('buyerNick').click();
-        cy.dataCy('itemCategorySelect').type('Flower');
-        cy.get('.q-menu .q-item').contains('Flower').click();
+        cy.dataCy('vnWorkerSelect').type(worker);
+        cy.get('.q-menu .q-item').contains(worker).click();
+        cy.dataCy('itemCategorySelect').type(type);
+        cy.get('.q-menu .q-item').contains(type).click();
         cy.dataCy('FormModelPopup_save').click();
         cy.checkNotification('Data created');
     });