From 433823c2acc246b7fdf0eea26545dbe8eecbf48c Mon Sep 17 00:00:00 2001
From: wbuezas <wbuezas@verdnatura.es>
Date: Fri, 15 Dec 2023 10:23:57 -0300
Subject: [PATCH] Invoice out negative bases refactor

---
 src/components/ui/VnFilterPanel.vue           |  30 ++-
 src/composables/useArrayData.js               |   5 +-
 .../InvoiceOut/InvoiceOutNegativeBases.vue    | 201 +++++-------------
 .../InvoiceOutNegativeBasesFilter.vue         | 134 ++++++++++++
 src/pages/Travel/TravelFilter.vue             |  28 +--
 src/pages/Travel/TravelList.vue               |   2 +-
 src/services/invoiceOut.service.js            |   4 -
 7 files changed, 230 insertions(+), 174 deletions(-)
 create mode 100644 src/pages/InvoiceOut/InvoiceOutNegativeBasesFilter.vue

diff --git a/src/components/ui/VnFilterPanel.vue b/src/components/ui/VnFilterPanel.vue
index 9cd5a052f..84893b667 100644
--- a/src/components/ui/VnFilterPanel.vue
+++ b/src/components/ui/VnFilterPanel.vue
@@ -24,6 +24,13 @@ const props = defineProps({
         type: Boolean,
         default: true,
     },
+    unremovableParams: {
+        type: Array,
+        required: false,
+        default: () => [],
+        description:
+            'Algunos filtros vienen con parametros de búsqueda por default y necesitan tener si o si un valor, por eso de ser necesario, esta prop nos sirve para saber que filtros podemos remover y cuales no',
+    },
 });
 
 const emit = defineEmits(['refresh', 'clear', 'search']);
@@ -63,12 +70,25 @@ async function reload() {
 }
 
 async function clearFilters() {
-    userParams.value = {};
     isLoading.value = true;
-    await arrayData.applyFilter({ params: {} });
-    if (!props.showAll) store.data = [];
-    isLoading.value = false;
 
+    // Filtrar los params no removibles
+    const removableFilters = Object.keys(userParams.value).filter((param) =>
+        props.unremovableParams.includes(param)
+    );
+    const newParams = {};
+    // Conservar solo los params que no son removibles
+    for (const key of removableFilters) {
+        newParams[key] = userParams.value[key];
+    }
+    userParams.value = { ...newParams }; // Actualizar los params con los removibles
+    await arrayData.applyFilter({ params: userParams.value });
+
+    if (!props.showAll) {
+        store.data = [];
+    }
+
+    isLoading.value = false;
     emit('clear');
 }
 
@@ -156,7 +176,7 @@ function formatValue(value) {
                         class="text-dark"
                         color="primary"
                         icon="label"
-                        removable
+                        :removable="!unremovableParams.includes(chip.label)"
                         size="sm"
                         v-for="chip of tags"
                     >
diff --git a/src/composables/useArrayData.js b/src/composables/useArrayData.js
index 523340cc9..5e80949f3 100644
--- a/src/composables/useArrayData.js
+++ b/src/composables/useArrayData.js
@@ -132,6 +132,7 @@ export function useArrayData(key, userOptions) {
 
     async function applyFilter({ filter, params }) {
         if (filter) store.userFilter = filter;
+        store.filter = {};
         if (params) store.userParams = Object.assign({}, params);
 
         await fetch({ append: false });
@@ -155,7 +156,9 @@ export function useArrayData(key, userOptions) {
                 delete store.userParams[param];
                 delete params[param];
                 if (store.filter?.where) {
-                    delete store.filter.where[Object.keys(exprBuilder ? exprBuilder(param) : param)[0]];
+                    delete store.filter.where[
+                        Object.keys(exprBuilder ? exprBuilder(param) : param)[0]
+                    ];
                     if (Object.keys(store.filter.where).length === 0) {
                         delete store.filter.where;
                     }
diff --git a/src/pages/InvoiceOut/InvoiceOutNegativeBases.vue b/src/pages/InvoiceOut/InvoiceOutNegativeBases.vue
index 7265a0b08..d0e45724e 100644
--- a/src/pages/InvoiceOut/InvoiceOutNegativeBases.vue
+++ b/src/pages/InvoiceOut/InvoiceOutNegativeBases.vue
@@ -1,44 +1,54 @@
 <script setup>
-import { onMounted, ref, reactive } from 'vue';
+import { ref, computed, onBeforeMount } from 'vue';
 import { useI18n } from 'vue-i18n';
 import { QCheckbox, QBtn } from 'quasar';
 
 import CustomerDescriptorProxy from 'src/pages/Customer/Card/CustomerDescriptorProxy.vue';
 import WorkerDescriptorProxy from 'src/pages/Worker/Card/WorkerDescriptorProxy.vue';
-import VnInput from 'src/components/common/VnInput.vue';
+import InvoiceOutNegativeFilter from './InvoiceOutNegativeBasesFilter.vue';
 
-import invoiceOutService from 'src/services/invoiceOut.service';
 import { toCurrency } from 'src/filters';
 import { useInvoiceOutGlobalStore } from 'src/stores/invoiceOutGlobal.js';
-import VnInputDate from 'components/common/VnInputDate.vue';
+import { useStateStore } from 'stores/useStateStore';
+import { useArrayData } from 'composables/useArrayData';
 
 const invoiceOutGlobalStore = useInvoiceOutGlobalStore();
-
-const rows = ref([]);
+const stateStore = useStateStore();
 const { t } = useI18n();
 
-const dateRange = reactive({
-    from: Date.vnFirstDayOfMonth().toISOString(),
-    to: Date.vnLastDayOfMonth().toISOString(),
+const arrayData = ref(null);
+
+function exprBuilder(param, value) {
+    switch (param) {
+        case 'from':
+        case 'to':
+            return;
+        default:
+            return { [param]: value };
+    }
+}
+
+onBeforeMount(async () => {
+    const defaultParams = {
+        from: Date.vnFirstDayOfMonth().toISOString(),
+        to: Date.vnLastDayOfMonth().toISOString(),
+    };
+    arrayData.value = useArrayData('InvoiceOutNegative', {
+        url: 'InvoiceOuts/negativeBases',
+        limit: 0,
+        userParams: defaultParams,
+        exprBuilder: exprBuilder,
+    });
+    await arrayData.value.fetch({ append: false });
+
+    stateStore.rightDrawer = true;
 });
 
+const rows = computed(() => arrayData.value.store.data);
+
 const selectedCustomerId = ref(0);
 const selectedWorkerId = ref(0);
 
-const filter = ref({
-    company: null,
-    country: null,
-    clientId: null,
-    client: null,
-    amount: null,
-    base: null,
-    ticketId: null,
-    active: null,
-    hasToInvoice: null,
-    verifiedData: null,
-    comercial: null,
-});
-
 const tableColumnComponents = {
     company: {
         component: 'span',
@@ -177,52 +187,10 @@ const columns = ref([
 ]);
 
 const downloadCSV = async () => {
-    await invoiceOutGlobalStore.getNegativeBasesCsv(dateRange.from, dateRange.to);
-};
-
-const search = async () => {
-    const and = [];
-    Object.keys(filter.value).forEach((key) => {
-        if (filter.value[key]) {
-            and.push({
-                [key]: filter.value[key],
-            });
-        }
-    });
-    const searchFilter = {
-        limit: 20,
-    };
-
-    if (and.length) {
-        searchFilter.where = {
-            and,
-        };
-    }
-
-    const params = {
-        ...dateRange,
-        filter: JSON.stringify(searchFilter),
-    };
-    rows.value = await invoiceOutService.getNegativeBases(params);
-};
-
-const refresh = () => {
-    dateRange.from = Date.vnFirstDayOfMonth().toISOString();
-    dateRange.to = Date.vnLastDayOfMonth().toISOString();
-    filter.value = {
-        company: null,
-        country: null,
-        clientId: null,
-        client: null,
-        amount: null,
-        base: null,
-        ticketId: null,
-        active: null,
-        hasToInvoice: null,
-        verifiedData: null,
-        comercial: null,
-    };
-    search();
+    await invoiceOutGlobalStore.getNegativeBasesCsv(
+        arrayData.value.store.userParams.from,
+        arrayData.value.store.userParams.to
+    );
 };
 
 const selectCustomerId = (id) => {
@@ -232,82 +200,33 @@ const selectCustomerId = (id) => {
 const selectWorkerId = (id) => {
     selectedWorkerId.value = id;
 };
-
-onMounted(async () => {
-    refresh();
-});
 </script>
 
 <template>
+    <template v-if="stateStore.isHeaderMounted()">
+        <Teleport to="#st-actions" v-if="stateStore?.isSubToolbarShown()">
+            <QBtn color="primary" icon-right="archive" no-caps @click="downloadCSV()" />
+        </Teleport>
+    </template>
+    <QDrawer v-model="stateStore.rightDrawer" side="right" :width="256" show-if-above>
+        <QScrollArea class="fit text-grey-8">
+            <InvoiceOutNegativeFilter data-key="InvoiceOutNegative" />
+        </QScrollArea>
+    </QDrawer>
+    <QToolbar class="bg-vn-dark">
+        <div id="st-data"></div>
+        <QSpace />
+        <div id="st-actions"></div>
+    </QToolbar>
     <QPage class="column items-center q-pa-md">
         <QTable
-            :rows="rows"
             :columns="columns"
+            :rows="rows"
             hide-bottom
             row-key="clientId"
             :pagination="{ rowsPerPage: 0 }"
             class="full-width q-mt-md"
         >
-            <template #top-left>
-                <div class="row justify-start items-end">
-                    <VnInputDate
-                        v-model="dateRange.from"
-                        :label="t('invoiceOut.negativeBases.from')"
-                        class="q-mr-md"
-                        lazy-rules
-                        is-outlined
-                    />
-                    <VnInputDate
-                        v-model="dateRange.to"
-                        :label="t('invoiceOut.negativeBases.to')"
-                        class="q-mr-md"
-                        lazy-rules
-                        is-outlined
-                    />
-                    <QBtn
-                        color="primary"
-                        icon-right="archive"
-                        no-caps
-                        @click="downloadCSV()"
-                    />
-                </div>
-            </template>
-            <template #top-right>
-                <div class="row justify-start items-center">
-                    <span class="q-mr-md text-results">
-                        {{ rows.length }} {{ t('results') }}
-                    </span>
-                    <QBtn
-                        color="primary"
-                        icon-right="search"
-                        no-caps
-                        class="q-mr-sm"
-                        @click="search()"
-                    />
-                    <QBtn color="primary" icon-right="refresh" no-caps @click="refresh" />
-                </div>
-            </template>
-            <template #header="props">
-                <QTr :props="props" class="full-height">
-                    <QTh v-for="col in props.cols" :key="col.name" :props="props">
-                        <div class="column justify-start items-start full-height">
-                            {{ t(`invoiceOut.negativeBases.${col.label}`) }}
-                            <VnInput
-                                :class="{
-                                    invisible:
-                                        col.field === 'isActive' ||
-                                        col.field === 'hasToInvoice' ||
-                                        col.field === 'isTaxDataChecked',
-                                }"
-                                v-model="filter[col.field]"
-                                type="text"
-                                @keyup.enter="search()"
-                                is-outlined
-                            />
-                        </div>
-                    </QTh>
-                </QTr>
-            </template>
             <template #body-cell="props">
                 <QTd :props="props">
                     <component
@@ -324,14 +243,8 @@ onMounted(async () => {
                             "
                             >{{ props.value }}
                         </template>
-                        <CustomerDescriptorProxy
-                            v-if="props.col.name === 'clientId'"
-                            :id="selectedCustomerId"
-                        />
-                        <WorkerDescriptorProxy
-                            v-if="props.col.name === 'comercial'"
-                            :id="selectedWorkerId"
-                        />
+                        <CustomerDescriptorProxy :id="selectedCustomerId" />
+                        <WorkerDescriptorProxy :id="selectedWorkerId" />
                     </component>
                 </QTd>
             </template>
@@ -344,10 +257,6 @@ onMounted(async () => {
     border-radius: 4px;
     padding: 6px 6px 6px 6px;
 }
-
-.text-results {
-    color: var(--vn-label);
-}
 </style>
 
 <i18n></i18n>
diff --git a/src/pages/InvoiceOut/InvoiceOutNegativeBasesFilter.vue b/src/pages/InvoiceOut/InvoiceOutNegativeBasesFilter.vue
new file mode 100644
index 000000000..028246aeb
--- /dev/null
+++ b/src/pages/InvoiceOut/InvoiceOutNegativeBasesFilter.vue
@@ -0,0 +1,134 @@
+<script setup>
+import { useI18n } from 'vue-i18n';
+
+import VnFilterPanel from 'src/components/ui/VnFilterPanel.vue';
+import VnInput from 'src/components/common/VnInput.vue';
+import VnInputDate from 'components/common/VnInputDate.vue';
+
+const { t } = useI18n();
+const props = defineProps({
+    dataKey: {
+        type: String,
+        required: true,
+    },
+});
+</script>
+
+<template>
+    <VnFilterPanel
+        :data-key="props.dataKey"
+        :search-button="true"
+        :unremovable-params="['from', 'to']"
+    >
+        <template #tags="{ tag, formatFn }">
+            <div class="q-gutter-x-xs">
+                <strong>{{ t(`params.${tag.label}`) }}: </strong>
+                <span>{{ formatFn(tag.value) }}</span>
+            </div>
+        </template>
+        <template #body="{ params }">
+            <QList dense class="q-gutter-y-sm q-mt-sm">
+                <QItem>
+                    <QItemSection>
+                        <VnInputDate
+                            v-model="params.from"
+                            :label="t('invoiceOut.negativeBases.from')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+                <QItem>
+                    <QItemSection>
+                        <VnInputDate
+                            v-model="params.to"
+                            :label="t('invoiceOut.negativeBases.to')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+                <QItem>
+                    <QItemSection>
+                        <VnInput
+                            v-model="params.company"
+                            :label="t('invoiceOut.negativeBases.company')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+                <QItem>
+                    <QItemSection>
+                        <VnInput
+                            v-model="params.country"
+                            :label="t('invoiceOut.negativeBases.country')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+
+                <QItem>
+                    <QItemSection>
+                        <VnInput
+                            v-model="params.clientId"
+                            :label="t('invoiceOut.negativeBases.clientId')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+                <QItem>
+                    <QItemSection>
+                        <VnInput
+                            v-model="params.clientSocialName"
+                            :label="t('invoiceOut.negativeBases.client')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+                <QItem>
+                    <QItemSection>
+                        <VnInput
+                            v-model="params.amount"
+                            :label="t('invoiceOut.negativeBases.amount')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+                <QItem>
+                    <QItemSection>
+                        <VnInput
+                            v-model="params.comercialName"
+                            :label="t('invoiceOut.negativeBases.comercial')"
+                            is-outlined
+                        />
+                    </QItemSection>
+                </QItem>
+            </QList>
+        </template>
+    </VnFilterPanel>
+</template>
+
+<style scoped></style>
+
+<i18n>
+en:
+    params:
+        from: From
+        to: To
+        company: Company
+        country: Country
+        clientId: Client Id
+        clientSocialName: Client
+        amount: Amount
+        comercialName: Comercial
+es:
+    params:
+        from: Desde
+        to: Hasta
+        company: Empresa
+        country: País
+        clientId: Id cliente
+        clientSocialName: Cliente
+        amount: Importe
+        comercialName: Comercial
+    Date is required: La fecha es requerida
+
+</i18n>
diff --git a/src/pages/Travel/TravelFilter.vue b/src/pages/Travel/TravelFilter.vue
index d4cb286c2..52a755c34 100644
--- a/src/pages/Travel/TravelFilter.vue
+++ b/src/pages/Travel/TravelFilter.vue
@@ -1,5 +1,5 @@
 <script setup>
-import { reactive } from 'vue';
+import { ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 
 import VnFilterPanel from 'src/components/ui/VnFilterPanel.vue';
@@ -17,15 +17,9 @@ const props = defineProps({
     },
 });
 
-const filtersOptions = reactive({
-    warehouses: [],
-    continents: [],
-    agencies: [],
-});
-
-const updateFilterOptions = (data, optionKey) => {
-    filtersOptions[optionKey] = [...data];
-};
+const warehousesOptions = ref([]);
+const continentsOptions = ref([]);
+const agenciesOptions = ref([]);
 
 const add = (paramsObj, key) => {
     if (paramsObj[key] === undefined) {
@@ -45,17 +39,17 @@ const decrement = (paramsObj, key) => {
 <template>
     <FetchData
         url="Warehouses"
-        @on-fetch="(data) => updateFilterOptions(data, 'warehouses')"
+        @on-fetch="(data) => (warehousesOptions = data)"
         auto-load
     />
     <FetchData
         url="Continents"
-        @on-fetch="(data) => updateFilterOptions(data, 'continents')"
+        @on-fetch="(data) => (continentsOptions = data)"
         auto-load
     />
     <FetchData
         url="AgencyModes"
-        @on-fetch="(data) => updateFilterOptions(data, 'agencies')"
+        @on-fetch="(data) => (agenciesOptions = data)"
         auto-load
     />
 
@@ -82,7 +76,7 @@ const decrement = (paramsObj, key) => {
                         <VnSelectFilter
                             :label="t('params.agencyModeFk')"
                             v-model="params.agencyModeFk"
-                            :options="filtersOptions.agencies"
+                            :options="agenciesOptions"
                             option-value="agencyFk"
                             option-label="name"
                             hide-selected
@@ -97,7 +91,7 @@ const decrement = (paramsObj, key) => {
                         <VnSelectFilter
                             :label="t('params.warehouseOutFk')"
                             v-model="params.warehouseOutFk"
-                            :options="filtersOptions.warehouses"
+                            :options="warehousesOptions"
                             option-value="id"
                             option-label="name"
                             hide-selected
@@ -112,7 +106,7 @@ const decrement = (paramsObj, key) => {
                         <VnSelectFilter
                             :label="t('params.warehouseInFk')"
                             v-model="params.warehouseInFk"
-                            :options="filtersOptions.warehouses"
+                            :options="warehousesOptions"
                             option-value="id"
                             option-label="name"
                             hide-selected
@@ -223,7 +217,7 @@ const decrement = (paramsObj, key) => {
                         <VnSelectFilter
                             :label="t('params.continent')"
                             v-model="params.continent"
-                            :options="filtersOptions.continents"
+                            :options="continentsOptions"
                             option-value="code"
                             option-label="name"
                             hide-selected
diff --git a/src/pages/Travel/TravelList.vue b/src/pages/Travel/TravelList.vue
index d62485a4c..56d529a7b 100644
--- a/src/pages/Travel/TravelList.vue
+++ b/src/pages/Travel/TravelList.vue
@@ -8,9 +8,9 @@ import VnPaginate from 'src/components/ui/VnPaginate.vue';
 import CardList from 'src/components/ui/CardList.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
 import TravelSummaryDialog from './Card/TravelSummaryDialog.vue';
+import TravelFilter from './TravelFilter.vue';
 
 import { useStateStore } from 'stores/useStateStore';
-import TravelFilter from './TravelFilter.vue';
 import { toDate } from 'src/filters/index';
 
 const router = useRouter();
diff --git a/src/services/invoiceOut.service.js b/src/services/invoiceOut.service.js
index 6232f319d..17f710cb5 100644
--- a/src/services/invoiceOut.service.js
+++ b/src/services/invoiceOut.service.js
@@ -17,10 +17,6 @@ const request = async (method, url, params = {}) => {
 };
 
 const invoiceOutService = {
-    getNegativeBases: async (params) => {
-        return await request('GET', 'InvoiceOuts/negativeBases', params);
-    },
-
     getNegativeBasesCsv: async (params) => {
         return await request('GET', 'InvoiceOuts/negativeBasesCsv', params);
     },