From 443a2747ccf852d9d43f618c67e350ed1db010cd Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sun, 16 Feb 2025 23:46:05 +0100
Subject: [PATCH] style: remove proposal

---
 src/components/ui/VnFilterPanel.vue                 |  8 --------
 src/pages/Ticket/TicketFilter.vue                   | 11 -----------
 src/pages/Ticket/TicketList.vue                     |  5 +----
 test/cypress/integration/ticket/tickeFilter.spec.js |  2 --
 test/cypress/integration/ticket/ticketList.spec.js  | 10 +++++-----
 5 files changed, 6 insertions(+), 30 deletions(-)

diff --git a/src/components/ui/VnFilterPanel.vue b/src/components/ui/VnFilterPanel.vue
index da01d7174..5ebba5028 100644
--- a/src/components/ui/VnFilterPanel.vue
+++ b/src/components/ui/VnFilterPanel.vue
@@ -14,10 +14,6 @@ const $props = defineProps({
         type: Object,
         default: () => {},
     },
-    searchBarRef: {
-        type: Object,
-        default: () => {},
-    },
     dataKey: {
         type: String,
         required: true,
@@ -65,10 +61,6 @@ const $props = defineProps({
         type: Object,
         default: null,
     },
-    requiredParams: {
-        type: [Array, Object],
-        default: () => [],
-    },
     useSearchbar: {
         type: [Boolean, Function],
         default: false,
diff --git a/src/pages/Ticket/TicketFilter.vue b/src/pages/Ticket/TicketFilter.vue
index d4d56d20f..549618e55 100644
--- a/src/pages/Ticket/TicketFilter.vue
+++ b/src/pages/Ticket/TicketFilter.vue
@@ -17,10 +17,6 @@ const props = defineProps({
         type: String,
         required: true,
     },
-    searchBarRef: {
-        type: Object,
-        default: () => ({}),
-    },
 });
 
 const provinces = ref([]);
@@ -45,11 +41,6 @@ from.setDate(from.getDate() - 7);
 const to = Date.vnNew();
 to.setHours(23, 59, 0, 0);
 to.setDate(to.getDate() + 1);
-const userParams = computed(() => {
-    from.value = from.toISOString();
-    to.value = to.toISOString();
-    return { from, to };
-});
 function validateDateRange(params) {
     const hasFrom = 'from' in params;
     const hasTo = 'to' in params;
@@ -79,11 +70,9 @@ function validateDateRange(params) {
     <FetchData url="AgencyModes" @on-fetch="(data) => (agencies = data)" auto-load />
     <FetchData url="Warehouses" @on-fetch="(data) => (warehouses = data)" auto-load />
     <VnFilterPanel
-        :searchBarRef="$props.searchBarRef"
         :data-key="props.dataKey"
         :search-button="true"
         :use-searchbar="validateDateRange"
-        :requiredParams="{ ...userParams }"
     >
         <template #tags="{ tag, formatFn }">
             <div class="q-gutter-x-xs">
diff --git a/src/pages/Ticket/TicketList.vue b/src/pages/Ticket/TicketList.vue
index 03db94732..ad8865a57 100644
--- a/src/pages/Ticket/TicketList.vue
+++ b/src/pages/Ticket/TicketList.vue
@@ -491,10 +491,7 @@ watch(
         }"
     >
         <template #advanced-menu>
-            <TicketFilter
-                data-key="TicketList"
-                :searchbarRef="$refs.sectionRef?.$refs.searchbarRef"
-            />
+            <TicketFilter data-key="TicketList" />
         </template>
         <template #body>
             <VnTable
diff --git a/test/cypress/integration/ticket/tickeFilter.spec.js b/test/cypress/integration/ticket/tickeFilter.spec.js
index b2bf78743..408c5a19f 100644
--- a/test/cypress/integration/ticket/tickeFilter.spec.js
+++ b/test/cypress/integration/ticket/tickeFilter.spec.js
@@ -1,7 +1,5 @@
 /// <reference types="cypress" />
 describe('TicketFilter', () => {
-    const firstRow = 'tbody.q-virtual-scroll__content tr:nth-child(1)';
-
     beforeEach(() => {
         cy.login('developer');
         cy.viewport(1920, 1080);
diff --git a/test/cypress/integration/ticket/ticketList.spec.js b/test/cypress/integration/ticket/ticketList.spec.js
index 800ce6aaa..e6ddc2fa1 100644
--- a/test/cypress/integration/ticket/ticketList.spec.js
+++ b/test/cypress/integration/ticket/ticketList.spec.js
@@ -48,8 +48,8 @@ describe('TicketList', () => {
             expect(query).to.not.have.property('clientFk');
         });
         cy.intercept('GET', /\/api\/Tickets\/filter/).as('ticketFilter');
-        cy.get('[data-cy="Customer ID_input"]').clear('1');
-        cy.get('[data-cy="Customer ID_input"]').type('1101{enter}');
+        cy.dataCy('Customer ID_input').clear('1');
+        cy.dataCy('Customer ID_input').type('1101{enter}');
         cy.wait('@ticketFilter').then(({ request }) => {
             const { query } = request;
             expect(query).to.not.have.property('from');
@@ -57,11 +57,11 @@ describe('TicketList', () => {
             expect(query).to.have.property('clientFk');
         });
         cy.get('[data-cy="vnTableCreateBtn"] > .q-btn__content > .q-icon').click();
-        cy.get('[data-cy="Customer_select"]').should('have.value', 'Bruce Wayne');
-        cy.get('[data-cy="Address_select"]').click();
+        cy.dataCy('Customer_select').should('have.value', 'Bruce Wayne');
+        cy.dataCy('Address_select').click();
 
         cy.selectOptionBeta().click();
-        cy.get('[data-cy="Address_select"]').should('have.value', 'Bruce Wayne');
+        cy.dataCy('Address_select').should('have.value', 'Bruce Wayne');
     });
     it('Client list create new client', () => {
         cy.dataCy('vnTableCreateBtn').should('exist');