From 510eab8af0cc6bde56e17a19377cff86839a5c1e Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Fri, 11 Apr 2025 15:04:24 +0200
Subject: [PATCH] feat: fix minor bugs

---
 .../Ticket/Card/TicketDescriptorMenu.vue      |  1 +
 src/pages/Ticket/Card/TicketSale.vue          |  1 +
 src/pages/Ticket/Card/TicketSplit.vue         |  8 +-
 src/pages/Ticket/Card/TicketTransferProxy.vue |  4 +-
 .../Ticket/Negative/TicketLackDetail.vue      |  8 +-
 .../Negative/components/ChangeItemDialog.vue  |  1 +
 .../components/ChangeQuantityDialog.vue       |  1 +
 .../Negative/components/ChangeStateDialog.vue |  1 +
 .../Negative/composables/notifyResults.js     | 77 +++++++++++--------
 9 files changed, 65 insertions(+), 37 deletions(-)

diff --git a/src/pages/Ticket/Card/TicketDescriptorMenu.vue b/src/pages/Ticket/Card/TicketDescriptorMenu.vue
index f7389b592..30024fb26 100644
--- a/src/pages/Ticket/Card/TicketDescriptorMenu.vue
+++ b/src/pages/Ticket/Card/TicketDescriptorMenu.vue
@@ -28,6 +28,7 @@ const props = defineProps({
 
 onMounted(() => {
     restoreTicket();
+    hasDocuware();
 });
 
 watch(
diff --git a/src/pages/Ticket/Card/TicketSale.vue b/src/pages/Ticket/Card/TicketSale.vue
index a613f905a..3305c0d46 100644
--- a/src/pages/Ticket/Card/TicketSale.vue
+++ b/src/pages/Ticket/Card/TicketSale.vue
@@ -768,6 +768,7 @@ watch(
                 v-model="row.itemFk"
                 :use-like="false"
                 @update:model-value="changeItem(row)"
+                autofocus
             >
                 <template #option="scope">
                     <QItem v-bind="scope.itemProps">
diff --git a/src/pages/Ticket/Card/TicketSplit.vue b/src/pages/Ticket/Card/TicketSplit.vue
index e0d074760..462c22264 100644
--- a/src/pages/Ticket/Card/TicketSplit.vue
+++ b/src/pages/Ticket/Card/TicketSplit.vue
@@ -25,7 +25,13 @@ const splitSelectedRows = async () => {
 </script>
 
 <template>
-    <VnInputDate class="q-mr-sm" :label="$t('New date')" v-model="splitDate" clearable />
+    <VnInputDate
+        class="q-mr-sm"
+        :label="$t('New date')"
+        v-model="splitDate"
+        clearable
+        autofocus
+    />
     <QBtn class="q-mr-sm" color="primary" label="Split" @click="splitSelectedRows"></QBtn>
 </template>
 <style lang="scss">
diff --git a/src/pages/Ticket/Card/TicketTransferProxy.vue b/src/pages/Ticket/Card/TicketTransferProxy.vue
index 441bfcad4..af3b13990 100644
--- a/src/pages/Ticket/Card/TicketTransferProxy.vue
+++ b/src/pages/Ticket/Card/TicketTransferProxy.vue
@@ -1,7 +1,7 @@
 <script setup>
 import { ref } from 'vue';
 import TicketTransfer from './TicketTransfer.vue';
-import Split from './TicketSplit.vue';
+import TicketSplit from './TicketSplit.vue';
 const emit = defineEmits(['ticketTransferred']);
 
 const $props = defineProps({
@@ -35,7 +35,7 @@ const transferRef = ref(null);
 <template>
     <QPopupProxy ref="popupProxyRef" data-cy="ticketTransferPopup">
         <div class="flex row items-center q-ma-lg" v-if="$props.split">
-            <Split
+            <TicketSplit
                 ref="splitRef"
                 @splitSelectedRows="splitSelectedRows"
                 :ticket="$props.ticket"
diff --git a/src/pages/Ticket/Negative/TicketLackDetail.vue b/src/pages/Ticket/Negative/TicketLackDetail.vue
index a6997d26a..9fb0f48ac 100644
--- a/src/pages/Ticket/Negative/TicketLackDetail.vue
+++ b/src/pages/Ticket/Negative/TicketLackDetail.vue
@@ -124,7 +124,7 @@ const showItemProposal = () => {
                 <QBtn
                     color="primary"
                     @click="showItemProposal"
-                    :disable="selectedRows.length < 1"
+                    :disable="!(selectedRows.length === 1)"
                     data-cy="itemProposal"
                 >
                     <QIcon name="import_export" class="rotate-90" />
@@ -135,7 +135,7 @@ const showItemProposal = () => {
                 <VnPopupProxy
                     data-cy="changeItem"
                     icon="sync"
-                    :disable="selectedRows.length < 1"
+                    :disable="!(selectedRows.length === 1)"
                     :tooltip="t('negative.detail.modal.changeItem.title')"
                 >
                     <template #extraIcon> <QIcon name="vn:item" /> </template>
@@ -149,7 +149,7 @@ const showItemProposal = () => {
                 <VnPopupProxy
                     data-cy="changeState"
                     icon="sync"
-                    :disable="selectedRows.length < 1"
+                    :disable="!(selectedRows.length === 1)"
                     :tooltip="t('negative.detail.modal.changeState.title')"
                 >
                     <template #extraIcon> <QIcon name="vn:eye" /> </template>
@@ -163,7 +163,7 @@ const showItemProposal = () => {
                 <VnPopupProxy
                     data-cy="changeQuantity"
                     icon="sync"
-                    :disable="selectedRows.length < 1"
+                    :disable="!(selectedRows.length === 1)"
                     :tooltip="t('negative.detail.modal.changeQuantity.title')"
                     @click="showChangeQuantityDialog = true"
                 >
diff --git a/src/pages/Ticket/Negative/components/ChangeItemDialog.vue b/src/pages/Ticket/Negative/components/ChangeItemDialog.vue
index 6488fc038..e77bcb3bb 100644
--- a/src/pages/Ticket/Negative/components/ChangeItemDialog.vue
+++ b/src/pages/Ticket/Negative/components/ChangeItemDialog.vue
@@ -48,6 +48,7 @@ const updateItem = async () => {
                 option-label="name"
                 option-value="id"
                 v-model="newItem"
+                autofocus
             >
             </VnSelect>
         </QCardSection>
diff --git a/src/pages/Ticket/Negative/components/ChangeQuantityDialog.vue b/src/pages/Ticket/Negative/components/ChangeQuantityDialog.vue
index 8b6dc28e9..35cb2617e 100644
--- a/src/pages/Ticket/Negative/components/ChangeQuantityDialog.vue
+++ b/src/pages/Ticket/Negative/components/ChangeQuantityDialog.vue
@@ -44,6 +44,7 @@ const updateQuantity = async () => {
                 :min="0"
                 :label="$t('negative.detail.modal.changeQuantity.placeholder')"
                 v-model="newQuantity"
+                autofocus
             />
         </QCardSection>
         <QCardActions align="right">
diff --git a/src/pages/Ticket/Negative/components/ChangeStateDialog.vue b/src/pages/Ticket/Negative/components/ChangeStateDialog.vue
index b1492ca6d..273006dcb 100644
--- a/src/pages/Ticket/Negative/components/ChangeStateDialog.vue
+++ b/src/pages/Ticket/Negative/components/ChangeStateDialog.vue
@@ -50,6 +50,7 @@ const updateState = async () => {
                 :options="editableStates"
                 option-label="name"
                 option-value="code"
+                autofocus
             />
         </QCardSection>
         <QCardActions align="right">
diff --git a/src/pages/Ticket/Negative/composables/notifyResults.js b/src/pages/Ticket/Negative/composables/notifyResults.js
index 7e42b9a14..5f513cc04 100644
--- a/src/pages/Ticket/Negative/composables/notifyResults.js
+++ b/src/pages/Ticket/Negative/composables/notifyResults.js
@@ -4,36 +4,53 @@ import { useI18n } from 'vue-i18n';
 
 export function displayResults() {
     const { t } = useI18n();
-    const notifyResults = (results, key, path = 'sale') =>
-        results.forEach((result, index) => {
-            if (result.status === 'fulfilled') {
-                const data = JSON.parse(result.value.config.data);
-                if (result.value.data.status === 'noSplit') {
-                    Notify.create({
-                        type: 'warning',
-                        message: `Ticket ${data[key]}: ${t('negative.split.noSplit')}`,
-                    });
-                } else
-                    Notify.create({
-                        type: 'positive',
-                        message: t('globals.dataSaved'),
-                        actions: [
-                            {
-                                label: t('globals.openDetail'),
-                                color: 'white',
-                                handler: () => {
-                                    useOpenURL(`#/ticket/${data[key]}/${path}`);
-                                },
-                            },
-                        ],
-                    });
-            } else {
-                const data = JSON.parse(result.reason.config.data);
-                Notify.create({
-                    type: 'negative',
-                    message: `Ticket ${data[key]}: ${result.reason.response?.data?.error?.message ?? result.reason.message}`,
-                });
-            }
+
+    const createSuccessNotification = (id, path) => {
+        Notify.create({
+            type: 'positive',
+            message: t('globals.dataSaved'),
+            actions: [
+                {
+                    label: t('globals.openDetail'),
+                    color: 'white',
+                    handler: () => useOpenURL(`#/ticket/${id}/${path}`),
+                },
+            ],
         });
+    };
+
+    const handleResult = (result, key, path) => {
+        if (result.status !== 'fulfilled') {
+            const data = JSON.parse(result.reason.config.data);
+            const error =
+                result.reason.response?.data?.error?.message ?? result.reason.message;
+            Notify.create({
+                type: 'negative',
+                message: `Ticket ${data[key]}: ${error}`,
+            });
+            return;
+        }
+
+        const data = JSON.parse(result.value.config.data);
+        let id = data[key];
+
+        if (result.value.data.status === 'noSplit') {
+            Notify.create({
+                type: 'warning',
+                message: `Ticket ${id}: ${t('negative.split.noSplit')}`,
+            });
+            return;
+        }
+
+        if (result.value.data.status === 'split') {
+            id = result.value.data.newTicket;
+        }
+
+        createSuccessNotification(id, path);
+    };
+
+    const notifyResults = (results, key, path = 'sale') =>
+        results.forEach((result) => handleResult(result, key, path));
+
     return { notifyResults };
 }