Merge pull request 'fix: minor issue and add test' (!1818) from warmfix_improve_newPaymentTicket_description into master

Reviewed-on: #1818

src/pages/Ticket/components/TicketNewPayment.vue

@@ -52,30 +52,50 @@ const filterBanks = {
 
 const state = useState();
 const user = state.getUser();
+const originalDescription = ref('');
 const initialData = ref({
     ...$props.formData,
     companyFk: user.value.companyFk,
     payed: Date.vnNew(),
+    originalDescription: '',
 });
 
 function setPaymentType(data, accounting) {
-    data.bankFk = accounting.id;
     if (!accounting) return;
+
+    data.bankFk = accounting.id;
     accountingType.value = accounting.accountingType;
+
     data.description = [];
-    data.payed = Date.vnNew();
     isCash.value = accountingType.value.code == 'cash';
     viewReceipt.value = isCash.value;
-    if (accountingType.value.daysInFuture)
-        data.payed.setDate(data.payed.getDate() + accountingType.value.daysInFuture);
-    maxAmount.value = accountingType.value && accountingType.value.maxAmount;
-    if (accountingType.value.code == 'compensation') return (data.description = '');
 
-    let descriptions = [];
-    if (accountingType.value.receiptDescription)
-        descriptions.push(accountingType.value.receiptDescription);
-    if (data.description > 0) descriptions.push(data.description);
-    data.description = descriptions.join(', ');
+    switch (accountingType.value.code) {
+        case 'compensation':
+            data.description.push($props.formData.description);
+            break;
+
+        default:
+            if (
+                accountingType.value.receiptDescription != null &&
+                accountingType.value.receiptDescription != ''
+            ) {
+                data.description.push(accountingType.value.receiptDescription);
+            }
+            const originalDescription =
+                data.originalDescription || $props.formData.description;
+            if (originalDescription) {
+                data.description.push(originalDescription);
+            }
+    }
+
+    data.description = data.description.join(', ');
+    data.payed = Date.vnNew();
+    if (accountingType.value.daysInFuture) {
+        data.payed.setDate(data.payed.getDate() + accountingType.value.daysInFuture);
+    }
+
+    maxAmount.value = accountingType.value && accountingType.value.maxAmount;
 }
 
 const calculateFromAmount = (event) => {

test/cypress/integration/ticket/ticketBasicData.spec.js

@@ -6,7 +6,7 @@ describe('TicketBasicData', () => {
         cy.visit('/#/ticket/31/basic-data');
     });
 
-    it('Should redirect to customer basic data', () => {
+    it.skip('Should redirect to customer basic data', () => {
         cy.get('.q-page').should('be.visible');
         cy.get(':nth-child(2) > div > .text-primary').click();
         cy.dataCy('Address_select').click();
@@ -16,7 +16,7 @@ describe('TicketBasicData', () => {
         ).click();
         cy.url().should('include', '/customer/1104/basic-data');
     });
-    it.only('stepper', () => {
+    it('stepper', () => {
         cy.get('.q-stepper__tab--active').should('have.class', 'q-stepper__tab--active');
 
         cy.get('.q-stepper__nav > .q-btn--standard').click();

test/cypress/integration/ticket/ticketList.spec.js

@@ -26,6 +26,24 @@ describe('TicketList', () => {
         cy.get('@windowOpen').should('be.calledWithMatch', /\/ticket\/\d+\/sale/);
     });
 
+    it('should create payment ticket', () => {
+        cy.searchInFilterPanel().click();
+
+        const rowSelected =
+            'tbody > :nth-child(2) > :nth-child(1) > .q-checkbox > .q-checkbox__inner ';
+        cy.get(rowSelected).click();
+        cy.get(
+            '[style="transform: translate(-256px, 0px); margin: 140px 20px; z-index: 2;"] > div > .q-btn',
+        ).click();
+        const description = 'Albaran: 31';
+        cy.dataCy('Reference_input').should('have.value', description);
+        cy.selectOption('[data-cy="paymentBank"]', 'Cash');
+        cy.dataCy('Delivered amount_input').clear().type('41.62');
+        cy.dataCy('Reference_input').should('have.value', `Cash, ${description}`);
+        cy.get('[aria-label="View recipt"]').click();
+        cy.get('.q-btn--standard > .q-btn__content > .block').click();
+    });
+
     it('should open ticket summary', () => {
         searchResults();
         cy.getRow().find('.q-btn:last').click();