From 5d356428d3bfdfd03d4c5ddaf0f98d5fdbf19a7d Mon Sep 17 00:00:00 2001
From: jtubau <jtubau@verdnatura.es>
Date: Tue, 18 Mar 2025 15:54:47 +0100
Subject: [PATCH] refactor: refs #8422 enhance error handling in save function
 and update selectors in tests

---
 src/components/common/VnDms.vue                  | 16 ++++++++++------
 .../Route/Vehicle/Card/VehicleDmsImportForm.vue  |  1 -
 .../integration/route/vehicle/vehicleDms.spec.js | 16 +++++++---------
 3 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/src/components/common/VnDms.vue b/src/components/common/VnDms.vue
index c844b63d0..8553a92b6 100644
--- a/src/components/common/VnDms.vue
+++ b/src/components/common/VnDms.vue
@@ -81,12 +81,16 @@ function getUrl() {
 }
 
 async function save() {
-    const body = mapperDms(dms.value);
-    const response = await axios.post(getUrl(), body[0], body[1]);
-    emit('onDataSaved', body[1].params, response);
-    notify(t('globals.dataSaved'), 'positive');
-    delete dms.value.files;
-    return response;
+    try {
+        const body = mapperDms(dms.value);
+        const response = await axios.post(getUrl(), body[0], body[1]);
+        emit('onDataSaved', body[1].params, response);
+        notify(t('globals.dataSaved'), 'positive');
+        delete dms.value.files;
+        return response;
+    } catch (e) {
+        throw new Error(e.message);
+    }
 }
 
 function defaultData() {
diff --git a/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue b/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue
index b700fff06..2708cd07b 100644
--- a/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue
+++ b/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue
@@ -43,7 +43,6 @@ const importDms = async () => {
         @on-fetch="(data) => (dmsOptions = data)"
     />
     <FormModelPopup
-        url-create="genera"
         model="DmsImport"
         :title="t('vehicle.dms.selectDocId')"
         :form-initial-data="{}"
diff --git a/test/cypress/integration/route/vehicle/vehicleDms.spec.js b/test/cypress/integration/route/vehicle/vehicleDms.spec.js
index 1a567efbd..5e22e3507 100644
--- a/test/cypress/integration/route/vehicle/vehicleDms.spec.js
+++ b/test/cypress/integration/route/vehicle/vehicleDms.spec.js
@@ -11,18 +11,16 @@ describe('Vehicle DMS', () => {
             'tr:first-child > :nth-child(5) > .q-tr > :nth-child(1) > span',
         firstRowId: 'tr:first-child > :nth-child(2) > .q-tr > :nth-child(1) > span',
         lastRowWorkerLink: 'tr:last-child > :nth-child(8) > .q-tr > .link',
-        workerDescriptorPopupTitle:
-            '.q-menu > .descriptor > .body > .q-list > .q-item__label--header > .title > span',
-        workerDescriptorGoToSummary:
-            '[href="#/worker/5/summary"] > .q-btn > .q-btn__content > .q-icon',
-        summaryTitle: '.summaryHeader > div',
+        descriptorTitle: '.descriptor .title',
+        descriptorGoToSummaryBtn: '.descriptor [data-cy="goToSummaryBtn"]',
+        summaryTitle: '.summaryHeader',
         referenceInput: 'Reference_input',
         companySelect: 'Company_select',
         warehouseSelect: 'Warehouse_select',
         typeSelect: 'Type_select',
         fileInput: 'VnDms_inputFile',
         importBtn: 'importBtn',
-        addBtn: 'addDmsBtn',
+        addBtn: 'addButton',
         saveFormBtn: 'FormModelPopup_save',
     };
 
@@ -103,8 +101,8 @@ describe('Vehicle DMS', () => {
 
     it('Should redirect to worker summary from worker descriptor pop-up', () => {
         cy.get(selectors.lastRowWorkerLink).click();
-        cy.get(selectors.workerDescriptorPopupTitle).should('contain', 'administrative');
-        cy.get(selectors.workerDescriptorGoToSummary).click();
-        cy.get(selectors.summaryTitle).should('contain', 'administrative');
+        cy.get(selectors.descriptorTitle).should('contain', 'administrative');
+        cy.get(selectors.descriptorGoToSummaryBtn).click();
+        cy.containContent(selectors.summaryTitle, 'administrative');
     });
 });