From 656f2793017f73956900b72289e50c92c46cd9e7 Mon Sep 17 00:00:00 2001
From: jtubau <jtubau@verdnatura.es>
Date: Wed, 12 Mar 2025 15:32:15 +0100
Subject: [PATCH] refactor: refs #8626 enhance Worker and Agency components
 with data attributes and improved routing

---
 src/components/ui/CardDescriptor.vue          |   2 +
 src/components/ui/CardSummary.vue             |   1 +
 .../Route/Agency/Card/AgencyDescriptor.vue    |   2 +-
 src/pages/Route/RouteList.vue                 |  12 +-
 src/pages/Worker/Card/WorkerSummary.vue       |   1 +
 .../route/routeExtendedList.spec.js           |   2 +-
 .../integration/route/routeList.spec.js       | 180 +++++++++++++++---
 7 files changed, 166 insertions(+), 34 deletions(-)

diff --git a/src/components/ui/CardDescriptor.vue b/src/components/ui/CardDescriptor.vue
index 744f84e6d..961438b04 100644
--- a/src/components/ui/CardDescriptor.vue
+++ b/src/components/ui/CardDescriptor.vue
@@ -180,6 +180,7 @@ const toModule = computed(() => {
                     color="white"
                     class="link"
                     v-if="summary"
+                    data-cy="openSummaryBtn"
                 >
                     <QTooltip>
                         {{ t('components.smartCard.openSummary') }}
@@ -194,6 +195,7 @@ const toModule = computed(() => {
                         icon="launch"
                         round
                         size="md"
+                        data-cy="goToSummaryBtn"
                     >
                         <QTooltip>
                             {{ t('components.cardDescriptor.summary') }}
diff --git a/src/components/ui/CardSummary.vue b/src/components/ui/CardSummary.vue
index 6a61994c1..05bfed998 100644
--- a/src/components/ui/CardSummary.vue
+++ b/src/components/ui/CardSummary.vue
@@ -81,6 +81,7 @@ async function fetch() {
                                 name: `${moduleName ?? route.meta.moduleName}Summary`,
                                 params: { id: entityId || entity.id },
                             }"
+                            data-cy="goToSummaryBtn"
                         >
                             <QIcon name="open_in_new" color="white" size="sm" />
                         </router-link>
diff --git a/src/pages/Route/Agency/Card/AgencyDescriptor.vue b/src/pages/Route/Agency/Card/AgencyDescriptor.vue
index a0472c6c3..09aa5ad91 100644
--- a/src/pages/Route/Agency/Card/AgencyDescriptor.vue
+++ b/src/pages/Route/Agency/Card/AgencyDescriptor.vue
@@ -17,7 +17,7 @@ const props = defineProps({
 const { t } = useI18n();
 const route = useRoute();
 const entityId = computed(() => props.id || route.params.id);
-const { store } = useArrayData('Parking');
+const { store } = useArrayData();
 const card = computed(() => store.data);
 </script>
 <template>
diff --git a/src/pages/Route/RouteList.vue b/src/pages/Route/RouteList.vue
index 5803136db..2349d616a 100644
--- a/src/pages/Route/RouteList.vue
+++ b/src/pages/Route/RouteList.vue
@@ -11,7 +11,6 @@ import AgencyDescriptorProxy from 'src/pages/Route/Agency/Card/AgencyDescriptorP
 import VehicleDescriptorProxy from 'src/pages/Route/Vehicle/Card/VehicleDescriptorProxy.vue';
 import VnSection from 'src/components/common/VnSection.vue';
 import VnSelectWorker from 'src/components/common/VnSelectWorker.vue';
-import RouteTickets from './RouteTickets.vue';
 
 const { t } = useI18n();
 const { viewSummary } = useSummaryDialog();
@@ -46,6 +45,7 @@ const columns = computed(() => [
         width: '25px',
     },
     {
+        align: 'left',
         name: 'workerFk',
         label: t('globals.worker'),
         component: markRaw(VnSelectWorker),
@@ -54,12 +54,6 @@ const columns = computed(() => [
         columnFilter: false,
         width: '100px',
     },
-    {
-        name: 'workerFk',
-        label: t('globals.worker'),
-        visible: false,
-        cardVisible: true,
-    },
     {
         align: 'left',
         name: 'agencyModeFk',
@@ -199,7 +193,7 @@ const columns = computed(() => [
                         <WorkerDescriptorProxy :id="row?.workerFk" v-if="row?.workerFk" />
                     </span>
                 </template>
-                <template #column-agencyName="{ row }">
+                <template #column-agencyModeFk="{ row }">
                     <span class="link" @click.stop>
                         {{ row?.agencyName }}
                         <AgencyDescriptorProxy
@@ -208,7 +202,7 @@ const columns = computed(() => [
                         />
                     </span>
                 </template>
-                <template #column-vehiclePlateNumber="{ row }">
+                <template #column-vehicleFk="{ row }">
                     <span class="link" @click.stop>
                         {{ row?.vehiclePlateNumber }}
                         <VehicleDescriptorProxy
diff --git a/src/pages/Worker/Card/WorkerSummary.vue b/src/pages/Worker/Card/WorkerSummary.vue
index 78c5dfd82..2edc5d497 100644
--- a/src/pages/Worker/Card/WorkerSummary.vue
+++ b/src/pages/Worker/Card/WorkerSummary.vue
@@ -39,6 +39,7 @@ onBeforeMount(async () => {
         url="Workers/summary"
         :user-filter="{ where: { id: entityId } }"
         data-key="Worker"
+        module-name="Worker"
     >
         <template #header="{ entity }">
             <div>{{ entity.id }} - {{ entity.firstName }} {{ entity.lastName }}</div>
diff --git a/test/cypress/integration/route/routeExtendedList.spec.js b/test/cypress/integration/route/routeExtendedList.spec.js
index 237729107..b46ce3ba2 100644
--- a/test/cypress/integration/route/routeExtendedList.spec.js
+++ b/test/cypress/integration/route/routeExtendedList.spec.js
@@ -120,7 +120,7 @@ describe('Route extended list', () => {
     it('Should clone selected route', () => {
         cy.get(selectors.lastRowSelectCheckBox).click();
         cy.get(selectors.cloneBtn).click();
-        cy.dataCy('route.Starting date_inputDate').type('10-05-2001');
+        cy.dataCy('Starting date_inputDate').type('10-05-2001');
         cy.get('.q-card__actions > .q-btn--standard > .q-btn__content').click();
         cy.validateContent(selectors.date, '05/10/2001');
     });
diff --git a/test/cypress/integration/route/routeList.spec.js b/test/cypress/integration/route/routeList.spec.js
index 2471fc5c7..d6cb0a58e 100644
--- a/test/cypress/integration/route/routeList.spec.js
+++ b/test/cypress/integration/route/routeList.spec.js
@@ -1,8 +1,26 @@
 describe('Route', () => {
+    const getSelector = (colField) =>
+        `tr:last-child > [data-col-field="${colField}"] > .no-padding > .link`;
+
     const selectors = {
-        worker: 'tr:last-child > [data-col-field="workerFk"]',
-        workerLink: 'tr:last-child > [data-col-field="workerFk"] > .no-padding > .link',
-        rowSummaryBtn: 'tableAction-0',
+        lastRow: 'tr:last-child > [data-col-field="workerFk"]',
+        workerLink: getSelector('workerFk'),
+        agencyLink: getSelector('agencyModeFk'),
+        vehicleLink: getSelector('vehicleFk'),
+        assignedTicketsBtn: 'tableAction-0',
+        rowSummaryBtn: 'tableAction-1',
+        summaryTitle: '.summaryHeader',
+        descriptorTitle: '.descriptor .title',
+        descriptorOpenSummaryBtn: '.descriptor [data-cy="openSummaryBtn"]',
+        descriptorGoToSummaryBtn: '.descriptor [data-cy="goToSummaryBtn"]',
+        SummaryGoToSummaryBtn: '.summaryHeader [data-cy="goToSummaryBtn"]',
+    };
+
+    const data = {
+        Worker: { val: 'logistic', type: 'select' },
+        Agency: { val: 'Walking', type: 'select' },
+        Vehicle: { val: '3333-BAT', type: 'select' },
+        Description: { val: 'routeTest' },
     };
 
     const summaryUrl = '/summary';
@@ -14,49 +32,165 @@ describe('Route', () => {
         cy.typeSearchbar('{enter}');
     });
 
-    it('Should list routes', () => {
+    xit('Should list routes', () => {
         cy.get('.q-table')
             .children()
             .should('be.visible')
             .should('have.length.greaterThan', 0);
     });
 
-    it('Should create new route', () => {
+    xit('Should create new route', () => {
         cy.addBtnClick();
 
-        const data = {
-            Worker: { val: 'logistic', type: 'select' },
-            Agency: { val: 'Walking', type: 'select' },
-            Vehicle: { val: '3333-BAT', type: 'select' },
-            Description: { val: 'routeTest' },
-        };
         cy.fillInForm(data);
 
         cy.dataCy('FormModelPopup_save').should('be.visible').click();
 
         cy.checkNotification('Data created');
         cy.url().should('include', summaryUrl);
+        cy.get(selectors.summaryTitle)
+            .invoke('text')
+            .then((text) => {
+                expect(text).to.include(data.Description.val);
+            });
     });
 
-    it('Should open summary by clicking a route', () => {
-        cy.get(selectors.worker).should('be.visible').click();
+    xit('Should open route summary by clicking a route', () => {
+        cy.get(selectors.lastRow).should('be.visible').click();
         cy.url().should('include', summaryUrl);
+        cy.get(selectors.summaryTitle)
+            .invoke('text')
+            .then((text) => {
+                expect(text).to.include(data.Description.val);
+            });
     });
 
-    it('Should open the route summary pop-up', () => {
+    xit('Should redirect to the summary from the route pop-up summary', () => {
         cy.dataCy(selectors.rowSummaryBtn).last().should('be.visible').click();
-        cy.get('.summaryHeader > :nth-child(2').should('contain', 'routeTest');
-        cy.validateContent(':nth-child(2) > :nth-child(3) > .value > span', '3333-BAT');
+        cy.get(selectors.descriptorTitle)
+            .invoke('text')
+            .then((text) => {
+                expect(text).to.include(data.Description.val);
+            });
+        cy.get(selectors.SummaryGoToSummaryBtn).click();
+        cy.get(selectors.summaryTitle)
+            .invoke('text')
+            .then((text) => {
+                expect(text).to.include(data.Description.val);
+            });
     });
 
-    it('Should redirect to the summary from the route summary pop-up', () => {
-        cy.dataCy(selectors.rowSummaryBtn).last().should('be.visible').click();
-        cy.get('.header > .q-icon').should('be.visible').click();
-        cy.url().should('include', summaryUrl);
+    describe('Worker pop-ups', () => {
+        it('Should redirect to summary from the worker pop-up descriptor', () => {
+            cy.get(selectors.workerLink).click();
+            cy.get(selectors.descriptorTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Worker.val);
+                });
+            cy.get(selectors.descriptorGoToSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Worker.val);
+                });
+        });
+
+        it('Should redirect to the summary from the worker pop-up summary', () => {
+            cy.get(selectors.workerLink).click();
+            cy.get(selectors.descriptorTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Worker.val);
+                });
+            cy.get(selectors.descriptorOpenSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Worker.val);
+                });
+            cy.get(selectors.SummaryGoToSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Worker.val);
+                });
+        });
     });
 
-    it('Should open the worker summary pop-up', () => {
-        cy.get(selectors.workerLink).click();
-        cy.get(':nth-child(1) > .value > span').should('contain', 'logistic');
+    describe('Agency pop-ups', () => {
+        it('Should redirect to summary from the agency pop-up descriptor', () => {
+            cy.get(selectors.agencyLink).click();
+            cy.get(selectors.descriptorTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Agency.val);
+                });
+            cy.get(selectors.descriptorGoToSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Agency.val);
+                });
+        });
+
+        it('Should redirect to the summary from the agency pop-up summary', () => {
+            cy.get(selectors.agencyLink).click();
+            cy.get(selectors.descriptorTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Agency.val);
+                });
+            cy.get(selectors.descriptorOpenSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Agency.val);
+                });
+            cy.get(selectors.SummaryGoToSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Agency.val);
+                });
+        });
+    });
+
+    describe.only('Vehicle pop-ups', () => {
+        it('Should redirect to summary from the vehicle pop-up descriptor', () => {
+            cy.get(selectors.vehicleLink).click();
+            cy.get(selectors.descriptorTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Vehicle.val);
+                });
+            cy.get(selectors.descriptorGoToSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Vehicle.val);
+                });
+        });
+
+        it('Should redirect to the summary from the vehicle pop-up summary', () => {
+            cy.get(selectors.vehicleLink).click();
+            cy.get(selectors.descriptorTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Vehicle.val);
+                });
+            cy.get(selectors.descriptorOpenSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Vehicle.val);
+                });
+            cy.get(selectors.SummaryGoToSummaryBtn).click();
+            cy.get(selectors.summaryTitle)
+                .invoke('text')
+                .then((text) => {
+                    expect(text).to.include(data.Vehicle.val);
+                });
+        });
     });
 });