From 6e76e6e1a7101bb036fa24899549ee7554996a20 Mon Sep 17 00:00:00 2001
From: Kevin Martinez <kevin.martinez@mindshore.io>
Date: Wed, 20 Dec 2023 08:27:35 -0400
Subject: [PATCH] Update with feedback

---
 src/pages/Order/Card/OrderCard.vue           |  9 -----
 src/pages/Order/Card/OrderCatalogFilter.vue  |  5 ++-
 src/pages/Order/Card/OrderCatalogItem.vue    |  4 +-
 src/pages/Order/Card/OrderDescriptorMenu.vue | 22 +++++-----
 src/pages/Order/Card/OrderFilter.vue         | 42 +++++++++++++++++---
 5 files changed, 53 insertions(+), 29 deletions(-)

diff --git a/src/pages/Order/Card/OrderCard.vue b/src/pages/Order/Card/OrderCard.vue
index f6288207d..4163e22a4 100644
--- a/src/pages/Order/Card/OrderCard.vue
+++ b/src/pages/Order/Card/OrderCard.vue
@@ -21,12 +21,3 @@ const stateStore = useStateStore();
         </QPage>
     </QPageContainer>
 </template>
-
-<i18n>
-es:
-    Search claim: Buscar reclamación
-    You can search by claim id or customer name: Puedes buscar por id de la reclamación o nombre del cliente
-    Details: Detalles
-    Notes: Notas
-    Action: Acción
-</i18n>
diff --git a/src/pages/Order/Card/OrderCatalogFilter.vue b/src/pages/Order/Card/OrderCatalogFilter.vue
index 792a5606e..46de63abd 100644
--- a/src/pages/Order/Card/OrderCatalogFilter.vue
+++ b/src/pages/Order/Card/OrderCatalogFilter.vue
@@ -126,7 +126,7 @@ function exprBuilder(param, value) {
                         </QIcon>
                     </div>
                 </QItem>
-                <QItem>
+                <QItem class="q-mt-md">
                     <QItemSection>
                         <VnSelectFilter
                             :label="t('params.type')"
@@ -134,6 +134,9 @@ function exprBuilder(param, value) {
                             :options="typeList"
                             option-value="id"
                             option-label="name"
+                            dense
+                            outlined
+                            rounded
                             emit-value
                             use-input
                             :disable="!selectedCategoryFk"
diff --git a/src/pages/Order/Card/OrderCatalogItem.vue b/src/pages/Order/Card/OrderCatalogItem.vue
index d187df8ce..6579fc261 100644
--- a/src/pages/Order/Card/OrderCatalogItem.vue
+++ b/src/pages/Order/Card/OrderCatalogItem.vue
@@ -58,7 +58,7 @@ const dialog = ref(null);
                 />
                 <div class="footer">
                     <div class="price">
-                        <p>{{ item.available }} to {{ item.price }}</p>
+                        <p>{{ item.available }} {{ t('to') }} {{ item.price }}</p>
                         <QIcon name="add_circle" class="icon">
                             <QTooltip>{{ t('globals.add') }}</QTooltip>
                             <QPopupProxy ref="dialog">
@@ -176,7 +176,9 @@ const dialog = ref(null);
 </style>
 <i18n>
 es:
+    to: to
     price-kg: Precio por Kg
 en:
+    to: hasta
     price-kg: Price per Kg
 </i18n>
diff --git a/src/pages/Order/Card/OrderDescriptorMenu.vue b/src/pages/Order/Card/OrderDescriptorMenu.vue
index 267c47c1d..b432ba4d7 100644
--- a/src/pages/Order/Card/OrderDescriptorMenu.vue
+++ b/src/pages/Order/Card/OrderDescriptorMenu.vue
@@ -50,16 +50,14 @@ async function remove() {
 </template>
 
 <i18n>
-{
-    "en": {
-        "deleteOrder": "Delete order",
-        "confirmDeletion": "Confirm deletion",
-        "confirmDeletionMessage": "Are you sure you want to delete this order?"
-    },
-    "es": {
-        "deleteOrder": "Eliminar pedido",
-        "confirmDeletion": "Confirmar eliminación",
-        "confirmDeletionMessage": "Seguro que quieres eliminar este pedido?"
-    }
-}
+en:
+    deleteOrder: Delete order,
+    confirmDeletion: Confirm deletion,
+    confirmDeletionMessage: Are you sure you want to delete this order?
+
+es:
+    deleteOrder: Eliminar pedido,
+    confirmDeletion: Confirmar eliminación,
+    confirmDeletionMessage: Seguro que quieres eliminar este pedido?
+
 </i18n>
diff --git a/src/pages/Order/Card/OrderFilter.vue b/src/pages/Order/Card/OrderFilter.vue
index 0d12f31da..d35072519 100644
--- a/src/pages/Order/Card/OrderFilter.vue
+++ b/src/pages/Order/Card/OrderFilter.vue
@@ -5,6 +5,7 @@ import FetchData from 'components/FetchData.vue';
 import VnFilterPanel from 'src/components/ui/VnFilterPanel.vue';
 import VnSelectFilter from 'components/common/VnSelectFilter.vue';
 import VnInputDate from "components/common/VnInputDate.vue";
+import VnInput from "components/common/VnInput.vue";
 
 const { t } = useI18n();
 const props = defineProps({
@@ -58,10 +59,13 @@ const sourceList = ref(null);
             </div>
         </template>
         <template #body="{ params }">
-            <QList dense>
+            <QList id="orderFilter" dense>
                 <QItem>
                     <QItemSection>
-                        <QInput
+                        <VnInput
+                            dense
+                            outlined
+                            rounded
                             :label="t('customerId')"
                             v-model="params.clientFk"
                             lazy-rules
@@ -69,7 +73,7 @@ const sourceList = ref(null);
                             <template #prepend>
                                 <QIcon name="badge" size="sm"></QIcon>
                             </template>
-                        </QInput>
+                        </VnInput>
                     </QItemSection>
                 </QItem>
                 <QItem>
@@ -80,6 +84,9 @@ const sourceList = ref(null);
                             :options="agencyList"
                             option-value="id"
                             option-label="name"
+                            dense
+                            outlined
+                            rounded
                             emit-value
                             map-options
                             use-input
@@ -98,6 +105,9 @@ const sourceList = ref(null);
                             :options="salesPersonList"
                             option-value="id"
                             option-label="name"
+                            dense
+                            outlined
+                            rounded
                             emit-value
                             map-options
                             use-input
@@ -123,22 +133,31 @@ const sourceList = ref(null);
                     <QItemSection>
                         <VnInputDate
                             v-model="params.from"
-                            :label="t('fromLanded')" />
+                            :label="t('fromLanded')"
+                            dense
+                            outlined
+                            rounded />
                     </QItemSection>
                 </QItem>
                 <QItem>
                     <QItemSection>
                         <VnInputDate
                             v-model="params.to"
-                            :label="t('toLanded')" />
+                            :label="t('toLanded')"
+                            dense
+                            outlined
+                            rounded />
                     </QItemSection>
                 </QItem>
                 <QItem>
                     <QItemSection>
-                        <QInput
+                        <VnInput
                             :label="t('orderId')"
                             v-model="params.orderFk"
                             lazy-rules
+                            dense
+                            outlined
+                            rounded
                         />
                     </QItemSection>
                 </QItem>
@@ -152,6 +171,9 @@ const sourceList = ref(null);
                             emit-value
                             map-options
                             use-input
+                            dense
+                            outlined
+                            rounded
                             :input-debounce="0"
                         />
                     </QItemSection>
@@ -190,6 +212,14 @@ const sourceList = ref(null);
     </VnFilterPanel>
 </template>
 
+<style lang="scss">
+#orderFilter {
+    .q-item {
+        padding-top: 8px;
+    }
+}
+</style>
+
 <i18n>
 en:
     params: