From 73f02cf8bd8a49607651062a59b35954ac1cdfba Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Mon, 10 Feb 2025 13:18:59 +0100
Subject: [PATCH] refactor: use data-cy in VnSelectSupplier component and
 refactored e2e

---
 src/components/common/VnSelectSupplier.vue                   | 1 +
 src/pages/InvoiceIn/Card/InvoiceInBasicData.vue              | 1 -
 .../cypress/integration/invoiceIn/invoiceInBasicData.spec.js | 5 ++++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/components/common/VnSelectSupplier.vue b/src/components/common/VnSelectSupplier.vue
index 5a821456e..5b52ae75b 100644
--- a/src/components/common/VnSelectSupplier.vue
+++ b/src/components/common/VnSelectSupplier.vue
@@ -15,6 +15,7 @@ const model = defineModel({ type: [String, Number, Object] });
         :fields="['id', 'name', 'nickname', 'nif']"
         :filter-options="['id', 'name', 'nickname', 'nif']"
         sort-by="name ASC"
+        data-cy="vnSupplierSelect"
     >
         <template #option="scope">
             <QItem v-bind="scope.itemProps">
diff --git a/src/pages/InvoiceIn/Card/InvoiceInBasicData.vue b/src/pages/InvoiceIn/Card/InvoiceInBasicData.vue
index 0ea5dd0ed..905ddebb2 100644
--- a/src/pages/InvoiceIn/Card/InvoiceInBasicData.vue
+++ b/src/pages/InvoiceIn/Card/InvoiceInBasicData.vue
@@ -121,7 +121,6 @@ function deleteFile(dmsFk) {
                     hide-selected
                     :is-clearable="false"
                     :required="true"
-                    data-cy="vnSupplierSelect"
                 />
                 <VnInput
                     clearable
diff --git a/test/cypress/integration/invoiceIn/invoiceInBasicData.spec.js b/test/cypress/integration/invoiceIn/invoiceInBasicData.spec.js
index 7a9c2b4a0..c6bcc37c1 100644
--- a/test/cypress/integration/invoiceIn/invoiceInBasicData.spec.js
+++ b/test/cypress/integration/invoiceIn/invoiceInBasicData.spec.js
@@ -14,7 +14,10 @@ describe('InvoiceInBasicData', () => {
         cy.dataCy('UnDeductibleVatSelect').type('4751000000');
         cy.get('.q-menu .q-item').contains('4751000000').click();
         cy.get(resetBtn).click();
-        cy.dataCy('vnSupplierSelect').type('Bros nick');
+
+        cy.waitForElement('#formModel').within(() => {
+            cy.dataCy('vnSupplierSelect').type('Bros nick');
+        })
         cy.get('.q-menu .q-item').contains('Bros nick').click();
         cy.saveCard();
         cy.get(`${firstFormSelect} input`).invoke('val').should('eq', 'Bros nick');