From 9ee69274ae794f88350d3f71619fbcb111a728cf Mon Sep 17 00:00:00 2001 From: jon Date: Wed, 7 May 2025 12:28:05 +0200 Subject: [PATCH 1/4] fix: make 0 become valid in VnInputNumber when using required from validator --- src/composables/useValidator.js | 4 +++- .../customer/clientCredits.spec.js | 22 ++++++++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/composables/useValidator.js b/src/composables/useValidator.js index ae6c47d91..e887c0c4f 100644 --- a/src/composables/useValidator.js +++ b/src/composables/useValidator.js @@ -47,7 +47,9 @@ export function useValidator() { return !validator.isEmpty(value ? String(value) : '') || message; }, required: (required, value) => { - return required ? !!value || t('globals.fieldRequired') : null; + return required + ? value === 0 || !!value || t('globals.fieldRequired') + : null; }, length: (value) => { const options = { diff --git a/test/cypress/integration/customer/clientCredits.spec.js b/test/cypress/integration/customer/clientCredits.spec.js index 5f303b40d..f39f3c06c 100644 --- a/test/cypress/integration/customer/clientCredits.spec.js +++ b/test/cypress/integration/customer/clientCredits.spec.js @@ -7,7 +7,27 @@ describe('Client credits', () => { timeout: 5000, }); }); - it('Should load layout', () => { + + it('Should put a new credit', () => { cy.get('.q-page').should('be.visible'); + cy.dataCy('vnTableCreateBtn').click(); + cy.dataCy('Credit_input').type('100'); + cy.dataCy('FormModelPopup_save').click(); + cy.checkNotification('Data saved'); + }); + + it('Should put a new credit with value 0 to close the client card', () => { + cy.get('.q-page').should('be.visible'); + cy.dataCy('vnTableCreateBtn').click(); + cy.dataCy('Credit_input').type('0'); + cy.dataCy('FormModelPopup_save').click(); + cy.checkNotification('Data saved'); + }); + + it('Should not create the credit if there is no value in the input', () => { + cy.get('.q-page').should('be.visible'); + cy.dataCy('vnTableCreateBtn').click(); + cy.dataCy('FormModelPopup_save').click(); + cy.get('.q-notification__message').should('not.exist'); }); }); From 84945b32f680708df35d790e0b218e03a4d316b7 Mon Sep 17 00:00:00 2001 From: Javier Segarra Date: Mon, 12 May 2025 13:13:14 +0200 Subject: [PATCH 2/4] fix: initialize form data in FormModelPopup --- src/pages/Customer/components/CustomerNewCustomsAgent.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/Customer/components/CustomerNewCustomsAgent.vue b/src/pages/Customer/components/CustomerNewCustomsAgent.vue index ec9806334..69ecb0d27 100644 --- a/src/pages/Customer/components/CustomerNewCustomsAgent.vue +++ b/src/pages/Customer/components/CustomerNewCustomsAgent.vue @@ -16,6 +16,7 @@ const onDataSaved = (dataSaved) => {