From 5e17117db327c00e4c124a24292450dfc96e6a4b Mon Sep 17 00:00:00 2001 From: jon Date: Tue, 6 May 2025 11:24:45 +0200 Subject: [PATCH 1/2] fix: fixed label and increased test coverage --- src/components/common/VnBankDetailsForm.vue | 2 +- src/components/common/__tests__/VnBankDetailsForm.spec.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/components/common/VnBankDetailsForm.vue b/src/components/common/VnBankDetailsForm.vue index 4e13a4d86..5efe7ec27 100644 --- a/src/components/common/VnBankDetailsForm.vue +++ b/src/components/common/VnBankDetailsForm.vue @@ -72,7 +72,7 @@ const getBankEntities = (data) => { :acls="[{ model: 'BankEntity', props: '*', accessType: 'WRITE' }]" :options="bankEntities" hide-selected - option-label="name" + option-label="bic" option-value="id" v-model="bankEntityFk" @update:model-value="$emit('updateBic', { iban, bankEntityFk })" diff --git a/src/components/common/__tests__/VnBankDetailsForm.spec.js b/src/components/common/__tests__/VnBankDetailsForm.spec.js index 9d6ade902..b7919a985 100644 --- a/src/components/common/__tests__/VnBankDetailsForm.spec.js +++ b/src/components/common/__tests__/VnBankDetailsForm.spec.js @@ -40,4 +40,11 @@ describe('VnBankDetail Component', () => { await vm.autofillBic('ES1234567891324567891234'); expect(vm.bankEntityFk).toBe(null); }); + + it('should not update bankEntityFk if IBAN country is not ES', async () => { + vm.bankEntities = bankEntities; + + await vm.autofillBic('FR1420041010050500013M02606'); + expect(vm.bankEntityFk).toBe(null); + }); }); From beeeedbb8455616e6e0f22bda6801cc0deb71277 Mon Sep 17 00:00:00 2001 From: alexm Date: Thu, 8 May 2025 10:21:32 +0200 Subject: [PATCH 2/2] feat(ExtraCommunity): refs #8105 add data-cy attribute for testing and create integration tests --- src/pages/Travel/ExtraCommunity.vue | 1 + .../integration/travel/ExtraCommunity.spec.js | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) create mode 100644 test/cypress/integration/travel/ExtraCommunity.spec.js diff --git a/src/pages/Travel/ExtraCommunity.vue b/src/pages/Travel/ExtraCommunity.vue index afa0663a8..17c957a50 100644 --- a/src/pages/Travel/ExtraCommunity.vue +++ b/src/pages/Travel/ExtraCommunity.vue @@ -547,6 +547,7 @@ watch(route, () => { }, ]" v-text="col.value" + :data-cy="`extra-community-${col.name}`" /> { + it('Should show travels', () => { + cy.login('logistic'); + cy.visit(`/#/travel/extra-community`); + cy.get('.q-page').should('be.visible'); + }); + + it('Should show travels when user is supplier', () => { + cy.login('petterparker'); + cy.visit(`/#/travel/extra-community`); + cy.get('[data-cy="vnFilterPanelChip_continent"] > .q-chip__icon--remove').click(); + cy.dataCy('extra-community-cargoSupplierNickname').each(($el) => { + cy.wrap($el).should('contain.text', 'The farmer'); + }); + }); +});