From 9e36ddfd8f5cdad8bbd0b33cd1e05c68c635b24a Mon Sep 17 00:00:00 2001
From: jtubau <jtubau@verdnatura.es>
Date: Mon, 3 Mar 2025 10:44:02 +0100
Subject: [PATCH] refactor: refs #8616 simplify template bindings and improve
 link generation in VehicleSummary

---
 src/components/ui/CardDescriptor.vue               |  2 +-
 src/pages/Route/Roadmap/RoadmapDescriptor.vue      |  2 +-
 src/pages/Route/RouteRoadmap.vue                   |  1 -
 src/pages/Route/Vehicle/Card/VehicleDescriptor.vue |  1 -
 src/pages/Route/Vehicle/Card/VehicleSummary.vue    | 11 ++++++-----
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/components/ui/CardDescriptor.vue b/src/components/ui/CardDescriptor.vue
index 8fc3ade0d..a29d1d429 100644
--- a/src/components/ui/CardDescriptor.vue
+++ b/src/components/ui/CardDescriptor.vue
@@ -129,7 +129,7 @@ const toModule = computed(() =>
 </script>
 
 <template>
-    <div class="descriptor" v-bind="$attrs">
+    <div class="descriptor">
         <template v-if="entity && !isLoading">
             <div class="header bg-primary q-pa-sm justify-between">
                 <slot name="header-extra-action"
diff --git a/src/pages/Route/Roadmap/RoadmapDescriptor.vue b/src/pages/Route/Roadmap/RoadmapDescriptor.vue
index 927eaa573..198bcf8c7 100644
--- a/src/pages/Route/Roadmap/RoadmapDescriptor.vue
+++ b/src/pages/Route/Roadmap/RoadmapDescriptor.vue
@@ -34,7 +34,7 @@ const entityId = computed(() => {
         :url="`Roadmaps/${entityId}`"
         :filter="filter"
         data-key="Roadmap"
-        :summary="$props.summary"
+        :summary="summary"
     >
         <template #body="{ entity }">
             <VnLv :label="t('Roadmap')" :value="entity?.name" />
diff --git a/src/pages/Route/RouteRoadmap.vue b/src/pages/Route/RouteRoadmap.vue
index 23b1b1d5b..badee148b 100644
--- a/src/pages/Route/RouteRoadmap.vue
+++ b/src/pages/Route/RouteRoadmap.vue
@@ -8,7 +8,6 @@ import { useSummaryDialog } from 'composables/useSummaryDialog';
 import toCurrency from 'filters/toCurrency';
 import axios from 'axios';
 
-import VnSearchbar from 'components/ui/VnSearchbar.vue';
 import VnSubToolbar from 'src/components/ui/VnSubToolbar.vue';
 import VnTable from 'components/VnTable/VnTable.vue';
 import RoadmapSummary from 'pages/Route/Roadmap/RoadmapSummary.vue';
diff --git a/src/pages/Route/Vehicle/Card/VehicleDescriptor.vue b/src/pages/Route/Vehicle/Card/VehicleDescriptor.vue
index d9a2434ab..50129cd9a 100644
--- a/src/pages/Route/Vehicle/Card/VehicleDescriptor.vue
+++ b/src/pages/Route/Vehicle/Card/VehicleDescriptor.vue
@@ -11,7 +11,6 @@ const { notify } = useNotify();
         :url="`Vehicles/${$route.params.id}`"
         data-key="Vehicle"
         title="numberPlate"
-        :to-module="{ name: 'VehicleList' }"
     >
         <template #menu="{ entity }">
             <QItem
diff --git a/src/pages/Route/Vehicle/Card/VehicleSummary.vue b/src/pages/Route/Vehicle/Card/VehicleSummary.vue
index a4879ff1a..13d4bbc9d 100644
--- a/src/pages/Route/Vehicle/Card/VehicleSummary.vue
+++ b/src/pages/Route/Vehicle/Card/VehicleSummary.vue
@@ -13,12 +13,13 @@ const props = defineProps({ id: { type: [Number, String], default: null } });
 
 const route = useRoute();
 const entityId = computed(() => props.id || +route.params.id);
+const baseLink = `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}`;
 const links = {
-    'basic-data': `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/basic-data`,
-    notes: `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/notes`,
-    dms: `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/dms`,
-    'invoice-in': `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/invoice-in`,
-    events: `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/events`,
+    'basic-data': `${baseLink}/basic-data`,
+    notes: `${baseLink}/notes`,
+    dms: `${baseLink}/dms`,
+    'invoice-in': `${baseLink}/invoice-in`,
+    events: `${baseLink}/events`,
 };
 </script>
 <template>