From b8be248af9cd6a3956fef8a4f1804110c15ef9ef Mon Sep 17 00:00:00 2001 From: jtubau Date: Fri, 14 Mar 2025 08:12:48 +0100 Subject: [PATCH] fix: refs #8441 update unassign invoice functionality and notifications --- src/pages/Route/Vehicle/Card/VehicleInvoiceIn.vue | 10 +++++++--- src/pages/Route/Vehicle/locale/en.yml | 1 + src/pages/Route/Vehicle/locale/es.yml | 1 + src/pages/Route/locale/es.yml | 4 ++-- .../integration/route/vehicle/vehicleInvoiceIn.spec.js | 4 ++-- 5 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/pages/Route/Vehicle/Card/VehicleInvoiceIn.vue b/src/pages/Route/Vehicle/Card/VehicleInvoiceIn.vue index 61ce6caf8..4794139d0 100644 --- a/src/pages/Route/Vehicle/Card/VehicleInvoiceIn.vue +++ b/src/pages/Route/Vehicle/Card/VehicleInvoiceIn.vue @@ -79,9 +79,13 @@ const columns = computed(() => [ ]); async function unassignInvoice(id) { - await axios.delete(`VehicleInvoiceIns/${id}`); - notify(t('globals.dataSaved'), 'positive'); - tableRef.value.reload(); + try { + await axios.delete(`VehicleInvoiceIns/${id}`); + notify(t('vehicle.ticket.invoiceUnlinked'), 'positive'); + tableRef.value.reload(); + } catch (e) { + throw e; + } } diff --git a/src/pages/Route/Vehicle/locale/en.yml b/src/pages/Route/Vehicle/locale/en.yml index 9a32080b1..45a0a4950 100644 --- a/src/pages/Route/Vehicle/locale/en.yml +++ b/src/pages/Route/Vehicle/locale/en.yml @@ -21,5 +21,6 @@ vehicle: ticket: assignedInvoices: Assigned Invoices assignInvoice: Assign invoice + invoiceUnlinked: Invoice unlinked unassignInvoice: Unassign invoice unassignInvoiceConfirmation: This invoice will be unassigned from this vehicle! Continue anyway? diff --git a/src/pages/Route/Vehicle/locale/es.yml b/src/pages/Route/Vehicle/locale/es.yml index 08c7b324a..7cda1006c 100644 --- a/src/pages/Route/Vehicle/locale/es.yml +++ b/src/pages/Route/Vehicle/locale/es.yml @@ -21,5 +21,6 @@ vehicle: ticket: assignedInvoices: Facturas vinculadas assignInvoice: Vincular factura + invoiceUnlinked: Factura desvinculada unassignInvoice: Desvincular factura unassignInvoiceConfirmation: Esta factura se desvinculará de este vehículo! ¿Continuar de todas formas? diff --git a/src/pages/Route/locale/es.yml b/src/pages/Route/locale/es.yml index 78af0358c..6affd7e99 100644 --- a/src/pages/Route/locale/es.yml +++ b/src/pages/Route/locale/es.yml @@ -17,7 +17,7 @@ route: clientFk: Id cliente countryFk: Pais warehouseFk: Almacén - shipped: Fecha preparación + shipped: F. preparación agencyModeName: Agencia Ruta agencyAgreement: Agencia Acuerdo issued: F. emisión @@ -58,6 +58,6 @@ route: routeFk: Id ruta country: País clientFk: Id cliente - shipped: Fecha preparación + shipped: F. preparación viewCmr: Ver CMR downloadCmrs: Descargar CMRs diff --git a/test/cypress/integration/route/vehicle/vehicleInvoiceIn.spec.js b/test/cypress/integration/route/vehicle/vehicleInvoiceIn.spec.js index d941e6b78..7899b36ab 100644 --- a/test/cypress/integration/route/vehicle/vehicleInvoiceIn.spec.js +++ b/test/cypress/integration/route/vehicle/vehicleInvoiceIn.spec.js @@ -1,4 +1,4 @@ -describe.only('Vehicle Invoice In', () => { +describe('Vehicle Invoice In', () => { const selectors = { firstRowSupplier: 'tr:first-child > .expand > .no-padding > .link', firstRowInvoice: @@ -42,7 +42,7 @@ describe.only('Vehicle Invoice In', () => { it('Should unassign an invoice', () => { cy.dataCy(selectors.unassignBtn).last().click(); cy.clickConfirm(); - cy.checkNotification('Data saved'); + cy.checkNotification('Invoice unlinked'); }); describe('Supplier pop-ups', () => {