From b83c6407604681f7324cd65fda3f2661f7890b57 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Fri, 29 Nov 2024 07:32:31 +0100
Subject: [PATCH 1/4] feat: improve  Merge branch 'test' into dev

---
 src/components/CreateNewPostcodeForm.vue | 76 ++++++++++++++++--------
 1 file changed, 52 insertions(+), 24 deletions(-)

diff --git a/src/components/CreateNewPostcodeForm.vue b/src/components/CreateNewPostcodeForm.vue
index 232f86a49..d082df9e5 100644
--- a/src/components/CreateNewPostcodeForm.vue
+++ b/src/components/CreateNewPostcodeForm.vue
@@ -22,13 +22,12 @@ const postcodeFormData = reactive({
     townFk: null,
 });
 
-const townsFetchDataRef = ref(false);
 const countriesRef = ref(false);
 const townsRef = ref(false);
 const provincesFetchDataRef = ref(false);
 const provincesOptions = ref([]);
+const townsOptions = ref([]);
 const town = ref({});
-const townFilter = ref({});
 const countryFilter = ref({});
 
 function onDataSaved(formData) {
@@ -50,13 +49,13 @@ function onDataSaved(formData) {
 
 async function onCityCreated(newTown, formData) {
     await provincesFetchDataRef.value.fetch();
-    newTown.province = provincesOptions.value.find(
-        (province) => province.id === newTown.provinceFk
-    );
+    newTown.province = findProvince(newTown.provinceFk);
     formData.townFk = newTown;
     setTown(newTown, formData);
 }
-
+function findProvince(provinceId) {
+    return provincesOptions.value.find(({ id }) => id === provinceId);
+}
 function setTown(newTown, data) {
     town.value = newTown;
     data.provinceFk = newTown?.provinceFk ?? newTown;
@@ -71,12 +70,22 @@ async function setCountry(countryFk, data) {
 
 async function handleProvinces(data) {
     provincesOptions.value = data;
+    // handleTowns(data);
+}
+async function handleTowns(data) {
+    townsOptions.value = data;
+    // whereTowns.value.provinceFk.inq = mapData(data);
+    // townsRef.value.opts = [];
 }
 
 async function setProvince(id, data) {
-    const newProvince = provincesOptions.value.find((province) => province.id == id);
-    if (!newProvince) return;
-
+    const newProvince = findProvince(id);
+    if (!newProvince) {
+        data.townFk = null;
+        return;
+    }
+    whereTowns.value.provinceFk.inq = [id];
+    // handleTowns([newProvince]);
     data.countryFk = newProvince.countryFk;
 }
 
@@ -87,13 +96,26 @@ async function onProvinceCreated(data) {
     postcodeFormData.provinceFk = data.id;
 }
 
-const whereTowns = computed(() => {
-    return {
-        provinceFk: {
-            inq: provincesOptions.value.map(({ id }) => id),
-        },
-    };
-});
+const whereTowns = ref({});
+// const whereTowns = ref(() => {
+//     if (!postcodeFormData.provinceFk) return { provinceFk: { inq: null } };
+//     if (postcodeFormData.provinceFk)
+//         return {
+//             provinceFk: {
+//                 inq: [postcodeFormData.provinceFk], //provincesOptions.value.map(({ id }) => id),
+//             },
+//         };
+
+//     return {
+//         provinceFk: {
+//             inq: mapData(provincesOptions.value),
+//         },
+//     };
+// });
+function mapData(data) {
+    if (data.length === 0) return data;
+    return data.map(({ id }) => id);
+}
 </script>
 
 <template>
@@ -101,10 +123,19 @@ const whereTowns = computed(() => {
         ref="provincesFetchDataRef"
         @on-fetch="handleProvinces"
         :sort-by="['name ASC']"
-        :limit="30"
+        :limit="2"
         auto-load
         url="Provinces/location"
     />
+    <FetchData
+        ref="townsRef"
+        @on-fetch="handleTowns"
+        :sort-by="['name ASC']"
+        :limit="2"
+        auto-load
+        :where="whereTowns"
+        url="Towns/location"
+    />
 
     <FormModelPopup
         url-create="postcodes"
@@ -116,6 +147,7 @@ const whereTowns = computed(() => {
         @on-data-saved="onDataSaved"
     >
         <template #form-inputs="{ data, validate }">
+            {{ whereTowns }}
             <VnRow>
                 <VnInput
                     :label="t('Postcode')"
@@ -125,18 +157,14 @@ const whereTowns = computed(() => {
                     required
                 />
                 <VnSelectDialog
-                    ref="townsRef"
-                    :sort-by="['name ASC']"
-                    :limit="30"
-                    auto-load
-                    url="Towns/location"
-                    :where="whereTowns"
                     :label="t('City')"
                     @update:model-value="(value) => setTown(value, data)"
                     :tooltip="t('Create city')"
                     v-model="data.townFk"
                     option-label="name"
+                    :options="townsOptions"
                     option-value="id"
+                    @input-value="(evt) => (whereTowns.name = { like: `%${evt}%` })"
                     :rules="validate('postcode.city')"
                     :acls="[{ model: 'Town', props: '*', accessType: 'WRITE' }]"
                     :emit-value="false"
@@ -178,7 +206,7 @@ const whereTowns = computed(() => {
                 />
                 <VnSelect
                     ref="countriesRef"
-                    :limit="30"
+                    :limit="2"
                     :filter="countryFilter"
                     :sort-by="['name ASC']"
                     auto-load

From 444f68e937af5903cc02fed4b963fe11cb780c6e Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sun, 1 Dec 2024 23:52:41 +0100
Subject: [PATCH 2/4] fix: #8016 fetching data

---
 src/components/CreateNewPostcodeForm.vue      | 126 ++++++++++--------
 src/components/VnSelectProvince.vue           |   2 +-
 src/components/common/VnLocation.vue          |   1 -
 .../vnComponent/VnLocation.spec.js            |  23 ++--
 4 files changed, 79 insertions(+), 73 deletions(-)

diff --git a/src/components/CreateNewPostcodeForm.vue b/src/components/CreateNewPostcodeForm.vue
index d082df9e5..8000aac52 100644
--- a/src/components/CreateNewPostcodeForm.vue
+++ b/src/components/CreateNewPostcodeForm.vue
@@ -1,5 +1,5 @@
 <script setup>
-import { computed, reactive, ref } from 'vue';
+import { reactive, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 
 import FetchData from 'components/FetchData.vue';
@@ -21,9 +21,10 @@ const postcodeFormData = reactive({
     provinceFk: null,
     townFk: null,
 });
+const townsFetchDataRef = ref(false);
+const townFilter = ref({});
 
 const countriesRef = ref(false);
-const townsRef = ref(false);
 const provincesFetchDataRef = ref(false);
 const provincesOptions = ref([]);
 const townsOptions = ref([]);
@@ -47,74 +48,79 @@ function onDataSaved(formData) {
     emit('onDataSaved', newPostcode);
 }
 
-async function onCityCreated(newTown, formData) {
-    await provincesFetchDataRef.value.fetch();
-    newTown.province = findProvince(newTown.provinceFk);
-    formData.townFk = newTown;
-    setTown(newTown, formData);
-}
-function findProvince(provinceId) {
-    return provincesOptions.value.find(({ id }) => id === provinceId);
-}
-function setTown(newTown, data) {
-    town.value = newTown;
-    data.provinceFk = newTown?.provinceFk ?? newTown;
-    data.countryFk = newTown?.province?.countryFk ?? newTown;
-}
-
 async function setCountry(countryFk, data) {
     data.townFk = null;
     data.provinceFk = null;
     data.countryFk = countryFk;
+    await fetchTowns();
 }
 
+// Province
+
 async function handleProvinces(data) {
     provincesOptions.value = data;
-    // handleTowns(data);
-}
-async function handleTowns(data) {
-    townsOptions.value = data;
-    // whereTowns.value.provinceFk.inq = mapData(data);
-    // townsRef.value.opts = [];
-}
-
-async function setProvince(id, data) {
-    const newProvince = findProvince(id);
-    if (!newProvince) {
-        data.townFk = null;
-        return;
+    if (postcodeFormData.countryFk) {
+        await fetchTowns();
     }
-    whereTowns.value.provinceFk.inq = [id];
-    // handleTowns([newProvince]);
-    data.countryFk = newProvince.countryFk;
 }
-
+async function setProvince(id, data) {
+    if (data.provinceFk === id) return;
+    const newProvince = provincesOptions.value.find((province) => province.id == id);
+    if (newProvince) data.countryFk = newProvince.countryFk;
+    postcodeFormData.provinceFk = id;
+    await fetchTowns();
+}
 async function onProvinceCreated(data) {
     await provincesFetchDataRef.value.fetch({
         where: { countryFk: postcodeFormData.countryFk },
     });
     postcodeFormData.provinceFk = data.id;
 }
+function provinceByCountry(countryFk = postcodeFormData.countryFk) {
+    return provincesOptions.value
+        .filter((province) => province.countryFk === countryFk)
+        .map(({ id }) => id);
+}
 
-const whereTowns = ref({});
-// const whereTowns = ref(() => {
-//     if (!postcodeFormData.provinceFk) return { provinceFk: { inq: null } };
-//     if (postcodeFormData.provinceFk)
-//         return {
-//             provinceFk: {
-//                 inq: [postcodeFormData.provinceFk], //provincesOptions.value.map(({ id }) => id),
-//             },
-//         };
+// Town
+async function handleTowns(data) {
+    townsOptions.value = data;
+}
+function setTown(newTown, data) {
+    town.value = newTown;
+    data.provinceFk = newTown?.provinceFk ?? newTown;
+    data.countryFk = newTown?.province?.countryFk ?? newTown;
+}
+async function onCityCreated(newTown, formData) {
+    await provincesFetchDataRef.value.fetch();
+    newTown.province = provincesOptions.value.find(
+        (province) => province.id === newTown.provinceFk
+    );
+    formData.townFk = newTown;
+    setTown(newTown, formData);
+}
+async function fetchTowns(countryFk = postcodeFormData.countryFk) {
+    if (!countryFk) return;
+    const provinces = postcodeFormData.provinceFk
+        ? [postcodeFormData.provinceFk]
+        : provinceByCountry();
+    townFilter.value.where = {
+        provinceFk: {
+            inq: provinces,
+        },
+    };
+    await townsFetchDataRef.value?.fetch();
+}
 
-//     return {
-//         provinceFk: {
-//             inq: mapData(provincesOptions.value),
-//         },
-//     };
-// });
-function mapData(data) {
-    if (data.length === 0) return data;
-    return data.map(({ id }) => id);
+async function filterTowns(name) {
+    if (name !== '') {
+        townFilter.value.where = {
+            name: {
+                like: `%${name}%`,
+            },
+        };
+        await townsFetchDataRef.value?.fetch();
+    }
 }
 </script>
 
@@ -128,12 +134,12 @@ function mapData(data) {
         url="Provinces/location"
     />
     <FetchData
-        ref="townsRef"
-        @on-fetch="handleTowns"
+        ref="townsFetchDataRef"
         :sort-by="['name ASC']"
-        :limit="2"
+        :limit="30"
+        :filter="townFilter"
+        @on-fetch="handleTowns"
         auto-load
-        :where="whereTowns"
         url="Towns/location"
     />
 
@@ -155,21 +161,23 @@ function mapData(data) {
                     :rules="validate('postcode.code')"
                     clearable
                     required
+                    data-cy="locationPostcode"
                 />
                 <VnSelectDialog
                     :label="t('City')"
                     @update:model-value="(value) => setTown(value, data)"
+                    @filter="filterTowns"
                     :tooltip="t('Create city')"
                     v-model="data.townFk"
-                    option-label="name"
                     :options="townsOptions"
+                    option-label="name"
                     option-value="id"
                     @input-value="(evt) => (whereTowns.name = { like: `%${evt}%` })"
                     :rules="validate('postcode.city')"
                     :acls="[{ model: 'Town', props: '*', accessType: 'WRITE' }]"
                     :emit-value="false"
-                    :clearable="true"
                     required
+                    data-cy="locationTown"
                 >
                     <template #option="{ itemProps, opt }">
                         <QItem v-bind="itemProps">
@@ -200,7 +208,6 @@ function mapData(data) {
                     :province-selected="data.provinceFk"
                     @update:model-value="(value) => setProvince(value, data)"
                     v-model="data.provinceFk"
-                    @on-province-fetched="handleProvinces"
                     @on-province-created="onProvinceCreated"
                     required
                 />
@@ -219,6 +226,7 @@ function mapData(data) {
                     v-model="data.countryFk"
                     :rules="validate('postcode.countryFk')"
                     @update:model-value="(value) => setCountry(value, data)"
+                    data-cy="locationCountry"
                 />
             </VnRow>
         </template>
diff --git a/src/components/VnSelectProvince.vue b/src/components/VnSelectProvince.vue
index bfc4ab7b7..7d1297abf 100644
--- a/src/components/VnSelectProvince.vue
+++ b/src/components/VnSelectProvince.vue
@@ -64,11 +64,11 @@ watch(
         auto-load
     />
     <VnSelectDialog
+        data-cy="locationProvince"
         :label="t('Province')"
         :options="provincesOptions"
         :tooltip="t('Create province')"
         hide-selected
-        :clearable="true"
         v-model="provinceFk"
         :rules="validate && validate('postcode.provinceFk')"
         :acls="[{ model: 'Province', props: '*', accessType: 'WRITE' }]"
diff --git a/src/components/common/VnLocation.vue b/src/components/common/VnLocation.vue
index 6de402a26..af273150e 100644
--- a/src/components/common/VnLocation.vue
+++ b/src/components/common/VnLocation.vue
@@ -75,7 +75,6 @@ const handleModelValue = (data) => {
         :input-debounce="300"
         :class="{ required: isRequired }"
         v-bind="$attrs"
-        clearable
         :emit-value="false"
         :tooltip="t('Create new location')"
         :rules="mixinRules"
diff --git a/test/cypress/integration/vnComponent/VnLocation.spec.js b/test/cypress/integration/vnComponent/VnLocation.spec.js
index b98d42fdd..1fea8f738 100644
--- a/test/cypress/integration/vnComponent/VnLocation.spec.js
+++ b/test/cypress/integration/vnComponent/VnLocation.spec.js
@@ -43,11 +43,9 @@ describe('VnLocation', () => {
                 province
             );
             cy.get(
-                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(3) > .q-icon`
+                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(3) `
             ).click();
-            cy.get(
-                `#q-portal--dialog--5 > .q-dialog > ${createForm.prefix} > .vn-row > .q-select > ${createForm.sufix} > :nth-child(1) input`
-            ).should('have.value', province);
+            cy.dataCy('locationProvince').should('have.value', province);
         });
     });
     describe('Worker Create', () => {
@@ -124,17 +122,18 @@ describe('VnLocation', () => {
             cy.get(createLocationButton).click();
             cy.get(dialogInputs).eq(0).type(postCode);
             cy.get(
-                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2) > .q-icon`
+                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2) `
             ).click();
             cy.selectOption('#q-portal--dialog--3 .q-select', 'one');
             cy.get('#q-portal--dialog--3 .q-input').type(province);
-            cy.get('#q-portal--dialog--3 .q-btn--standard').click();
-            cy.get('#q-portal--dialog--1 .q-btn--standard').click();
+            cy.dataCy('FormModelPopup_save').eq(1).click();
+            cy.dataCy('FormModelPopup_save').eq(0).click();
+
             cy.waitForElement('.q-form');
             checkVnLocation(postCode, province);
         });
 
-        it('Create province without country', () => {
+        it.only('Create province without country', () => {
             const provinceName = 'Saskatchew'.concat(Math.random(1 * 100));
             cy.get(createLocationButton).click();
             cy.get(
@@ -146,7 +145,7 @@ describe('VnLocation', () => {
             cy.countSelectOptions('#q-portal--dialog--3 .q-select', 4);
             cy.get('#q-portal--dialog--3 .q-input').type(provinceName);
 
-            cy.get('#q-portal--dialog--3 .q-btn--standard').click();
+            cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 
         it('Create city with country', () => {
@@ -157,13 +156,13 @@ describe('VnLocation', () => {
                 'Italia'
             );
             cy.get(
-                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2) > .q-icon`
+                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2)  `
             ).click();
             cy.selectOption('#q-portal--dialog--4 .q-select', 'Province four');
             cy.countSelectOptions('#q-portal--dialog--4 .q-select', 1);
 
             cy.get('#q-portal--dialog--4 .q-input').type(cityName);
-            cy.get('#q-portal--dialog--4 .q-btn--standard').click();
+            cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 
         it('Create province with country', () => {
@@ -183,7 +182,7 @@ describe('VnLocation', () => {
             cy.countSelectOptions('#q-portal--dialog--4 .q-select', 2);
 
             cy.get('#q-portal--dialog--4 .q-input').type(provinceName);
-            cy.get('#q-portal--dialog--4 .q-btn--standard').click();
+            cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 
         function checkVnLocation(postCode, province) {

From 007b95a616b1519a4876034e11a6c6460de3efa2 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 2 Dec 2024 00:50:31 +0100
Subject: [PATCH 3/4] test: remove #q-

---
 src/components/CreateNewCityForm.vue          |  2 +
 src/components/CreateNewPostcodeForm.vue      |  6 +--
 src/components/CreateNewProvinceForm.vue      |  2 +
 .../vnComponent/VnLocation.spec.js            | 50 +++++++++----------
 4 files changed, 31 insertions(+), 29 deletions(-)

diff --git a/src/components/CreateNewCityForm.vue b/src/components/CreateNewCityForm.vue
index 1cbba42fc..9ab942dda 100644
--- a/src/components/CreateNewCityForm.vue
+++ b/src/components/CreateNewCityForm.vue
@@ -48,12 +48,14 @@ const onDataSaved = (...args) => {
                     v-model="data.name"
                     :rules="validate('city.name')"
                     required
+                    data-cy="cityName"
                 />
                 <VnSelectProvince
                     :province-selected="$props.provinceSelected"
                     :country-fk="$props.countryFk"
                     v-model="data.provinceFk"
                     required
+                    data-cy="provinceCity"
                 />
             </VnRow>
         </template>
diff --git a/src/components/CreateNewPostcodeForm.vue b/src/components/CreateNewPostcodeForm.vue
index 8000aac52..d3d6708f0 100644
--- a/src/components/CreateNewPostcodeForm.vue
+++ b/src/components/CreateNewPostcodeForm.vue
@@ -129,7 +129,7 @@ async function filterTowns(name) {
         ref="provincesFetchDataRef"
         @on-fetch="handleProvinces"
         :sort-by="['name ASC']"
-        :limit="2"
+        :limit="30"
         auto-load
         url="Provinces/location"
     />
@@ -153,7 +153,6 @@ async function filterTowns(name) {
         @on-data-saved="onDataSaved"
     >
         <template #form-inputs="{ data, validate }">
-            {{ whereTowns }}
             <VnRow>
                 <VnInput
                     :label="t('Postcode')"
@@ -172,7 +171,6 @@ async function filterTowns(name) {
                     :options="townsOptions"
                     option-label="name"
                     option-value="id"
-                    @input-value="(evt) => (whereTowns.name = { like: `%${evt}%` })"
                     :rules="validate('postcode.city')"
                     :acls="[{ model: 'Town', props: '*', accessType: 'WRITE' }]"
                     :emit-value="false"
@@ -213,7 +211,7 @@ async function filterTowns(name) {
                 />
                 <VnSelect
                     ref="countriesRef"
-                    :limit="2"
+                    :limit="30"
                     :filter="countryFilter"
                     :sort-by="['name ASC']"
                     auto-load
diff --git a/src/components/CreateNewProvinceForm.vue b/src/components/CreateNewProvinceForm.vue
index 887ca957c..d35690eeb 100644
--- a/src/components/CreateNewProvinceForm.vue
+++ b/src/components/CreateNewProvinceForm.vue
@@ -53,8 +53,10 @@ const where = computed(() => {
                     v-model="data.name"
                     :rules="validate('province.name')"
                     required
+                    data-cy="provinceName"
                 />
                 <VnSelect
+                    data-cy="autonomyProvince"
                     required
                     ref="autonomiesRef"
                     auto-load
diff --git a/test/cypress/integration/vnComponent/VnLocation.spec.js b/test/cypress/integration/vnComponent/VnLocation.spec.js
index 1fea8f738..eab5d63b9 100644
--- a/test/cypress/integration/vnComponent/VnLocation.spec.js
+++ b/test/cypress/integration/vnComponent/VnLocation.spec.js
@@ -116,7 +116,7 @@ describe('VnLocation', () => {
             checkVnLocation(postCode, province);
         });
 
-        it('Create city without country', () => {
+        it.only('Create city without country', () => {
             const postCode = randomNumber();
             const province = randomString({ length: 4 });
             cy.get(createLocationButton).click();
@@ -124,8 +124,8 @@ describe('VnLocation', () => {
             cy.get(
                 `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2) `
             ).click();
-            cy.selectOption('#q-portal--dialog--3 .q-select', 'one');
-            cy.get('#q-portal--dialog--3 .q-input').type(province);
+            cy.selectOption('[data-cy="locationProvince"]:last', 'Province one');
+            cy.get('[data-cy="cityName"]').type(province);
             cy.dataCy('FormModelPopup_save').eq(1).click();
             cy.dataCy('FormModelPopup_save').eq(0).click();
 
@@ -133,22 +133,7 @@ describe('VnLocation', () => {
             checkVnLocation(postCode, province);
         });
 
-        it.only('Create province without country', () => {
-            const provinceName = 'Saskatchew'.concat(Math.random(1 * 100));
-            cy.get(createLocationButton).click();
-            cy.get(
-                `${createForm.prefix} > :nth-child(5) > .q-select > ${createForm.sufix} > :nth-child(2) `
-            )
-                .eq(0)
-                .click();
-            cy.selectOption('#q-portal--dialog--3 .q-select', 'one');
-            cy.countSelectOptions('#q-portal--dialog--3 .q-select', 4);
-            cy.get('#q-portal--dialog--3 .q-input').type(provinceName);
-
-            cy.dataCy('FormModelPopup_save').eq(1).click();
-        });
-
-        it('Create city with country', () => {
+        it.only('Create city with country', () => {
             const cityName = 'Saskatchew'.concat(Math.random(1 * 100));
             cy.get(createLocationButton).click();
             cy.selectOption(
@@ -158,10 +143,25 @@ describe('VnLocation', () => {
             cy.get(
                 `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2)  `
             ).click();
-            cy.selectOption('#q-portal--dialog--4 .q-select', 'Province four');
-            cy.countSelectOptions('#q-portal--dialog--4 .q-select', 1);
+            cy.selectOption('[data-cy="locationProvince"]:last', 'Province four');
+            cy.countSelectOptions('[data-cy="locationProvince"]:last', 1);
+
+            cy.get('[data-cy="cityName"]').type(cityName);
+            cy.dataCy('FormModelPopup_save').eq(1).click();
+        });
+
+        it('Create province without country', () => {
+            const provinceName = 'Saskatchew'.concat(Math.random(1 * 100));
+            cy.get(createLocationButton).click();
+            cy.get(
+                `${createForm.prefix} > :nth-child(5) > .q-select > ${createForm.sufix} > :nth-child(2) `
+            )
+                .eq(0)
+                .click();
+            cy.selectOption('[data-cy="autonomyProvince"] ', 'Autonomy one');
+            cy.countSelectOptions('[data-cy="autonomyProvince"]', 4);
+            cy.get('[data-cy="provinceName"]').type(provinceName);
 
-            cy.get('#q-portal--dialog--4 .q-input').type(cityName);
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 
@@ -178,10 +178,10 @@ describe('VnLocation', () => {
                 .eq(0)
                 .click();
 
-            cy.selectOption('#q-portal--dialog--4 .q-select', 'one');
-            cy.countSelectOptions('#q-portal--dialog--4 .q-select', 2);
+            cy.selectOption('[data-cy="autonomyProvince"] ', 'Autonomy one');
+            cy.countSelectOptions('[data-cy="autonomyProvince"]', 2);
 
-            cy.get('#q-portal--dialog--4 .q-input').type(provinceName);
+            cy.get('[data-cy="provinceName"]').type(provinceName);
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 

From 21dc47ed7479c50eaa847ff1bbdf79dd781a94b0 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 2 Dec 2024 01:25:42 +0100
Subject: [PATCH 4/4] perf: add dataCy

---
 src/components/CreateNewCityForm.vue          |  1 +
 src/components/common/VnSelectDialog.vue      |  1 +
 .../vnComponent/VnLocation.spec.js            | 32 ++++++-------------
 3 files changed, 12 insertions(+), 22 deletions(-)

diff --git a/src/components/CreateNewCityForm.vue b/src/components/CreateNewCityForm.vue
index 9ab942dda..bf3830522 100644
--- a/src/components/CreateNewCityForm.vue
+++ b/src/components/CreateNewCityForm.vue
@@ -40,6 +40,7 @@ const onDataSaved = (...args) => {
         url-create="towns"
         model="city"
         @on-data-saved="onDataSaved"
+        data-cy="newCityForm"
     >
         <template #form-inputs="{ data, validate }">
             <VnRow>
diff --git a/src/components/common/VnSelectDialog.vue b/src/components/common/VnSelectDialog.vue
index 350aa9272..12322c3fa 100644
--- a/src/components/common/VnSelectDialog.vue
+++ b/src/components/common/VnSelectDialog.vue
@@ -43,6 +43,7 @@ const isAllowedToCreate = computed(() => {
     >
         <template v-if="isAllowedToCreate" #append>
             <QIcon
+                :data-cy="$attrs.dataCy ?? $attrs.label + '_icon'"
                 @click.stop.prevent="$refs.dialog.show()"
                 :name="actionIcon"
                 :size="actionIcon === 'add' ? 'xs' : 'sm'"
diff --git a/test/cypress/integration/vnComponent/VnLocation.spec.js b/test/cypress/integration/vnComponent/VnLocation.spec.js
index eab5d63b9..82d12a1e4 100644
--- a/test/cypress/integration/vnComponent/VnLocation.spec.js
+++ b/test/cypress/integration/vnComponent/VnLocation.spec.js
@@ -116,16 +116,14 @@ describe('VnLocation', () => {
             checkVnLocation(postCode, province);
         });
 
-        it.only('Create city without country', () => {
+        it('Create city without country', () => {
             const postCode = randomNumber();
             const province = randomString({ length: 4 });
             cy.get(createLocationButton).click();
             cy.get(dialogInputs).eq(0).type(postCode);
-            cy.get(
-                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2) `
-            ).click();
+            cy.dataCy('City_icon').click();
             cy.selectOption('[data-cy="locationProvince"]:last', 'Province one');
-            cy.get('[data-cy="cityName"]').type(province);
+            cy.dataCy('cityName').type(province);
             cy.dataCy('FormModelPopup_save').eq(1).click();
             cy.dataCy('FormModelPopup_save').eq(0).click();
 
@@ -133,34 +131,28 @@ describe('VnLocation', () => {
             checkVnLocation(postCode, province);
         });
 
-        it.only('Create city with country', () => {
+        it('Create city with country', () => {
             const cityName = 'Saskatchew'.concat(Math.random(1 * 100));
             cy.get(createLocationButton).click();
             cy.selectOption(
                 `${createForm.prefix} > :nth-child(5) > :nth-child(3) `,
                 'Italia'
             );
-            cy.get(
-                `${createForm.prefix} > :nth-child(4) > .q-select > ${createForm.sufix} > :nth-child(2)  `
-            ).click();
+            cy.dataCy('City_icon').click();
             cy.selectOption('[data-cy="locationProvince"]:last', 'Province four');
             cy.countSelectOptions('[data-cy="locationProvince"]:last', 1);
 
-            cy.get('[data-cy="cityName"]').type(cityName);
+            cy.dataCy('cityName').type(cityName);
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });
 
         it('Create province without country', () => {
             const provinceName = 'Saskatchew'.concat(Math.random(1 * 100));
             cy.get(createLocationButton).click();
-            cy.get(
-                `${createForm.prefix} > :nth-child(5) > .q-select > ${createForm.sufix} > :nth-child(2) `
-            )
-                .eq(0)
-                .click();
+            cy.dataCy('Province_icon').click();
             cy.selectOption('[data-cy="autonomyProvince"] ', 'Autonomy one');
             cy.countSelectOptions('[data-cy="autonomyProvince"]', 4);
-            cy.get('[data-cy="provinceName"]').type(provinceName);
+            cy.dataCy('provinceName').type(provinceName);
 
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });
@@ -172,16 +164,12 @@ describe('VnLocation', () => {
                 `${createForm.prefix} > :nth-child(5) > :nth-child(3) `,
                 'España'
             );
-            cy.get(
-                `${createForm.prefix} > :nth-child(5) > .q-select > ${createForm.sufix} > :nth-child(2) `
-            )
-                .eq(0)
-                .click();
+            cy.dataCy('Province_icon').click();
 
             cy.selectOption('[data-cy="autonomyProvince"] ', 'Autonomy one');
             cy.countSelectOptions('[data-cy="autonomyProvince"]', 2);
 
-            cy.get('[data-cy="provinceName"]').type(provinceName);
+            cy.dataCy('provinceName').type(provinceName);
             cy.dataCy('FormModelPopup_save').eq(1).click();
         });