From bdb35e24ee93ed292289357b73ed2906eb95e594 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Tue, 4 Feb 2025 23:44:49 +0100
Subject: [PATCH] perf: refs #6321 minor changes

---
 src/components/ui/VnStockValueDisplay.vue     |  4 +-
 src/pages/Item/components/ItemProposal.vue    | 54 +++++++------------
 .../Item/components/ItemProposalProxy.vue     |  9 +++-
 3 files changed, 30 insertions(+), 37 deletions(-)

diff --git a/src/components/ui/VnStockValueDisplay.vue b/src/components/ui/VnStockValueDisplay.vue
index 8021769d9..8bdb921a0 100644
--- a/src/components/ui/VnStockValueDisplay.vue
+++ b/src/components/ui/VnStockValueDisplay.vue
@@ -1,4 +1,6 @@
 <script setup>
+import { toPercentage } from 'filters/index';
+
 import { computed } from 'vue';
 
 const props = defineProps({
@@ -19,7 +21,7 @@ const formattedValue = computed(() => props.value);
 <template>
     <span :class="valueClass">
         <QIcon :name="iconName" size="sm" class="value-icon" />
-        {{ formattedValue }}
+        {{ toPercentage(formattedValue) }}
     </span>
 </template>
 
diff --git a/src/pages/Item/components/ItemProposal.vue b/src/pages/Item/components/ItemProposal.vue
index 8dc74fb91..9bcdf3bdf 100644
--- a/src/pages/Item/components/ItemProposal.vue
+++ b/src/pages/Item/components/ItemProposal.vue
@@ -130,6 +130,20 @@ const columns = computed(() => [
         name: 'located',
         field: 'located',
     },
+    {
+        align: 'right',
+        label: '',
+        name: 'tableActions',
+        actions: [
+            {
+                title: t('Replace'),
+                icon: 'change_circle',
+                show: (row) => isSelectionAvailable(row),
+                action: change,
+                isPrimary: true,
+            },
+        ],
+    },
 ]);
 
 const extractNumericValue = (percentageString) => {
@@ -164,20 +178,8 @@ const emit = defineEmits(['onDialogClosed', 'itemReplaced']);
 
 const conditionalValuePrice = (price) => (price > 1.3 ? 'match' : 'not-match');
 
-const isSelected = (row) =>
-    proposalSelected.value.some((item) => row.itemFk === item.itemFk);
-
-function change(row) {
-    if (isSelected(row)) {
-        confirm(row);
-        proposalSelected.value = [];
-    }
-    proposalSelected.value = [row];
-}
-
-async function confirm() {
+async function change({ itemFk: substitutionFk }) {
     try {
-        const substitutionFk = proposalSelected.value[0].itemFk;
         const promises = $props.sales.map(({ saleFk, quantity }) => {
             const params = {
                 saleFk,
@@ -223,6 +225,7 @@ const isSelectionAvailable = (itemProposal) => {
         :columns="columns"
         class="full-width q-mt-md"
         row-key="id"
+        :row-click="change"
         :is-editable="false"
         :right-search="false"
         :without-header="true"
@@ -236,23 +239,7 @@ const isSelectionAvailable = (itemProposal) => {
                 <QTooltip>
                     {{ row.id }}
                 </QTooltip>
-                <QBtn
-                    data-cy="replaceBtn"
-                    icon="change_circle"
-                    color="primary"
-                    flat
-                    dense
-                    :class="{
-                        'fill-icon': isSelected(row),
-                    }"
-                    @click="change(row)"
-                    :disable="!isSelectionAvailable(row)"
-                >
-                    <QTooltip v-if="!isSelected(row)">
-                        {{ t('Select to replace') }}</QTooltip
-                    >
-                    <QTooltip v-else> {{ t('Selected to replace') }}</QTooltip>
-                </QBtn>
+
                 <div
                     class="middle compatibility"
                     :style="{
@@ -294,15 +281,14 @@ const isSelectionAvailable = (itemProposal) => {
         </template>
         <template #column-price2="{ row }">
             <div class="flex column items-center content-center">
-                <VnStockValueDisplay :value="sales[0].price - row.price2" />
+                {{ toCurrency(sales[0].price) }}
+                {{ toCurrency(row.price2) }}
+                <VnStockValueDisplay :value="(sales[0].price - row.price2) / 100" />
                 <span :class="[conditionalValuePrice(row.price2)]">{{
                     toCurrency(row.price2)
                 }}</span>
             </div>
         </template>
-        <template #column-difference="{ row }">
-            <VnStockValueDisplay :value="sales[0].price - row.price2" />
-        </template>
     </VnTable>
 </template>
 <style lang="scss" scoped>
diff --git a/src/pages/Item/components/ItemProposalProxy.vue b/src/pages/Item/components/ItemProposalProxy.vue
index 33c4dac1c..7da0ce398 100644
--- a/src/pages/Item/components/ItemProposalProxy.vue
+++ b/src/pages/Item/components/ItemProposalProxy.vue
@@ -28,8 +28,8 @@ const emit = defineEmits([
 defineExpose({ show: () => dialogRef.value.show(), hide: () => dialogRef.value.hide() });
 </script>
 <template>
-    <QDialog ref="dialogRef" full-width transition-show="scale" transition-hide="scale">
-        <QCard>
+    <QDialog ref="dialogRef" transition-show="scale" transition-hide="scale">
+        <QCard class="dialog-width">
             <QCardSection class="row items-center q-pb-none">
                 <span class="text-h6 text-grey">{{ $t('Item proposal') }}</span>
                 <QSpace />
@@ -49,3 +49,8 @@ defineExpose({ show: () => dialogRef.value.show(), hide: () => dialogRef.value.h
         </QCard>
     </QDialog>
 </template>
+<style lang="scss" scoped>
+.dialog-width {
+    max-width: $width-lg;
+}
+</style>