From c5284e54c78bebd06f87544c640bce76b0f8de0f Mon Sep 17 00:00:00 2001
From: jtubau <jtubau@verdnatura.es>
Date: Wed, 5 Mar 2025 11:13:45 +0100
Subject: [PATCH] refactor: refs #8422 enhance DMS import functionality and
 improve localization

---
 src/components/common/VnDmsList.vue                 |  6 ++----
 .../Route/Vehicle/Card/VehicleDmsImportForm.vue     | 13 +++----------
 src/pages/Route/Vehicle/VehicleDms.vue              | 10 +++-------
 src/pages/Route/Vehicle/locale/en.yml               |  6 ++++++
 src/pages/Route/Vehicle/locale/es.yml               |  6 ++++++
 5 files changed, 20 insertions(+), 21 deletions(-)

diff --git a/src/components/common/VnDmsList.vue b/src/components/common/VnDmsList.vue
index 424781a26..facb667ba 100644
--- a/src/components/common/VnDmsList.vue
+++ b/src/components/common/VnDmsList.vue
@@ -389,10 +389,7 @@ defineExpose({
                     </div>
                 </template>
             </QTable>
-            <div 
-                v-else 
-                class="info-row q-pa-md text-center"
-            >
+            <div v-else class="info-row q-pa-md text-center">
                 <h5>
                     {{ t('No data to display') }}
                 </h5>
@@ -416,6 +413,7 @@ defineExpose({
             v-shortcut
             @click="showFormDialog()"
             class="fill-icon"
+            data-cy="addDmsBtn"
         >
             <QTooltip>
                 {{ t('Upload file') }}
diff --git a/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue b/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue
index 1d17a38dc..5b2797740 100644
--- a/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue
+++ b/src/pages/Route/Vehicle/Card/VehicleDmsImportForm.vue
@@ -22,7 +22,7 @@ const dmsId = ref(null);
 
 const importDms = async () => {
     try {
-        if (!dmsId.value) throw new Error(t(`The document identifier can't be empty`));
+        if (!dmsId.value) throw new Error(t(`vehicle.error.documentIdEmpty`));
 
         const data = {
             vehicleFk: route.params.id,
@@ -49,14 +49,14 @@ const importDms = async () => {
     <FormModelPopup
         url-create="genera"
         model="DmsImport"
-        :title="t('Select document id')"
+        :title="t('vehicle.dms.selectDocId')"
         :form-initial-data="{}"
         :save-fn="importDms"
     >
         <template #form-inputs>
             <VnRow>
                 <VnSelect
-                    :label="t('Document')"
+                    :label="t('vehicle.dms.document')"
                     :options="dmsOptions"
                     hide-selected
                     option-label="id"
@@ -67,10 +67,3 @@ const importDms = async () => {
         </template>
     </FormModelPopup>
 </template>
-
-<i18n>
-es:
-    Select document id: Introduzca id de gestion documental
-    Document: Documento
-    The document indentifier can't be empty: El número de documento no puede estar vacío
-</i18n>
diff --git a/src/pages/Route/Vehicle/VehicleDms.vue b/src/pages/Route/Vehicle/VehicleDms.vue
index f10575247..c871877c2 100644
--- a/src/pages/Route/Vehicle/VehicleDms.vue
+++ b/src/pages/Route/Vehicle/VehicleDms.vue
@@ -20,7 +20,7 @@ const onDataSaved = () => dmsListRef.value.dmsRef.fetch();
         delete-model="VehicleDms"
         download-model="dms"
         default-dms-code="vehicles"
-        filter="vehicleFk"        
+        filter="vehicleFk"
     />
     <QDialog v-model="showImportDialog">
         <VehicleDmsImportForm @on-data-saved="onDataSaved()" />
@@ -32,15 +32,11 @@ const onDataSaved = () => dmsListRef.value.dmsRef.fetch();
             icon="file_copy"
             @click="showImportDialog = true"
             class="fill-icon"
+            data-cy="importBtn"
         >
             <QTooltip>
-                {{ t('Import from existing') }}
+                {{ t('vehicle.dms.import') }}
             </QTooltip>
         </QBtn>
     </QPageSticky>
 </template>
-
-<i18n>
-es:
-    Import from existing: Importar desde existente
-</i18n>
diff --git a/src/pages/Route/Vehicle/locale/en.yml b/src/pages/Route/Vehicle/locale/en.yml
index c92022f9d..00ef5eae9 100644
--- a/src/pages/Route/Vehicle/locale/en.yml
+++ b/src/pages/Route/Vehicle/locale/en.yml
@@ -18,3 +18,9 @@ vehicle:
     params:
         vehicleTypeFk: Type
         vehicleStateFk: State
+    dms:
+        import: Import from existing
+        selectDocId: Select document id
+        document: Document
+    error:
+        documentIdEmpty: The document identifier can't be empty
diff --git a/src/pages/Route/Vehicle/locale/es.yml b/src/pages/Route/Vehicle/locale/es.yml
index c878f97ac..ea7ff4718 100644
--- a/src/pages/Route/Vehicle/locale/es.yml
+++ b/src/pages/Route/Vehicle/locale/es.yml
@@ -18,3 +18,9 @@ vehicle:
     params:
         vehicleTypeFk: Tipo
         vehicleStateFk: Estado
+    dms:
+        import: Importar desde existente
+        selectDocId: Introduzca id de gestion documental
+        document: Documento
+    error:
+        documentIdEmpty: El número de documento no puede estar vacío