From 9ee69274ae794f88350d3f71619fbcb111a728cf Mon Sep 17 00:00:00 2001
From: jon <jon@verdnatura.es>
Date: Wed, 7 May 2025 12:28:05 +0200
Subject: [PATCH 1/6] fix: make 0 become valid in VnInputNumber when using
 required from validator

---
 src/composables/useValidator.js               |  4 +++-
 .../customer/clientCredits.spec.js            | 22 ++++++++++++++++++-
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/composables/useValidator.js b/src/composables/useValidator.js
index ae6c47d91..e887c0c4f 100644
--- a/src/composables/useValidator.js
+++ b/src/composables/useValidator.js
@@ -47,7 +47,9 @@ export function useValidator() {
                 return !validator.isEmpty(value ? String(value) : '') || message;
             },
             required: (required, value) => {
-                return required ? !!value || t('globals.fieldRequired') : null;
+                return required
+                    ? value === 0 || !!value || t('globals.fieldRequired')
+                    : null;
             },
             length: (value) => {
                 const options = {
diff --git a/test/cypress/integration/customer/clientCredits.spec.js b/test/cypress/integration/customer/clientCredits.spec.js
index 5f303b40d..f39f3c06c 100644
--- a/test/cypress/integration/customer/clientCredits.spec.js
+++ b/test/cypress/integration/customer/clientCredits.spec.js
@@ -7,7 +7,27 @@ describe('Client credits', () => {
             timeout: 5000,
         });
     });
-    it('Should load layout', () => {
+
+    it('Should put a new credit', () => {
         cy.get('.q-page').should('be.visible');
+        cy.dataCy('vnTableCreateBtn').click();
+        cy.dataCy('Credit_input').type('100');
+        cy.dataCy('FormModelPopup_save').click();
+        cy.checkNotification('Data saved');
+    });
+
+    it('Should put a new credit with value 0 to close the client card', () => {
+        cy.get('.q-page').should('be.visible');
+        cy.dataCy('vnTableCreateBtn').click();
+        cy.dataCy('Credit_input').type('0');
+        cy.dataCy('FormModelPopup_save').click();
+        cy.checkNotification('Data saved');
+    });
+
+    it('Should not create the credit if there is no value in the input', () => {
+        cy.get('.q-page').should('be.visible');
+        cy.dataCy('vnTableCreateBtn').click();
+        cy.dataCy('FormModelPopup_save').click();
+        cy.get('.q-notification__message').should('not.exist');
     });
 });

From 85e932a6b96ab0dd025b55102c04a6bc4b05fffb Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 12 May 2025 10:19:48 +0200
Subject: [PATCH 2/6] fix: add required validation depends on verified data
 checkbox

---
 .../Customer/Card/CustomerFiscalData.vue      | 37 +++++++---
 .../customer/clientFiscalData.spec.js         | 74 +++++++++++--------
 2 files changed, 72 insertions(+), 39 deletions(-)

diff --git a/src/pages/Customer/Card/CustomerFiscalData.vue b/src/pages/Customer/Card/CustomerFiscalData.vue
index b45df2e0f..fbb155cd3 100644
--- a/src/pages/Customer/Card/CustomerFiscalData.vue
+++ b/src/pages/Customer/Card/CustomerFiscalData.vue
@@ -62,6 +62,15 @@ async function acceptPropagate({ isEqualizated }) {
     });
     notify(t('Equivalent tax spreaded'), 'warning');
 }
+const isTaxDataChecked = ref(false);
+
+function isRequired({ isTaxDataChecked: taxDataChecked }) {
+    if (!isTaxDataChecked.value) {
+        return false;
+    } else {
+        return taxDataChecked;
+    }
+}
 </script>
 
 <template>
@@ -111,21 +120,27 @@ async function acceptPropagate({ isEqualizated }) {
             <VnRow>
                 <VnSelect
                     :label="t('Sage tax type')"
-                    :options="typesTaxes"
+                    url="SageTaxTypes"
                     hide-selected
                     option-label="vat"
                     option-value="id"
                     v-model="data.sageTaxTypeFk"
                     data-cy="sageTaxTypeFk"
+                    :required="isRequired(data)"
+                    :rules="[(val) => validations.required(data.sageTaxTypeFk, val)]"
                 />
                 <VnSelect
                     :label="t('Sage transaction type')"
-                    :options="typesTransactions"
+                    url="SageTransactionTypes"
                     hide-selected
                     option-label="transaction"
                     option-value="id"
                     data-cy="sageTransactionTypeFk"
                     v-model="data.sageTransactionTypeFk"
+                    :required="isRequired(data)"
+                    :rules="[
+                        (val) => validations.required(data.sageTransactionTypeFk, val),
+                    ]"
                 >
                     <template #option="scope">
                         <QItem v-bind="scope.itemProps">
@@ -151,11 +166,11 @@ async function acceptPropagate({ isEqualizated }) {
                 />
             </VnRow>
             <VnRow>
-                <QCheckbox :label="t('Active')" v-model="data.isActive" />
-                <QCheckbox :label="t('Frozen')" v-model="data.isFreezed" />
+                <VnCheckbox :label="t('Active')" v-model="data.isActive" />
+                <VnCheckbox :label="t('Frozen')" v-model="data.isFreezed" />
             </VnRow>
             <VnRow>
-                <QCheckbox :label="t('Has to invoice')" v-model="data.hasToInvoice" />
+                <VnCheckbox :label="t('Has to invoice')" v-model="data.hasToInvoice" />
                 <VnCheckbox
                     v-model="data.isVies"
                     :label="t('globals.isVies')"
@@ -164,8 +179,8 @@ async function acceptPropagate({ isEqualizated }) {
             </VnRow>
 
             <VnRow>
-                <QCheckbox :label="t('Notify by email')" v-model="data.isToBeMailed" />
-                <QCheckbox
+                <VnCheckbox :label="t('Notify by email')" v-model="data.isToBeMailed" />
+                <VnCheckbox
                     :label="t('Invoice by address')"
                     v-model="data.hasToInvoiceByAddress"
                 />
@@ -177,16 +192,18 @@ async function acceptPropagate({ isEqualizated }) {
                     :label="t('Is equalizated')"
                     :info="t('inOrderToInvoice')"
                 />
-                <QCheckbox :label="t('Daily invoice')" v-model="data.hasDailyInvoice" />
+                <VnCheckbox :label="t('Daily invoice')" v-model="data.hasDailyInvoice" />
             </VnRow>
 
             <VnRow>
-                <QCheckbox
+                <VnCheckbox
                     :label="t('Electronic invoice')"
                     v-model="data.hasElectronicInvoice"
-                /><QCheckbox
+                />
+                <VnCheckbox
                     :label="t('Verified data')"
                     v-model="data.isTaxDataChecked"
+                    @update:model-value="isTaxDataChecked = !isTaxDataChecked"
                 />
             </VnRow>
         </template>
diff --git a/test/cypress/integration/customer/clientFiscalData.spec.js b/test/cypress/integration/customer/clientFiscalData.spec.js
index 2200802ca..e2c51ed85 100644
--- a/test/cypress/integration/customer/clientFiscalData.spec.js
+++ b/test/cypress/integration/customer/clientFiscalData.spec.js
@@ -1,37 +1,53 @@
 /// <reference types="cypress" />
+function checkSageFields(isRequired = false) {
+    const haveAttr = isRequired ? 'have.attr' : 'not.have.attr';
+    cy.dataCy('sageTaxTypeFk').filter('input').should(haveAttr, 'required');
+    cy.dataCy('sageTransactionTypeFk').filter('input').should(haveAttr, 'required');
+}
 describe('Client fiscal data', () => {
-    beforeEach(() => {
-        cy.viewport(1280, 720);
-        cy.login('developer');
-        cy.visit('#/customer/1107/fiscal-data');
-    });
-    it.skip('Should change required value when change customer', () => {
-        cy.get('.q-card').should('be.visible');
-        cy.dataCy('sageTaxTypeFk').filter('input').should('not.have.attr', 'required');
-        cy.get('#searchbar input').clear();
-        cy.get('#searchbar input').type('1{enter}');
-        cy.get('.q-item > .q-item__label').should('have.text', ' #1');
-        cy.dataCy('sageTaxTypeFk').filter('input').should('have.attr', 'required');
+    describe('#1008', () => {
+        beforeEach(() => {
+            cy.viewport(1280, 720);
+            cy.login('developer');
+            cy.visit('#/customer/1108/fiscal-data');
+        });
+        it('Should change required value when change customer', () => {
+            cy.get('.q-card').should('be.visible');
+            checkSageFields();
+            cy.get('[data-cy="vnCheckboxVerified data"]').click();
+            checkSageFields(true);
+            cy.get('#searchbar input').clear();
+            cy.get('#searchbar input').type('1{enter}');
+            cy.get('.q-item > .q-item__label').should('have.text', ' #1');
+            checkSageFields();
+        });
     });
+    describe('#1007', () => {
+        beforeEach(() => {
+            cy.viewport(1280, 720);
+            cy.login('developer');
+            cy.visit('#/customer/1107/fiscal-data');
+        });
 
-    it('check as equalizated', () => {
-        cy.get(
-            ':nth-child(1) > .q-checkbox > .q-checkbox__inner > .q-checkbox__bg',
-        ).click();
-        cy.get('.q-btn-group > .q-btn--standard > .q-btn__content').click();
+        it('check as equalizated', () => {
+            cy.get(
+                ':nth-child(1) > .q-checkbox > .q-checkbox__inner > .q-checkbox__bg',
+            ).click();
+            cy.get('.q-btn-group > .q-btn--standard > .q-btn__content').click();
 
-        cy.get('.q-card > :nth-child(1) > span').should(
-            'contain',
-            'You changed the equalization tax',
-        );
+            cy.get('.q-card > :nth-child(1) > span').should(
+                'contain',
+                'You changed the equalization tax',
+            );
 
-        cy.get('.q-card > :nth-child(2) > span').should(
-            'have.text',
-            'Do you want to spread the change?',
-        );
-        cy.get('[data-cy="VnConfirm_confirm"] > .q-btn__content > .block').click();
-        cy.get(
-            '.bg-warning > .q-notification__wrapper > .q-notification__content > .q-notification__message',
-        ).should('have.text', 'Equivalent tax spreaded');
+            cy.get('.q-card > :nth-child(2) > span').should(
+                'have.text',
+                'Do you want to spread the change?',
+            );
+            cy.get('[data-cy="VnConfirm_confirm"] > .q-btn__content > .block').click();
+            cy.get(
+                '.bg-warning > .q-notification__wrapper > .q-notification__content > .q-notification__message',
+            ).should('have.text', 'Equivalent tax spreaded');
+        });
     });
 });

From c5e8d8ab6fa9de3c5f19ded7806b28a6cf4ed9d2 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 12 May 2025 12:21:47 +0200
Subject: [PATCH 3/6] test: improve test

---
 src/pages/Customer/Card/CustomerFiscalData.vue       | 12 ++----------
 .../integration/customer/clientFiscalData.spec.js    |  3 +++
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/pages/Customer/Card/CustomerFiscalData.vue b/src/pages/Customer/Card/CustomerFiscalData.vue
index fbb155cd3..eda18061a 100644
--- a/src/pages/Customer/Card/CustomerFiscalData.vue
+++ b/src/pages/Customer/Card/CustomerFiscalData.vue
@@ -6,7 +6,6 @@ import { useQuasar } from 'quasar';
 import axios from 'axios';
 
 import useNotify from 'src/composables/useNotify.js';
-import FetchData from 'components/FetchData.vue';
 import FormModel from 'components/FormModel.vue';
 import VnRow from 'components/ui/VnRow.vue';
 import VnInput from 'src/components/common/VnInput.vue';
@@ -21,9 +20,6 @@ const { t } = useI18n();
 const route = useRoute();
 const { notify } = useNotify();
 
-const typesTaxes = ref([]);
-const typesTransactions = ref([]);
-
 function handleLocation(data, location) {
     const { town, code, provinceFk, countryFk } = location ?? {};
     data.postcode = code;
@@ -39,6 +35,7 @@ function onBeforeSave(formData, originalData) {
 }
 
 async function checkEtChanges(data, _, originalData) {
+    isTaxDataChecked.value = data.isTaxDataChecked;
     const equalizatedHasChanged = originalData.isEqualizated != data.isEqualizated;
     const hasToInvoiceByAddress =
         originalData.hasToInvoiceByAddress || data.hasToInvoiceByAddress;
@@ -74,12 +71,6 @@ function isRequired({ isTaxDataChecked: taxDataChecked }) {
 </script>
 
 <template>
-    <FetchData auto-load @on-fetch="(data) => (typesTaxes = data)" url="SageTaxTypes" />
-    <FetchData
-        auto-load
-        @on-fetch="(data) => (typesTransactions = data)"
-        url="SageTransactionTypes"
-    />
     <FormModel
         :url-update="`Clients/${route.params.id}/updateFiscalData`"
         auto-load
@@ -89,6 +80,7 @@ function isRequired({ isTaxDataChecked: taxDataChecked }) {
         @on-data-saved="checkEtChanges"
     >
         <template #form="{ data, validate, validations }">
+            {{ isTaxDataChecked }} {{ data.isTaxDataChecked }}
             <VnRow>
                 <VnInput
                     :label="t('Social name')"
diff --git a/test/cypress/integration/customer/clientFiscalData.spec.js b/test/cypress/integration/customer/clientFiscalData.spec.js
index e2c51ed85..646fb136c 100644
--- a/test/cypress/integration/customer/clientFiscalData.spec.js
+++ b/test/cypress/integration/customer/clientFiscalData.spec.js
@@ -15,6 +15,9 @@ describe('Client fiscal data', () => {
             cy.get('.q-card').should('be.visible');
             checkSageFields();
             cy.get('[data-cy="vnCheckboxVerified data"]').click();
+            cy.get('.q-btn-group > .q-btn--standard > .q-btn__content').click();
+            checkSageFields();
+            cy.get('[data-cy="vnCheckboxVerified data"]').click();
             checkSageFields(true);
             cy.get('#searchbar input').clear();
             cy.get('#searchbar input').type('1{enter}');

From bdc15a25807cf204ede4d6741d2e2f14f16b0a18 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 12 May 2025 12:24:51 +0200
Subject: [PATCH 4/6] test: use dataCy instead nth-child

---
 test/cypress/integration/customer/clientFiscalData.spec.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/test/cypress/integration/customer/clientFiscalData.spec.js b/test/cypress/integration/customer/clientFiscalData.spec.js
index 646fb136c..e80f7762e 100644
--- a/test/cypress/integration/customer/clientFiscalData.spec.js
+++ b/test/cypress/integration/customer/clientFiscalData.spec.js
@@ -33,9 +33,7 @@ describe('Client fiscal data', () => {
         });
 
         it('check as equalizated', () => {
-            cy.get(
-                ':nth-child(1) > .q-checkbox > .q-checkbox__inner > .q-checkbox__bg',
-            ).click();
+            cy.dataCy('vnCheckboxIs equalizated').click();
             cy.get('.q-btn-group > .q-btn--standard > .q-btn__content').click();
 
             cy.get('.q-card > :nth-child(1) > span').should(

From 84945b32f680708df35d790e0b218e03a4d316b7 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 12 May 2025 13:13:14 +0200
Subject: [PATCH 5/6] fix: initialize form data in FormModelPopup

---
 src/pages/Customer/components/CustomerNewCustomsAgent.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/pages/Customer/components/CustomerNewCustomsAgent.vue b/src/pages/Customer/components/CustomerNewCustomsAgent.vue
index ec9806334..69ecb0d27 100644
--- a/src/pages/Customer/components/CustomerNewCustomsAgent.vue
+++ b/src/pages/Customer/components/CustomerNewCustomsAgent.vue
@@ -16,6 +16,7 @@ const onDataSaved = (dataSaved) => {
 
 <template>
     <FormModelPopup
+        :form-initial-data="{}"
         :title="t('New customs agent')"
         @on-data-saved="onDataSaved($event)"
         model="customer"

From 16ed4e61813916ee3e6f453e3310962081f95296 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 12 May 2025 13:13:22 +0200
Subject: [PATCH 6/6] feat: add customs agent creation handling in
 CustomerAddressEdit

---
 .../Customer/components/CustomerAddressEdit.vue      | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/pages/Customer/components/CustomerAddressEdit.vue b/src/pages/Customer/components/CustomerAddressEdit.vue
index bc76f5985..5a7684e5e 100644
--- a/src/pages/Customer/components/CustomerAddressEdit.vue
+++ b/src/pages/Customer/components/CustomerAddressEdit.vue
@@ -179,6 +179,11 @@ function handleLocation(data, location) {
     data.provinceFk = provinceFk;
     data.countryFk = countryFk;
 }
+
+function onAgentCreated({ id, fiscalName }, data) {
+    customsAgents.value.push({ id, fiscalName });
+    data.customsAgentFk = id;
+}
 </script>
 
 <template>
@@ -292,9 +297,14 @@ function handleLocation(data, location) {
                     option-value="id"
                     v-model="data.customsAgentFk"
                     :tooltip="t('New customs agent')"
+                    :acls="[{ model: 'CustomsAgent', props: '*', accessType: 'WRITE' }]"
                 >
                     <template #form>
-                        <CustomerNewCustomsAgent />
+                        <CustomerNewCustomsAgent
+                            @on-data-saved="
+                                (requestResponse) => onAgentCreated(requestResponse, data)
+                            "
+                        />
                     </template>
                 </VnSelectDialog>
             </VnRow>