From f4171d8efae01d69889226e52034b3c2bdb10dbf Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Thu, 15 May 2025 14:08:39 +0200
Subject: [PATCH] test: fix test

---
 cypress.config.js                             |   2 +-
 src/pages/Ticket/Card/components/split.js     |   4 +-
 .../Ticket/Negative/TicketLackDetail.vue      |  16 +--
 .../Negative/components/ChangeItemDialog.vue  |   1 +
 .../Negative/components/ChangeStateDialog.vue |   8 +-
 .../Ticket/components/TicketNewPayment.vue    |   0
 .../integration/order/orderCatalog.spec.js    |   2 +-
 .../ticket/negative/TicketLackDetail.spec.js  | 131 ++++++++----------
 .../ticket/negative/TicketLackList.spec.js    |   4 +-
 .../integration/ticket/ticketSale.spec.js     |  13 +-
 .../vnComponent/vnConfirm.commands.js         |   6 +
 .../vnComponent/vnTable.commands.js           |  34 +++++
 12 files changed, 119 insertions(+), 102 deletions(-)
 create mode 100644 src/pages/Ticket/components/TicketNewPayment.vue

diff --git a/cypress.config.js b/cypress.config.js
index 90d950450..4b0c93aae 100644
--- a/cypress.config.js
+++ b/cypress.config.js
@@ -39,7 +39,7 @@ if (process.env.CI) {
 export default defineConfig({
     e2e: {
         baseUrl: `http://${urlHost}:9000`,
-        experimentalStudio: false,
+        experimentalStudio: true,
         trashAssetsBeforeRuns: false,
         defaultBrowser: 'chromium',
         fixturesFolder: 'test/cypress/fixtures',
diff --git a/src/pages/Ticket/Card/components/split.js b/src/pages/Ticket/Card/components/split.js
index f366ca177..74639e848 100644
--- a/src/pages/Ticket/Card/components/split.js
+++ b/src/pages/Ticket/Card/components/split.js
@@ -1,11 +1,11 @@
 import axios from 'axios';
-export default async function (data, date) {
+export default async function (data, landed) {
     const reducedData = data.reduce((acc, item) => {
         const existing = acc.find(({ ticketFk }) => ticketFk === item.id);
         if (existing) {
             existing.sales.push(item.saleFk);
         } else {
-            acc.push({ ticketFk: item.ticketFk, sales: [item.saleFk], date });
+            acc.push({ ticketFk: item.ticketFk, sales: [item.saleFk], landed });
         }
         return acc;
     }, []);
diff --git a/src/pages/Ticket/Negative/TicketLackDetail.vue b/src/pages/Ticket/Negative/TicketLackDetail.vue
index e0b0a469f..305c27208 100644
--- a/src/pages/Ticket/Negative/TicketLackDetail.vue
+++ b/src/pages/Ticket/Negative/TicketLackDetail.vue
@@ -69,6 +69,8 @@ const showItemProposal = () => {
         })
         .onOk(itemProposalEvt);
 };
+
+const isButtonDisabled = computed(() => selectedRows.value.length !== 1);
 </script>
 
 <template>
@@ -93,11 +95,7 @@ const showItemProposal = () => {
     >
         <template #top-right>
             <QBtnGroup push class="q-mr-lg" style="column-gap: 1px">
-                <QBtn
-                    data-cy="transferLines"
-                    color="primary"
-                    :disable="!(selectedRows.length === 1)"
-                >
+                <QBtn data-cy="transferLines" color="primary" :disable="isButtonDisabled">
                     <template #default>
                         <QIcon name="vn:splitline" />
                         <QIcon name="vn:ticket" />
@@ -118,7 +116,7 @@ const showItemProposal = () => {
                 <QBtn
                     color="primary"
                     @click="showItemProposal"
-                    :disable="!(selectedRows.length === 1)"
+                    :disable="isButtonDisabled"
                     data-cy="itemProposal"
                 >
                     <QIcon name="import_export" class="rotate-90" />
@@ -129,7 +127,7 @@ const showItemProposal = () => {
                 <VnPopupProxy
                     data-cy="changeItem"
                     icon="sync"
-                    :disable="!(selectedRows.length === 1)"
+                    :disable="isButtonDisabled"
                     :tooltip="t('negative.detail.modal.changeItem.title')"
                 >
                     <template #extraIcon> <QIcon name="vn:item" /> </template>
@@ -143,7 +141,7 @@ const showItemProposal = () => {
                 <VnPopupProxy
                     data-cy="changeState"
                     icon="sync"
-                    :disable="!(selectedRows.length === 1)"
+                    :disable="isButtonDisabled"
                     :tooltip="t('negative.detail.modal.changeState.title')"
                 >
                     <template #extraIcon> <QIcon name="vn:eye" /> </template>
@@ -157,7 +155,7 @@ const showItemProposal = () => {
                 <VnPopupProxy
                     data-cy="changeQuantity"
                     icon="sync"
-                    :disable="!(selectedRows.length === 1)"
+                    :disable="isButtonDisabled"
                     :tooltip="t('negative.detail.modal.changeQuantity.title')"
                     @click="showChangeQuantityDialog = true"
                 >
diff --git a/src/pages/Ticket/Negative/components/ChangeItemDialog.vue b/src/pages/Ticket/Negative/components/ChangeItemDialog.vue
index e77bcb3bb..4238bcc37 100644
--- a/src/pages/Ticket/Negative/components/ChangeItemDialog.vue
+++ b/src/pages/Ticket/Negative/components/ChangeItemDialog.vue
@@ -41,6 +41,7 @@ const updateItem = async () => {
         <QCardSection class="row items-center justify-center column items-stretch">
             <span>{{ $t('negative.detail.modal.changeItem.title') }}</span>
             <VnSelect
+                data-cy="New item_select"
                 url="Items/WithName"
                 :fields="['id', 'name']"
                 :sort-by="['id DESC']"
diff --git a/src/pages/Ticket/Negative/components/ChangeStateDialog.vue b/src/pages/Ticket/Negative/components/ChangeStateDialog.vue
index 273006dcb..8aac08fe3 100644
--- a/src/pages/Ticket/Negative/components/ChangeStateDialog.vue
+++ b/src/pages/Ticket/Negative/components/ChangeStateDialog.vue
@@ -18,10 +18,11 @@ const $props = defineProps({
 });
 const updateState = async () => {
     try {
+        debugger;
         showChangeStateDialog.value = true;
-        const rowsToUpdate = $props.selectedRows.map(({ id }) =>
+        const rowsToUpdate = $props.selectedRows.map(({ ticketFk }) =>
             axios.post(`Tickets/state`, {
-                ticketFk: id,
+                ticketFk,
                 code: newState.value,
             }),
         );
@@ -49,8 +50,9 @@ const updateState = async () => {
                 v-model="newState"
                 :options="editableStates"
                 option-label="name"
-                option-value="code"
+                option-value="id"
                 autofocus
+                data-cy="New state_select"
             />
         </QCardSection>
         <QCardActions align="right">
diff --git a/src/pages/Ticket/components/TicketNewPayment.vue b/src/pages/Ticket/components/TicketNewPayment.vue
new file mode 100644
index 000000000..e69de29bb
diff --git a/test/cypress/integration/order/orderCatalog.spec.js b/test/cypress/integration/order/orderCatalog.spec.js
index c07183fed..ef64d1b23 100644
--- a/test/cypress/integration/order/orderCatalog.spec.js
+++ b/test/cypress/integration/order/orderCatalog.spec.js
@@ -45,7 +45,7 @@ describe('OrderCatalog', { testIsolation: true }, () => {
         ).type('{enter}');
         cy.get(':nth-child(1) > [data-cy="catalogFilterCategory"]').click();
         cy.dataCy('catalogFilterValueDialogBtn').last().click();
-        cy.selectOption("[data-cy='catalogFilterValueDialogTagSelect']", 'Tallos');
+        cy.selectOption('[data-cy="catalogFilterValueDialogTagSelect"]', 'Tallos');
         cy.dataCy('catalogFilterValueDialogValueInput').find('input').focus();
         cy.dataCy('catalogFilterValueDialogValueInput').find('input').type('2');
         cy.dataCy('catalogFilterValueDialogValueInput').find('input').type('{enter}');
diff --git a/test/cypress/integration/ticket/negative/TicketLackDetail.spec.js b/test/cypress/integration/ticket/negative/TicketLackDetail.spec.js
index 08fdc16d8..c02336ae5 100644
--- a/test/cypress/integration/ticket/negative/TicketLackDetail.spec.js
+++ b/test/cypress/integration/ticket/negative/TicketLackDetail.spec.js
@@ -1,8 +1,6 @@
 /// <reference types="cypress" />
-
 const firstRow = 'tr.cursor-pointer > :nth-child(1)';
 const ticketId = 1000000;
-const findTr = (index) => `tbody > tr > :nth-child(${index}) > div`;
 const clickNotificationAction = () => {
     const notification = '.q-notification';
     cy.waitForElement(notification);
@@ -10,9 +8,9 @@ const clickNotificationAction = () => {
     cy.get(notification).find('.q-btn').click();
     cy.get(notification).should('not.be.visible');
 };
-describe('Ticket Lack detail', () => {
+describe('Ticket Lack detail', { testIsolation: true }, () => {
     beforeEach(() => {
-        cy.viewport(1280, 720);
+        cy.viewport(1980, 1020);
         cy.login('developer');
         cy.intercept('GET', /\/api\/Tickets\/itemLack\/88.*$/).as('getItemLack');
         cy.visit('/#/ticket/negative/88');
@@ -23,21 +21,19 @@ describe('Ticket Lack detail', () => {
             expect(filter).to.have.property('where');
             expect(filter.where).to.have.property('alertLevelCode', 'FREE');
         });
-        cy.domContentLoad();
-        cy.waitForElement('.q-table');
     });
     describe('Table detail', () => {
         it('should open descriptors', () => {
             cy.get('.q-table').should('be.visible');
             cy.colField('zoneName').click();
-            cy.dataCy('zoneDescriptorProxy').should('be.visible');
+            cy.dataCy('ZoneDescriptor').should('be.visible');
             cy.get('.q-item > .q-item__label').should('have.text', ' #1');
             cy.colField('ticketFk').click();
-            cy.dataCy('ticketDescriptorProxy').should('be.visible');
+            cy.dataCy('TicketDescriptor').should('be.visible');
             cy.get('.q-item > .q-item__label').should('have.text', ` #${ticketId}`);
             cy.colField('nickname').find('.link').click();
-            cy.waitForElement('[data-cy="customerDescriptorProxy"]');
-            cy.dataCy('customerDescriptorProxy').should('be.visible');
+            cy.waitForElement('[data-cy="CustomerDescriptor"]');
+            cy.dataCy('CustomerDescriptor').should('be.visible');
             cy.get('.q-item > .q-item__label').should('have.text', ' #1');
         });
         it('should display only one row in the lack list', () => {
@@ -63,60 +59,7 @@ describe('Ticket Lack detail', () => {
         it('Split', () => {
             cy.dataCy('ticketTransferPopup').find('.flex > .q-btn').click();
 
-            clickNotificationAction();
-
-            cy.dataCy('HandleLackDialog').should('be.visible');
-            cy.dataCy('HandleLackDialog').find('tbody > tr > :nth-child(1) > .q-icon');
-            cy.dataCy('HandleLackDialog').find(findTr(2)).should('have.class', 'link');
-            cy.dataCy('HandleLackDialog')
-                .find(`${findTr(2)}.link > div > span`)
-                .should('have.text', `${ticketId} `);
-            cy.dataCy('HandleLackDialog').find(findTr(3)).should('have.text', 'noSplit');
-        });
-    });
-    describe('Change Item', () => {
-        beforeEach(() => {
-            cy.get(firstRow).click();
-            cy.dataCy('changeItem').click();
-        });
-        it('Change failed', () => {
-            cy.dataCy('New item_select').should('be.visible').click();
-            cy.get('.q-item').contains('Palito rojo').click();
-            cy.get('.q-btn--unelevated > .q-btn__content > .block').click();
-
-            clickNotificationAction();
-
-            cy.dataCy('HandleLackDialog').should('be.visible');
-            cy.dataCy('HandleLackDialog').find('tbody > tr > :nth-child(1) > .q-icon');
-            cy.dataCy('HandleLackDialog').find(findTr(2)).should('have.class', 'link');
-            cy.dataCy('HandleLackDialog')
-                .find(`${findTr(2)}.link > span`)
-                .should('have.text', `${ticketId}`);
-            cy.dataCy('HandleLackDialog')
-                .find(findTr(3))
-                .should('have.text', 'price retrieval failed');
-        });
-    });
-    describe('Change state', () => {
-        beforeEach(() => {
-            cy.get(firstRow).click();
-            cy.dataCy('changeState').click();
-        });
-        it('Change success', () => {
-            cy.dataCy('New state_select').should('be.visible').click();
-            cy.get('.q-item').contains('OK').click();
-            cy.get('.q-btn--unelevated > .q-btn__content > .block').click();
-
-            clickNotificationAction();
-
-            cy.dataCy('HandleLackDialog')
-                .should('be.visible')
-                .find('tbody > tr > :nth-child(1) > .q-icon');
-            cy.dataCy('HandleLackDialog').find(findTr(2)).should('have.class', 'link');
-            cy.dataCy('HandleLackDialog')
-                .find(`${findTr(2)}.link > div > span`)
-                .should('have.text', `${ticketId} `);
-            cy.dataCy('HandleLackDialog').find(findTr(3)).should('have.text', 'OK');
+            cy.checkNotification('Ticket 1000000: No split');
         });
     });
     describe('change quantity', () => {
@@ -126,22 +69,60 @@ describe('Ticket Lack detail', () => {
             cy.dataCy('changeQuantity').click();
         });
 
-        it('Change success', () => {
+        it('by popup', () => {
             cy.dataCy('New quantity_input').type(10);
             cy.get('.q-btn--unelevated > .q-btn__content > .block').click();
 
             clickNotificationAction();
-
-            cy.dataCy('HandleLackDialog')
-                .should('be.visible')
-                .find('tbody > tr > :nth-child(1) > .q-icon');
-            cy.dataCy('HandleLackDialog').find(findTr(2)).should('have.class', 'link');
-            cy.dataCy('HandleLackDialog')
-                .find(`${findTr(2)}.link > div > span`)
-                .should('have.text', `${ticketId} `);
-            cy.dataCy('HandleLackDialog').find(findTr(3)).should('have.text', '10');
         });
     });
+    describe('Change state', () => {
+        beforeEach(() => {
+            cy.get(firstRow).click();
+            cy.dataCy('changeState').click();
+        });
+        it('by popup', () => {
+            cy.dataCy('New state_select').should('be.visible');
+            cy.selectOption('[data-cy="New state_select"]', 'OK');
+            cy.get('.q-btn--unelevated > .q-btn__content > .block').click();
+
+            clickNotificationAction();
+        });
+    });
+    describe('Change Item', () => {
+        beforeEach(() => {
+            cy.get(firstRow).click();
+            cy.dataCy('changeItem').click();
+        });
+        it('by popup', () => {
+            cy.dataCy('New item_select').should('be.visible');
+
+            cy.selectOption('[data-cy="New item_select"]', 'Palito rojo');
+            cy.get('.q-btn--unelevated > .q-btn__content > .block').click();
+            cy.checkNotification('Ticket 43: price retrieval failed');
+            cy.dataCy('changeItem').click();
+            cy.selectOption('[data-cy="New item_select"]', 'Ranged weapon longbow 200cm');
+            cy.get('.q-btn--unelevated > .q-btn__content > .block').click();
+
+            clickNotificationAction();
+        });
+        after(() => {
+            cy.visit('/#/ticket/1000000/sale');
+            const quantity = Math.floor(Math.random() * 100) + 1;
+
+            cy.dataCy('ticketSaleQuantityInput')
+                .find('input')
+                .eq(1)
+                .type(quantity)
+                .trigger('tab');
+            cy.get('.q-page > :nth-child(6)').click();
+
+            cy.get('[data-cy="ticketSaleQuantityInput"]')
+                .find('input')
+                .should('have.value', `${quantity}`);
+        });
+    });
+
     describe('Item proposal', () => {
         beforeEach(() => {
             cy.get(firstRow).click();
@@ -155,7 +136,7 @@ describe('Ticket Lack detail', () => {
             it('item proposal cells', () => {
                 cy.get('[data-col-field="longName"] .link').first().click();
 
-                cy.dataCy('itemDescriptorProxy').should('be.visible');
+                cy.dataCy('ItemDescriptor').should('be.visible');
 
                 cy.colField('longName', 2)
                     .find('.no-padding > .q-td > .middle')
diff --git a/test/cypress/integration/ticket/negative/TicketLackList.spec.js b/test/cypress/integration/ticket/negative/TicketLackList.spec.js
index a53668c12..16a73e332 100644
--- a/test/cypress/integration/ticket/negative/TicketLackList.spec.js
+++ b/test/cypress/integration/ticket/negative/TicketLackList.spec.js
@@ -1,7 +1,7 @@
 /// <reference types="cypress" />
 describe('Ticket Lack list', () => {
     beforeEach(() => {
-        cy.viewport(1280, 720);
+        cy.viewport(1980, 1020);
 
         cy.login('developer');
         cy.visit('/#/ticket/negative');
@@ -10,7 +10,7 @@ describe('Ticket Lack list', () => {
     describe('Table actions', () => {
         it('should display only one row in the lack list', () => {
             cy.get('[data-col-field="longName"]').first().click();
-            cy.dataCy('itemDescriptorProxy').should('be.visible');
+            cy.dataCy('ItemDescriptor').should('be.visible');
             cy.get('.q-virtual-scroll__content > :nth-child(1) > .sticky').click();
             cy.location('href').should('contain', '#/ticket/negative/5');
         });
diff --git a/test/cypress/integration/ticket/ticketSale.spec.js b/test/cypress/integration/ticket/ticketSale.spec.js
index 7fc843cf1..483d91974 100644
--- a/test/cypress/integration/ticket/ticketSale.spec.js
+++ b/test/cypress/integration/ticket/ticketSale.spec.js
@@ -22,7 +22,7 @@ describe('TicketSale', { testIsolation: true }, () => {
             cy.intercept('POST', /\/api\/Sales\/\d+\/updatePrice/).as('updatePrice');
 
             cy.dataCy('saveManaBtn').click();
-            handleVnConfirm();
+            cy.handleVnConfirm();
             cy.wait('@updatePrice').its('response.statusCode').should('eq', 200);
 
             cy.get('[data-col-field="price"]')
@@ -43,7 +43,7 @@ describe('TicketSale', { testIsolation: true }, () => {
             );
 
             cy.dataCy('saveManaBtn').click();
-            handleVnConfirm();
+            cy.handleVnConfirm();
             cy.wait('@updateDiscount').its('response.statusCode').should('eq', 204);
 
             cy.get('[data-col-field="discount"]')
@@ -61,7 +61,7 @@ describe('TicketSale', { testIsolation: true }, () => {
                 .find('[data-cy="undefined_input"]')
                 .type(concept)
                 .type('{enter}');
-            handleVnConfirm();
+            cy.handleVnConfirm();
 
             cy.get('[data-col-field="item"]').should('contain.text', `${concept}`);
         });
@@ -77,7 +77,7 @@ describe('TicketSale', { testIsolation: true }, () => {
                 .trigger('tab');
             cy.get('.q-page > :nth-child(6)').click();
 
-            handleVnConfirm();
+            cy.handleVnConfirm();
 
             cy.get('[data-cy="ticketSaleQuantityInput"]')
                 .find('input')
@@ -210,8 +210,3 @@ function selectFirstRow() {
     cy.waitForElement(firstRow);
     cy.get(firstRow).find('.q-checkbox__inner').click();
 }
-function handleVnConfirm() {
-    cy.confirmVnConfirm();
-
-    cy.checkNotification('Data saved');
-}
diff --git a/test/cypress/integration/vnComponent/vnConfirm.commands.js b/test/cypress/integration/vnComponent/vnConfirm.commands.js
index 9f93967d6..b486386f7 100644
--- a/test/cypress/integration/vnComponent/vnConfirm.commands.js
+++ b/test/cypress/integration/vnComponent/vnConfirm.commands.js
@@ -1,3 +1,9 @@
+Cypress.Commands.add('handleVnConfirm', () => {
+    cy.confirmVnConfirm();
+
+    cy.checkNotification('Data saved');
+});
+
 Cypress.Commands.add('confirmVnConfirm', () =>
     cy.dataCy('VnConfirm_confirm').should('exist').click(),
 );
diff --git a/test/cypress/integration/vnComponent/vnTable.commands.js b/test/cypress/integration/vnComponent/vnTable.commands.js
index 316fc12f1..f43d6ed68 100644
--- a/test/cypress/integration/vnComponent/vnTable.commands.js
+++ b/test/cypress/integration/vnComponent/vnTable.commands.js
@@ -18,3 +18,37 @@ Cypress.Commands.add('tableActions', (n = 0, child = 1) =>
         `:nth-child(${child}) > .q-table--col-auto-width > [data-cy="tableAction-${n}"] > .q-btn__content > .q-icon`,
     ),
 );
+
+Cypress.Commands.add('validateVnTableRows', (opts = {}) => {
+    let { cols = [] } = opts;
+    const { rows = [] } = opts;
+    if (!Array.isArray(cols)) cols = [cols];
+    const rowSelector = rows.length
+        ? rows.map((row) => `> :nth-child(${row})`).join(', ')
+        : '> *';
+    cy.get(`[data-cy="vnTable"] .q-virtual-scroll__content`).within(() => {
+        cy.get(`${rowSelector}`).each(($el) => {
+            for (const { name, type = 'string', val, operation = 'equal' } of cols) {
+                cy.wrap($el)
+                    .find(`[data-cy="vnTableCell_${name}"]`)
+                    .invoke('text')
+                    .then((text) => {
+                        if (type === 'string')
+                            expect(text.trim().toLowerCase()).to[operation](
+                                val.toLowerCase(),
+                            );
+                        if (type === 'number') cy.checkNumber(text, val, operation);
+                        if (type === 'date') cy.checkDate(text, val, operation);
+                    });
+            }
+        });
+    });
+});
+
+Cypress.Commands.add('colField', (name, index = null, key = 'data-col-field') => {
+    if (index) {
+        cy.get(`:nth-child(${index}) > [${key}="${name}"]`);
+    } else {
+        cy.get(`[${key}="${name}"]`);
+    }
+});