From e2304396d82ad2019878921c8657217e3c5c27a8 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sun, 1 Dec 2024 19:18:55 +0100
Subject: [PATCH 1/2] fix: parsePhone fn when no phone

---
 src/filters/parsePhone.js                                 | 3 +++
 .../__tests__/components/common/VnLinkPhone.spec.js       | 8 ++++++++
 2 files changed, 11 insertions(+)

diff --git a/src/filters/parsePhone.js b/src/filters/parsePhone.js
index 696f55007..cded224b9 100644
--- a/src/filters/parsePhone.js
+++ b/src/filters/parsePhone.js
@@ -1,4 +1,7 @@
 export default function (phone, prefix = 34) {
+    if (!phone) {
+        return;
+    }
     if (phone.startsWith('+')) {
         return `${phone.slice(1)}`;
     }
diff --git a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
index e460ab2fc..e31bff4a8 100644
--- a/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
+++ b/test/vitest/__tests__/components/common/VnLinkPhone.spec.js
@@ -2,6 +2,14 @@ import { describe, it, expect } from 'vitest';
 import parsePhone from 'src/filters/parsePhone';
 
 describe('parsePhone filter', () => {
+    it('no phone', () => {
+        const resultado = parsePhone(null, '34');
+        expect(resultado).toBe(undefined);
+    });
+    it('no phone and no prefix', () => {
+        const resultado = parsePhone(null, null);
+        expect(resultado).toBe(undefined);
+    });
     it("adds prefix +34 if it doesn't have one", () => {
         const resultado = parsePhone('123456789', '34');
         expect(resultado).toBe('34123456789');
-- 
2.40.1


From 137798c959693af8ec8c5ea377eba7a1dfd98fbc Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sun, 1 Dec 2024 19:57:15 +0100
Subject: [PATCH 2/2] perf: useOpenURL SaySimple

---
 src/components/ui/VnLinkPhone.vue | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index 4068498cd..027244609 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -2,6 +2,7 @@
 import { reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
 import axios from 'axios';
 import { parsePhone } from 'src/filters';
+import useOpenURL from 'src/composables/useOpenURL';
 const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
     channel: { type: Number, default: null },
@@ -11,25 +12,31 @@ const config = reactive({
     sip: { icon: 'phone', href: `sip:${props.phoneNumber}` },
     'say-simple': {
         icon: 'vn:saysimple',
-        href: null,
         channel: props.channel,
+        url: null,
     },
 });
 const type = Object.keys(config).find((key) => key in useAttrs()) || 'sip';
 
 onBeforeMount(async () => {
-    let { channel } = config[type];
+    let { channel, url } = config[type];
 
     if (type === 'say-simple') {
-        const { url, defaultChannel } = (await axios.get('SaySimpleConfigs/findOne'))
-            .data;
-        if (!channel) channel = defaultChannel;
-
-        config[type].href = `${url}?customerIdentity=%2B${parsePhone(
-            props.phoneNumber
-        )}&channelId=${channel}`;
+        const { url: defaultUrl, defaultChannel } = (
+            await axios.get('SaySimpleConfigs/findOne')
+        ).data;
+        if (!channel) config[type].channel = defaultChannel;
+        if (!url) config[type].url = defaultUrl;
     }
 });
+
+function openSaySimple() {
+    useOpenURL(
+        `${config[type].url}?customerIdentity=%2B${parsePhone(
+            props.phoneNumber
+        )}&channelId=${config[type].channel}`
+    );
+}
 </script>
 <template>
     <QBtn
@@ -40,8 +47,7 @@ onBeforeMount(async () => {
         size="sm"
         color="primary"
         padding="none"
-        :href="config[type].href"
-        @click.stop
+        @click.stop="openSaySimple"
     >
         <QTooltip>
             {{ capitalize(type).replace('-', '') }}
-- 
2.40.1