verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 85 Releases Wiki Activity

test: refs #7100 added test to vnNotes component #1121

Merged
jtubau merged 10 commits from 7100-createVnNotesSpec into dev 2025-01-08 06:05:02 +00:00
Conversation 0 Commits 10 Files Changed 1 +53 -11
1 changed files with 53 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 69451862bf - Show all commits

64
test/vitest/__tests__/components/common/VnNotes.spec.js
View File

@ -4,21 +4,23 @@ import VnNotes from 'src/components/ui/VnNotes.vue';
describe('VnNotes', () => {
let vm;
let wrapper;
let spyFetch;
let postMock;
let expectedBody;
beforeAll(async () => {
vi.spyOn(axios, 'get').mockReturnValue({ data: [] });
vm = createWrapper(VnNotes, {
wrapper = createWrapper(VnNotes, {
propsData: {
url: '/test',
filter: { order: 'created DESC' },
body: { name: 'Tony', lastName: 'Stark' },
addNote: false,
selectType: true,
selectType: false,
jsegarra commented 2024-12-20 09:58:18 +00:00
Outdated
Review
Copy Link

Todos los test asument que selectType es true, que pasa cuando le damos valor false?
Falla

Todos los test asument que selectType es true, que pasa cuando le damos valor false? Falla
}
}).vm;
});
wrapper = wrapper.wrapper;
vm = wrapper.vm;
});
beforeEach(() => {
@ -31,9 +33,10 @@ describe('VnNotes', () => {
});
describe('insert', () => {
jsegarra marked this conversation as resolved Outdated
jsegarra commented 2024-12-20 09:58:48 +00:00
Outdated
Review
Copy Link

Este caso no se dará, está bien incluirlo, pero para ser completo el test deberíamos probar con null

Este caso no se dará, está bien incluirlo, pero para ser completo el test deberíamos probar con null
it('should not call axios.post if newNote.text is empty', async () => {
vm.newNote.text = '';
vm.newNote.observationTypeFk = 1;
it('should not call axios.post and vnPaginateRef.fetch if newNote.text is null', async () => {
vm.newNote.text = null;
vm.newNote.observationTypeFk = null;
await wrapper.setProps({ selectType: true });
jsegarra marked this conversation as resolved Outdated
jsegarra commented 2024-12-20 12:23:22 +00:00
Outdated
Review
Copy Link

porque usas await?

porque usas await?
jtubau commented 2024-12-23 06:13:24 +00:00
Outdated
Review
Copy Link

Para asegurar que selectType haya cambiado correctamente antes de continuar, ya que si no lo uso, se ejecuta vm.insert() antes de que se actualice el valor y el test falla, lo mismo con el vm.insert, ya que los expect se ejecutan antes de que sus correspondientes métodos espiados sean ejecutados.

Para asegurar que selectType haya cambiado correctamente antes de continuar, ya que si no lo uso, se ejecuta vm.insert() antes de que se actualice el valor y el test falla, lo mismo con el vm.insert, ya que los expect se ejecutan antes de que sus correspondientes métodos espiados sean ejecutados.
jsegarra commented 2024-12-23 08:18:05 +00:00
Outdated
Review
Copy Link

Estoy mirando la documentación y devuelve una promesa, https://test-utils.vuejs.org/api/#setProps
Cuando puse el comentario no vi el await

Estoy mirando la documentación y devuelve una promesa, https://test-utils.vuejs.org/api/#setProps Cuando puse el comentario no vi el await
await vm.insert();
@ -41,9 +44,10 @@ describe('VnNotes', () => {
expect(spyFetch).not.toHaveBeenCalled();
});
it('should not call axios.post if observationTypeFk is missing and selectType is set', async () => {
vm.newNote.text = 'Test Note';
it('should not call axios.post and vnPaginateRef.fetch if newNote.text is empty', async () => {
vm.newNote.text = "";
vm.newNote.observationTypeFk = null;
await wrapper.setProps({ selectType: false });
await vm.insert();
@ -51,11 +55,49 @@ describe('VnNotes', () => {
expect(spyFetch).not.toHaveBeenCalled();
});
it('should not call axios.post and vnPaginateRef.fetch if observationTypeFk is missing and selectType is true', async () => {
vm.newNote.text = 'Test Note';
vm.newNote.observationTypeFk = null;
await wrapper.setProps({ selectType: true });
await vm.insert();
expect(postMock).not.toHaveBeenCalled();
expect(spyFetch).not.toHaveBeenCalled();
});
it('should call axios.post and vnPaginateRef.fetch if observationTypeFk is missing and selectType is false', async () => {
vm.newNote.text = "Test Note";
vm.newNote.observationTypeFk = null;
await wrapper.setProps({ selectType: false });
expectedBody = {...vm.$props.body, ...{ text: vm.newNote.text, observationTypeFk: vm.newNote.observationTypeFk }};
await vm.insert();
expect(postMock).toHaveBeenCalledWith(vm.$props.url, expectedBody);
expect(spyFetch).toHaveBeenCalled();
});
it('should call axios.post and vnPaginateRef.fetch if observationTypeFk is setted and selectType is false', async () => {
vm.newNote.text = "Test Note";
vm.newNote.observationTypeFk = 1;
await wrapper.setProps({ selectType: false });
expectedBody = {...vm.$props.body, ...{ text: vm.newNote.text, observationTypeFk: vm.newNote.observationTypeFk }};
await vm.insert();
expect(postMock).toHaveBeenCalledWith(vm.$props.url, expectedBody);
expect(spyFetch).toHaveBeenCalled();
});
it('should call axios.post and vnPaginateRef.fetch when newNote is valid', async () => {
vm.newNote.text = 'Test Note';
vm.newNote.observationTypeFk = 1;
wrapper.setProps({ selectType: false });
const expectedBody = {...vm.$props.body, ...{ text: vm.newNote.text, observationTypeFk: vm.newNote.observationTypeFk }};
expectedBody = {...vm.$props.body, ...{ text: vm.newNote.text, observationTypeFk: vm.newNote.observationTypeFk }};
await vm.insert();