verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

test: refs #8484 await main content loaded #1318

Merged
alexm merged 54 commits from 8484-waitToDomContentLoadedInTests into dev 2025-02-27 06:19:45 +00:00
Conversation 1 Commits 54 Files Changed 15 +1 -10
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d2aad80536 - Show all commits

11
test/cypress/support/commands.js
View File

@ -57,13 +57,9 @@ Cypress.Commands.add('login', (user = 'developer') => {
});
});
Cypress.Commands.add('domContentLoad', (element, timeout = 5000) => {
cy.waitUntil(() => cy.document().then((doc) => doc.readyState === 'complete'));
});
Cypress.Commands.overwrite('visit', (originalFn, url, options) => {
originalFn(url, options);
jorgep marked this conversation as resolved Outdated
alexm commented 2025-02-13 07:24:48 +00:00
Outdated
Review
Copy Link

No acabo de ver el codigo de waitUntil. Se espera x segundos, comprueba algo y sino vuelve a esperar x segundos.

Debe haber algo que te permita saber cuando ha cargado

No acabo de ver el codigo de waitUntil. Se espera x segundos, comprueba algo y sino vuelve a esperar x segundos. Debe haber algo que te permita saber cuando ha cargado
cy.domContentLoad();
cy.waitUntil(() => cy.get('main', { timeout: 10000 }).should('exist'));
});
jorgep commented 2025-02-26 15:49:59 +00:00
Review
Copy Link

Se asegura que el contenido este visible antes de hacer nada.

Se asegura que el contenido este visible antes de hacer nada.
Cypress.Commands.add('waitForElement', (element, timeout = 5000) => {
@ -396,8 +392,3 @@ Cypress.Commands.add('clickButtonWithIcon', (iconClass) => {
Cypress.Commands.add('clickButtonWithText', (buttonText) => {
cy.get('.q-btn').contains(buttonText).click();
});
Cypress.Commands.overwrite('visit', (originalFn, url, options) => {
originalFn(url, options);
cy.get('main', { timeout: 10000 }).should('exist');
});