From 2655e0a8e595eafeea219d30452c95f0fbd9e1f5 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 24 Feb 2025 22:46:27 +0100
Subject: [PATCH 1/2] fix: mana axios deacoplate

---
 src/pages/Ticket/Card/TicketEditMana.vue      | 65 +++++++++++--------
 src/pages/Ticket/Card/TicketSale.vue          | 21 ------
 .../Ticket/Card/TicketSaleMoreActions.vue     |  5 --
 3 files changed, 37 insertions(+), 54 deletions(-)

diff --git a/src/pages/Ticket/Card/TicketEditMana.vue b/src/pages/Ticket/Card/TicketEditMana.vue
index c1bc2639b..ff40a6592 100644
--- a/src/pages/Ticket/Card/TicketEditMana.vue
+++ b/src/pages/Ticket/Card/TicketEditMana.vue
@@ -1,32 +1,26 @@
 <script setup>
-import { ref } from 'vue';
+import axios from 'axios';
 import { useI18n } from 'vue-i18n';
+import { computed, ref } from 'vue';
+import { useRoute } from 'vue-router';
 import { toCurrency } from 'src/filters';
 import VnUsesMana from 'components/ui/VnUsesMana.vue';
 
 const $props = defineProps({
-    mana: {
-        type: Number,
-        default: null,
-    },
     newPrice: {
         type: Number,
         default: 0,
     },
-    usesMana: {
-        type: Boolean,
-        default: false,
-    },
-    manaCode: {
-        type: String,
-        default: 'mana',
-    },
     sale: {
         type: Object,
         default: null,
     },
 });
 
+const route = useRoute();
+const mana = ref(null);
+const usesMana = ref(false);
+
 const emit = defineEmits(['save', 'cancel']);
 
 const { t } = useI18n();
@@ -38,32 +32,47 @@ const save = (sale = $props.sale) => {
     QPopupProxyRef.value.hide();
 };
 
+const getMana = async () => {
+    const { data } = await axios.get(`Tickets/${route.params.id}/getSalesPersonMana`);
+    mana.value = data;
+    await getUsesMana();
+};
+
+const getUsesMana = async () => {
+    const { data } = await axios.get('Sales/usesMana');
+    usesMana.value = data;
+};
+
 const cancel = () => {
     emit('cancel');
     QPopupProxyRef.value.hide();
 };
+const hasMana = computed(() => typeof mana.value === 'number');
 defineExpose({ save });
 </script>
 
 <template>
-    <QPopupProxy ref="QPopupProxyRef" data-cy="ticketEditManaProxy">
+    <QPopupProxy
+        ref="QPopupProxyRef"
+        @before-show="getMana"
+        data-cy="ticketEditManaProxy"
+    >
         <div class="container">
-            <QSpinner v-if="typeof mana === 'number' && mana" color="primary" size="md" />
-            <div v-else>
-                <div class="header">Mana: {{ toCurrency(mana) }}</div>
-                <div class="q-pa-md">
-                    <slot :popup="QPopupProxyRef" />
-                    <div v-if="usesMana" class="column q-gutter-y-sm q-mt-sm">
-                        <VnUsesMana :mana-code="manaCode" />
-                    </div>
-                    <div v-if="newPrice" class="column items-center q-mt-lg">
-                        <span class="text-primary">{{ t('New price') }}</span>
-                        <span class="text-subtitle1">
-                            {{ toCurrency($props.newPrice) }}
-                        </span>
-                    </div>
+            <div class="header">Mana: {{ toCurrency(mana) }}</div>
+            <QSpinner v-if="!hasMana" color="primary" size="md" />
+            <div class="q-pa-md" v-else>
+                <slot :popup="QPopupProxyRef" />
+                <div v-if="usesMana" class="column q-gutter-y-sm q-mt-sm">
+                    <VnUsesMana :mana-code="manaCode" />
+                </div>
+                <div v-if="newPrice" class="column items-center q-mt-lg">
+                    <span class="text-primary">{{ t('New price') }}</span>
+                    <span class="text-subtitle1">
+                        {{ toCurrency($props.newPrice) }}
+                    </span>
                 </div>
             </div>
+
             <div class="row">
                 <QBtn
                     color="primary"
diff --git a/src/pages/Ticket/Card/TicketSale.vue b/src/pages/Ticket/Card/TicketSale.vue
index f5fb50ecf..076e06dea 100644
--- a/src/pages/Ticket/Card/TicketSale.vue
+++ b/src/pages/Ticket/Card/TicketSale.vue
@@ -44,7 +44,6 @@ const isTicketEditable = ref(false);
 const sales = ref([]);
 const editableStatesOptions = ref([]);
 const selectedSales = ref([]);
-const mana = ref(null);
 const manaCode = ref('mana');
 const ticketState = computed(() => store.data?.ticketState?.state?.code);
 const transfer = ref({
@@ -258,18 +257,6 @@ const DEFAULT_EDIT = {
     oldQuantity: null,
 };
 const edit = ref({ ...DEFAULT_EDIT });
-const usesMana = ref(null);
-
-const getUsesMana = async () => {
-    const { data } = await axios.get('Sales/usesMana');
-    usesMana.value = data;
-};
-
-const getMana = async () => {
-    const { data } = await axios.get(`Tickets/${route.params.id}/getSalesPersonMana`);
-    mana.value = data;
-    await getUsesMana();
-};
 
 const selectedValidSales = computed(() => {
     if (!sales.value) return;
@@ -277,7 +264,6 @@ const selectedValidSales = computed(() => {
 });
 
 const onOpenEditPricePopover = async (sale) => {
-    await getMana();
     edit.value = {
         sale: JSON.parse(JSON.stringify(sale)),
         price: sale.price,
@@ -285,7 +271,6 @@ const onOpenEditPricePopover = async (sale) => {
 };
 
 const onOpenEditDiscountPopover = async (sale) => {
-    await getMana();
     if (isLocked.value) return;
     if (sale) {
         edit.value = {
@@ -306,7 +291,6 @@ const changePrice = async (sale) => {
             await confirmUpdate(() => updatePrice(sale, newPrice));
         } else updatePrice(sale, newPrice);
     }
-    await getMana();
 };
 const updatePrice = async (sale, newPrice) => {
     await axios.post(`Sales/${sale.id}/updatePrice`, { newPrice });
@@ -599,9 +583,7 @@ watch(
                     :is-ticket-editable="isTicketEditable"
                     :sales="selectedValidSales"
                     :disable="!hasSelectedRows"
-                    :mana="mana"
                     :ticket-config="ticketConfig"
-                    @get-mana="getMana()"
                     @update-discounts="updateDiscounts"
                     @refresh-table="resetChanges"
                 />
@@ -829,7 +811,6 @@ watch(
                 </QBtn>
                 <TicketEditManaProxy
                     ref="editPriceProxyRef"
-                    :mana="mana"
                     :sale="row"
                     :new-price="getNewPrice"
                     @save="changePrice"
@@ -852,10 +833,8 @@ watch(
 
                 <TicketEditManaProxy
                     ref="editManaProxyRef"
-                    :mana="mana"
                     :sale="row"
                     :new-price="getNewPrice"
-                    :uses-mana="usesMana"
                     :mana-code="manaCode"
                     @save="changeDiscount"
                 >
diff --git a/src/pages/Ticket/Card/TicketSaleMoreActions.vue b/src/pages/Ticket/Card/TicketSaleMoreActions.vue
index 8b5537edc..840b62507 100644
--- a/src/pages/Ticket/Card/TicketSaleMoreActions.vue
+++ b/src/pages/Ticket/Card/TicketSaleMoreActions.vue
@@ -34,10 +34,6 @@ const props = defineProps({
         type: Array,
         default: () => [],
     },
-    mana: {
-        type: Number,
-        default: null,
-    },
     ticketConfig: {
         type: Array,
         default: () => [],
@@ -220,7 +216,6 @@ const createRefund = async (withWarehouse) => {
                 <TicketEditManaProxy
                     ref="editManaProxyRef"
                     :sale="row"
-                    :mana="props.mana"
                     @save="changeMultipleDiscount"
                 >
                     <VnInput
-- 
2.40.1


From e44d6a291515c7e045397836307718d62eb04d7c Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Mon, 24 Feb 2025 22:48:48 +0100
Subject: [PATCH 2/2] test: remove test

---
 .../Card/__tests__/TicketEditMana.spec.js     | 56 -------------------
 1 file changed, 56 deletions(-)
 delete mode 100644 src/pages/Ticket/Card/__tests__/TicketEditMana.spec.js

diff --git a/src/pages/Ticket/Card/__tests__/TicketEditMana.spec.js b/src/pages/Ticket/Card/__tests__/TicketEditMana.spec.js
deleted file mode 100644
index f685d4ef0..000000000
--- a/src/pages/Ticket/Card/__tests__/TicketEditMana.spec.js
+++ /dev/null
@@ -1,56 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-
-import { createI18n } from 'vue-i18n';
-import TicketEditMana from 'src/pages/Ticket/Card/TicketEditMana.vue';
-import { createWrapper } from 'app/test/vitest/helper';
-
-describe('TicketEditMana', () => {
-    let vm;
-    let wrapper;
-    function generateWrapper(props = {}) {
-        wrapper = createWrapper(TicketEditMana, {
-            props,
-        });
-        wrapper = wrapper.wrapper;
-        vm = wrapper.vm;
-    }
-    afterEach(() => {
-        vi.clearAllMocks();
-    });
-
-    describe('mana prop tests', async () => {
-        it('should show spinner when mana is null', async () => {
-            generateWrapper({ mana: null });
-            await vm.$nextTick();
-            expect(vm.hasMana).toBe(false);
-        });
-
-        it('should show spinner when mana is undefined', async () => {
-            generateWrapper({ mana: undefined });
-            expect(typeof undefined === 'number').toBe(false);
-            await vm.$nextTick();
-            expect(vm.hasMana).toBe(false);
-        });
-
-        it('should display negative mana value', async () => {
-            generateWrapper({ mana: -1000 });
-            expect(typeof -1000 === 'number').toBe(true);
-            await vm.$nextTick();
-            expect(vm.hasMana).toBe(true);
-        });
-
-        it('should display zero mana value', async () => {
-            generateWrapper({ mana: 0 });
-            expect(typeof 0 === 'number').toBe(true);
-            await vm.$nextTick();
-            expect(vm.hasMana).toBe(true);
-        });
-
-        it('should display positive mana value', async () => {
-            generateWrapper({ mana: 1000 });
-            expect(typeof 1000 === 'number').toBe(true);
-            await vm.$nextTick();
-            expect(vm.hasMana).toBe(true);
-        });
-    });
-});
-- 
2.40.1