verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 92 Releases Wiki Activity

bugfix/shelving-154 #168

Merged
alexm merged 28 commits from :bugfix/shelving-154 into dev 2024-02-08 17:28:05 +00:00
Conversation 3 Commits 28 Files Changed 28 +11 -3
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ea9a9323e7 - Show all commits

12
src/pages/Shelving/Card/ShelvingForm.vue
View File

@ -1,7 +1,7 @@
<script setup>
import { useI18n } from 'vue-i18n';
import { ref } from 'vue';
import { useRoute } from 'vue-router';
import { useRoute, useRouter } from 'vue-router';
import VnRow from 'components/ui/VnRow.vue';
import FetchData from 'components/FetchData.vue';
import FormModel from 'components/FormModel.vue';
@ -10,11 +10,12 @@ import VnSubToolbar from 'src/components/ui/VnSubToolbar.vue';
const { t } = useI18n();
const route = useRoute();
const router = useRouter();
const shelvingId = route.params?.id || null;
const isNew = Boolean(!shelvingId);
const defaultInitialData = {
parkingFk: null,
priority: 0,
priority: null,
code: null,
isRecyclable: false,
};
@ -58,6 +59,12 @@ const shelvingFilter = {
{ relation: 'parking' },
],
};
const onSave = () => {
if (isNew) {
router.push({ name: 'ShelvingList' });
}
};
</script>
<template>
<VnSubToolbar />
@ -75,6 +82,7 @@ const shelvingFilter = {
model="shelving"
:auto-load="!isNew"
:form-initial-data="defaultInitialData"
@on-data-saved="onSave"
>
<template #form="{ data, validate, filter }">
jsegarra marked this conversation as resolved
jsegarra commented 2024-02-05 06:37:09 +00:00
Review
Copy Link

El campo de prioridad no es de tipo number como si lo es en Salix.
En esta PR es posible poner prioridad igual a "1arriba abajo" y da fallo al crear. Es correcto, porque en el back, está la validación de que el campo debe ser de tipo number

El campo de prioridad no es de tipo number como si lo es en Salix. En esta PR es posible poner prioridad igual a "1arriba abajo" y da fallo al crear. Es correcto, porque en el back, está la validación de que el campo debe ser de tipo number
<VnRow class="row q-gutter-md q-mb-md">

2
src/pages/Shelving/Card/ShelvingSearchbar.vue
View File

@ -9,7 +9,7 @@ const { t } = useI18n();
data-key="ShelvingList"
url="Shelvings"
:label="t('Search shelving')"
:info="t('You can search by search reference')"
:info="t('You can search by shelving reference')"
/>
</template>