verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 71 Releases Wiki Activity

feature/EntriesCorrections #177

Merged
alexm merged 24 commits from :feature/EntriesCorrections into dev 2024-02-07 06:44:33 +00:00
Conversation 1 Commits 24 Files Changed 32 +23 -33
1 changed files with 23 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 86bbc7cfd6 - Show all commits

56
src/pages/Entry/Card/EntryBuys.vue
View File

@ -42,25 +42,24 @@ const getInputEvents = (colField, props) => {
const tableColumnComponents = {
item: {
component: QBtn,
props: () => ({
props: {
jsegarra marked this conversation as resolved Outdated
jsegarra commented 2024-02-04 16:11:49 +00:00
Outdated
Review
Copy Link

8 veces el mismo código para keyenter y blur.
Propuesta, sustituir las ocurrencias por uno genérico

8 veces el mismo código para keyenter y blur. Propuesta, sustituir las ocurrencias por uno genérico
wbuezas commented 2024-02-05 12:32:35 +00:00
Outdated
Review
Copy Link

Commit cambios: 2de02723ba

Commit cambios: https://gitea.verdnatura.es/verdnatura/salix-front/commit/2de02723baa04064fbf8817dc55b7af7cbf18d26
wbuezas commented 2024-02-05 15:32:51 +00:00
Outdated
Review
Copy Link

Nueva mejora aplicada.

Commit: 5da5bb2047

Nueva mejora aplicada. Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/5da5bb204707ac7e0909be1cdc87a689366e17a7
color: 'blue',
flat: true,
}),
},
event: () => ({}),
},
quantity: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
class: 'input-number',
}),
},
event: getInputEvents,
},
packagingFk: {
component: VnSelectFilter,
props: () => ({
props: {
'option-value': 'id',
'option-label': 'id',
'emit-value': true,
@ -68,76 +67,69 @@ const tableColumnComponents = {
'use-input': true,
'hide-selected': true,
options: packagingsOptions.value,
}),
},
event: getInputEvents,
},
stickers: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
class: 'input-number',
}),
},
event: getInputEvents,
},
weight: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
}),
},
event: getInputEvents,
},
packing: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
}),
},
event: getInputEvents,
},
grouping: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
}),
},
event: getInputEvents,
},
buyingValue: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
}),
},
event: getInputEvents,
},
price2: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
}),
},
event: getInputEvents,
},
price3: {
component: VnInput,
props: (col) => ({
props: {
type: 'number',
min: 0,
label: col.label,
}),
},
event: getInputEvents,
},
import: {
component: 'span',
props: () => {},
props: {},
event: () => ({}),
},
};
@ -341,7 +333,7 @@ const showLockIcon = (groupingMode, mode) => {
<QTd v-for="col in props.cols" :key="col.name">
<component
jsegarra marked this conversation as resolved Outdated
jsegarra commented 2024-02-05 08:03:04 +00:00
Outdated
Review
Copy Link

Podemos hacer desaprecer los labels de los inputs, como está hecho para embalaje.
Queda redundante tener el nombre de la columna en el input.

¿Que opinas @alexm ?

Podemos hacer desaprecer los labels de los inputs, como está hecho para embalaje. Queda redundante tener el nombre de la columna en el input. ¿Que opinas @alexm ?
alexm commented 2024-02-05 10:15:31 +00:00
Outdated
Review
Copy Link

Sii es un mejor enfoque

Sii es un mejor enfoque
wbuezas commented 2024-02-05 15:50:54 +00:00
Outdated
Review
Copy Link

Aplicado.

Commit: 86bbc7cfd6

Aplicado. Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/86bbc7cfd679b948046d913aa368f2bda8b276fb
:is="tableColumnComponents[col.name].component"
v-bind="tableColumnComponents[col.name].props(col)"
v-bind="tableColumnComponents[col.name].props"
v-model="props.row[col.field]"
v-on="
tableColumnComponents[col.name].event(
@ -419,9 +411,7 @@ const showLockIcon = (groupingMode, mode) => {
<QItem v-for="col in props.cols" :key="col.name">
<component
:is="tableColumnComponents[col.name].component"
v-bind="
tableColumnComponents[col.name].props(col)
"
v-bind="tableColumnComponents[col.name].props"
v-model="props.row[col.field]"
v-on="
tableColumnComponents[col.name].event(