verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 92 Releases Wiki Activity

#7124 - First Input Autofocus without property #251

Merged
jsegarra merged 5 commits from 7124_autofocus_first_input into dev 2024-03-25 07:17:04 +00:00
Conversation 0 Commits 5 Files Changed 5 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8a82b7ab38 - Show all commits

6
src/boot/qformMixin.js
View File

@ -1,5 +1,9 @@
import { getCurrentInstance } from 'vue';
const filterAvailableInput = element => element.classList.contains('q-field__native') && !element.disabled
const filterAvailableText = element => element.__vueParentComponent.type.name === 'QInput' && element.__vueParentComponent?.attrs?.class !== 'vn-input-date';
export default {
mounted: function () {
const vm = getCurrentInstance();
@ -7,7 +11,7 @@ export default {
if (!['searchbarForm','filterPanelForm'].includes(this.$el?.id)) {
// AUTOFOCUS
const elementsArray = Array.from(this.$el.elements);
jsegarra marked this conversation as resolved
alexm commented 2024-03-22 06:05:06 +00:00
Review
Copy Link

No usar una variable si luego solo se usa una vez. Igual se te ha quedado de antes

No usar una variable si luego solo se usa una vez. Igual se te ha quedado de antes
😆 1
jsegarra commented 2024-03-22 06:34:19 +00:00
Review
Copy Link

Si que se usaba en el evento key, pero eso pertenece a otra rama

Si que se usaba en el evento key, pero eso pertenece a otra rama
const firstInputElement = elementsArray.find(element => element.classList.contains('q-field__native'));
const firstInputElement = elementsArray.filter(filterAvailableInput).find(filterAvailableText);
if (firstInputElement) {
firstInputElement.focus();
jsegarra marked this conversation as resolved
jgallego commented 2024-03-21 14:24:41 +00:00
Review
Copy Link

refactor de chatGpt para no usar -1
const firstInputElement = elementsArray.find(element => element.classList.contains('q-field__native'));

if (firstInputElement) {

refactor de chatGpt para no usar -1 const firstInputElement = elementsArray.find(element => element.classList.contains('q-field__native')); if (firstInputElement) {
👀 1