Merge branch 'dev' into 6392-balance-produccion-propia

Jenkinsfile

@@ -5,20 +5,9 @@ def FROM_GIT
 def RUN_TESTS
 def RUN_BUILD
 
-pre: {
+node {
-    switch (env.BRANCH_NAME) {
+    stage('Setup') {
-        case 'test':
-            env.NODE_ENV = 'test'
-            env.BACK_REPLICAS = 2
-            break
-        case 'master':
-            env.NODE_ENV = 'production'
-            env.BACK_REPLICAS = 4
-            break
-        default:
         env.NODE_ENV = 'dev'
-            env.BACK_REPLICAS = 1
-    }
 
         PROTECTED_BRANCH = [
             'dev',
@@ -30,9 +19,30 @@ pre: {
         RUN_TESTS = !PROTECTED_BRANCH && FROM_GIT
         RUN_BUILD = PROTECTED_BRANCH && FROM_GIT
 
-    // Uncomment to enable debugging
+        // https://www.jenkins.io/doc/book/pipeline/jenkinsfile/#using-environment-variables
-    // https://loopback.io/doc/en/lb3/Setting-debug-strings.html#debug-strings-reference
+        echo "NODE_NAME: ${env.NODE_NAME}"
-    //env.DEBUG = 'strong-remoting:shared-method'
+        echo "WORKSPACE: ${env.WORKSPACE}"
+
+        configFileProvider([
+            configFile(fileId: 'salix.properties',
+            variable: 'PROPS_FILE')
+        ]) {
+            def props = readProperties file: PROPS_FILE
+            props.each {key, value -> env."${key}" = value }
+            props.each {key, value -> echo "${key}: ${value}" }
+        }
+
+        if (PROTECTED_BRANCH) {
+            configFileProvider([
+                configFile(fileId: "salix.branch.${env.BRANCH_NAME}",
+                variable: 'BRANCH_PROPS_FILE')
+            ]) {
+                def props = readProperties file: BRANCH_PROPS_FILE
+                props.each {key, value -> env."${key}" = value }
+                props.each {key, value -> echo "${key}: ${value}" }
+            }
+        }
+    }
 }
 pipeline {
     agent any
@@ -47,29 +57,47 @@ pipeline {
         STACK_NAME = "${env.PROJECT_NAME}-${env.BRANCH_NAME}"
     }
     stages {
+        stage('Install') {
+            environment {
+                NODE_ENV = ''
+            }
+            parallel {
+                stage('Back') {
+                    steps {
+                        sh 'pnpm install --prefer-offline'
+                    }
+                }
+                stage('Print') {
+                    when {
+                        expression { FROM_GIT }
+                    }
+                    steps {
+                        sh 'pnpm install --prefer-offline --prefix=print'
+                    }
+                }
+                stage('Front') {
+                    when {
+                        expression { FROM_GIT }
+                    }
+                    steps {
+                        sh 'pnpm install --prefer-offline --prefix=front'
+                    }
+                }
+            }
+        }
         stage('Stack') {
             environment {
-                NODE_ENV = ""
                 TZ = 'Europe/Madrid'
             }
             parallel {
                 stage('Back') {
                     stages {
-                        stage('Install') {
-                            environment {
-                                NODE_ENV = ""
-                            }
-                            steps {
-                                sh 'pnpm install --prefer-offline'
-                                sh 'pnpm install --prefer-offline --prefix=print'
-                            }
-                        }
                         stage('Test') {
                             when {
                                 expression { RUN_TESTS }
                             }
                             environment {
-                                NODE_ENV = ""
+                                NODE_ENV = ''
                             }
                             steps {
                                 sh 'npm run test:back:ci'
@@ -106,20 +134,12 @@ pipeline {
                         expression { FROM_GIT }
                     }
                     stages {
-                        stage('Install') {
-                            environment {
-                                NODE_ENV = ""
-                            }
-                            steps {
-                                sh 'pnpm install --prefer-offline --prefix=front'
-                            }
-                        }
                         stage('Test') {
                             when {
                                 expression { RUN_TESTS }
                             }
                             environment {
-                                NODE_ENV = ""
+                                NODE_ENV = ''
                             }
                             steps {
                                 sh 'jest --ci --reporters=default --reporters=jest-junit --maxWorkers=10'

db/dump/fixtures.after.sql

@@ -73,9 +73,10 @@ INSERT INTO vn.cmr (id, truckPlate, observations, senderInstruccions, paymentIns
 
 UPDATE `vn`.`claimRatio` SET `claimAmount` = '10' WHERE (`clientFk` = '1101');
 
-INSERT INTO `vn`.`agency` (`name`, `warehouseFk`, `warehouseAliasFk`, `isOwn`, `isAnyVolumeAllowed`) VALUES
+INSERT INTO `vn`.`agency` (`name`, `warehouseFk`, `isOwn`, `isAnyVolumeAllowed`) 
-    ('Agencia', '1', '1', '1', '1'),
+    VALUES
-    ('Otra agencia ', '1', '2', '0', '0');
+    ('Agencia', '1', '1', '1'),
+    ('Otra agencia ', '1', '0', '0');
 
 INSERT INTO `vn`.`expedition` (`agencyModeFk`, `ticketFk`, `isBox`, `counter`, `workerFk`, `externalId`, `packagingFk`, `hostFk`, `itemPackingTypeFk`, `hasNewRoute`) VALUES
     ('1', '1', 1, '1', '1', '1', '1', 'pc00', 'F', 0),

db/dump/fixtures.before.sql

@@ -174,20 +174,15 @@ INSERT INTO `vn`.`country`(`id`, `country`, `isUeeMember`, `code`, `currencyFk`,
         (19,'Francia',  1, 'FR', 1, 27, 4, 0, 1),
         (30,'Canarias', 1, 'IC', 1, 24, 4, 1, 2);
 
-INSERT INTO `vn`.`warehouseAlias`(`id`, `name`)
+INSERT INTO `vn`.`warehouse`(`id`, `name`, `code`, `isComparative`, `isInventory`, `hasAvailable`, `isManaged`, `hasDms`, `hasComission`, `countryFk`, `hasProduction`, `isOrigin`, `isDestiny`)
     VALUES
-        (1, 'Main Warehouse'),
+        (1,  'Warehouse One',   'ALG',   1, 1, 1, 1, 1, 1, 1,   1, 1, 1),
-        (2, 'Gotham');
+        (2,  'Warehouse Two',   NULL,    1, 1, 1, 1, 0, 1, 13,  1, 1, 0),
-
+        (3,  'Warehouse Three', NULL,    1, 1, 1, 1, 0, 0, 1,   1, 1, 0),
-INSERT INTO `vn`.`warehouse`(`id`, `name`, `code`, `isComparative`, `isInventory`, `hasAvailable`, `isManaged`, `hasDms`, `hasComission`, `aliasFk`, `countryFk`, `hasProduction`)
+        (4,  'Warehouse Four',  NULL,    1, 1, 1, 1, 0, 0, 1,   1, 0, 1),
-    VALUES
+        (5,  'Warehouse Five',  NULL,    1, 1, 1, 1, 0, 0, 1,   1, 0, 0),
-        (1,  'Warehouse One',   'ALG',   1, 1, 1, 1, 1, 1, 2, 1,   1),
+        (13, 'Inventory',       'inv',   1, 1, 1, 0, 0, 0, 1,   0, 0, 0),
-        (2,  'Warehouse Two',   NULL,    1, 1, 1, 1, 0, 1, 2, 13,  1),
+        (60, 'Algemesi',        NULL,    1, 1, 1, 0, 0, 0, 1,   0, 0, 0);
-        (3,  'Warehouse Three', NULL,    1, 1, 1, 1, 0, 0, 2, 1,   1),
-        (4,  'Warehouse Four',  NULL,    1, 1, 1, 1, 0, 0, 2, 1,   1),
-        (5,  'Warehouse Five',  NULL,    1, 1, 1, 1, 0, 0, 2, 1,   1),
-        (13, 'Inventory',       'inv',   1, 1, 1, 0, 0, 0, 2, 1,   0),
-        (60, 'Algemesi',        NULL,    1, 1, 1, 0, 0, 0, 2, 1,   0);
 
 INSERT INTO `vn`.`sectorType` (id,description)
 	VALUES (1,'First type');
@@ -271,18 +266,18 @@ INSERT INTO `vn`.`deliveryMethod`(`id`, `code`, `description`)
         (3, 'PICKUP', 'Recogida'),
         (4, 'OTHER', 'Otros');
 
-INSERT INTO `vn`.`agency`(`id`, `name`, `warehouseFk`, `warehouseAliasFk`)
+INSERT INTO `vn`.`agency`(`id`, `name`, `warehouseFk`)
     VALUES
-        (1,     'inhouse pickup'        ,   1, 1),
+        (1,     'inhouse pickup'        ,   1),
-        (2,     'Super-Man delivery'    ,   1, 1),
+        (2,     'Super-Man delivery'    ,   1),
-        (3,     'Teleportation device'  ,   1, 1),
+        (3,     'Teleportation device'  ,   1),
-        (4,     'Entanglement'          ,   1, 1),
+        (4,     'Entanglement'          ,   1),
-        (5,     'Quantum break device'  ,   1, 1),
+        (5,     'Quantum break device'  ,   1),
-        (6,     'Walking'               ,   1, 1),
+        (6,     'Walking'               ,   1),
-        (7,     'Gotham247'             ,   1, 1),
+        (7,     'Gotham247'             ,   1),
-        (8,     'Gotham247Expensive'    ,   1, 1),
+        (8,     'Gotham247Expensive'    ,   1),
-        (9,     'Refund'                ,   1, 1),
+        (9,     'Refund'                ,   1),
-        (10,    'Other agency'          ,   1, 1);
+        (10,    'Other agency'          ,   1);
 
 UPDATE `vn`.`agencyMode` SET `id` = 1 WHERE `name` = 'inhouse pickup';
 UPDATE `vn`.`agencyMode` SET `id` = 2 WHERE `name` = 'Super-Man delivery';
@@ -569,13 +564,13 @@ INSERT INTO `vn`.`supplierActivity`(`code`, `name`)
 
 INSERT INTO `vn`.`supplier`(`id`, `name`, `nickname`,`account`,`countryFk`,`nif`, `commission`, `created`, `isActive`, `street`, `city`, `provinceFk`, `postCode`, `payMethodFk`, `payDemFk`, `payDay`, `taxTypeSageFk`, `withholdingSageFk`, `transactionTypeSageFk`, `workerFk`, `supplierActivityFk`, `isPayMethodChecked`, `healthRegister`)
     VALUES
-        (1,     'Plants SL',                'Plants nick',      4100000001, 1, '06089160W', 0, util.VN_CURDATE(), 1, 'supplier address 1', 'PONTEVEDRA',    1, 15214, 1, 1, 15, 4,  1, 1, 18, 'flowerPlants',  1, '400664487V'),
+        (1,     'PLANTS SL',             'Plants nick',      4100000001, 1, '06089160W', 0, util.VN_CURDATE(), 1, 'supplier address 1', 'PONTEVEDRA',    1, 15214, 1, 1, 15, 4,  1, 1, 18, 'flowerPlants',  1, '400664487V'),
-        (2,     'Farmer King',              'The farmer',       4000020002, 1, '87945234L', 0, util.VN_CURDATE(), 1, 'supplier address 2', 'GOTHAM',        2, 43022, 1, 2, 10, 93, 2, 8, 18, 'animals',       1, '400664487V'),
+        (2,     'FARMER KING',              'The farmer',       4000020002, 1, '87945234L', 0, util.VN_CURDATE(), 1, 'supplier address 2', 'GOTHAM',        2, 43022, 1, 2, 10, 93, 2, 8, 18, 'animals',       1, '400664487V'),
-        (69,    'Packaging',                'Packaging nick',   4100000069, 1, '94935005K', 0, util.VN_CURDATE(), 1, 'supplier address 5', 'ASGARD',        3, 46600, 1, 1, 15, 4,  1, 1, 18, 'flowerPlants',  1, '400664487V'),
+        (69,    'PACKAGING',                'Packaging nick',   4100000069, 1, '94935005K', 0, util.VN_CURDATE(), 1, 'supplier address 5', 'ASGARD',        3, 46600, 1, 1, 15, 4,  1, 1, 18, 'flowerPlants',  1, '400664487V'),
-        (442,   'Verdnatura Levante SL',    'Verdnatura',       5115000442, 1, '06815934E', 0, util.VN_CURDATE(), 1, 'supplier address 3', 'GOTHAM',        1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V'),
+        (442,   'VERDNATURA LEVANTE SL',    'Verdnatura',       5115000442, 1, '06815934E', 0, util.VN_CURDATE(), 1, 'supplier address 3', 'GOTHAM',        1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V'),
-        (567,   'Holland',                  'Holland nick',     4000020567, 1, '14364089Z', 0, util.VN_CURDATE(), 1, 'supplier address 6', 'ASGARD',        3, 46600, 1, 2, 10, 93, 2, 8, 18, 'animals',       1, '400664487V'),
+        (567,   'HOLLAND',                  'Holland nick',     4000020567, 1, '14364089Z', 0, util.VN_CURDATE(), 1, 'supplier address 6', 'ASGARD',        3, 46600, 1, 2, 10, 93, 2, 8, 18, 'animals',       1, '400664487V'),
-        (791,   'Bros SL',                  'Bros nick',        5115000791, 1, '37718083S', 0, util.VN_CURDATE(), 1, 'supplier address 7', 'ASGARD',        3, 46600, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V'),
+        (791,   'BROS SL',                  'Bros nick',        5115000791, 1, '37718083S', 0, util.VN_CURDATE(), 1, 'supplier address 7', 'ASGARD',        3, 46600, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V'),
-        (1381,  'Ornamentales',             'Ornamentales',     7185001381, 1, '07972486L', 0, util.VN_CURDATE(), 1, 'supplier address 4', 'GOTHAM',        1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V');
+        (1381,  'ORNAMENTALES',             'Ornamentales',     7185001381, 1, '07972486L', 0, util.VN_CURDATE(), 1, 'supplier address 4', 'GOTHAM',        1, 43022, 1, 2, 15, 6,  9, 3, 18, 'complements',   1, '400664487V');
 
 INSERT INTO `vn`.`supplierAddress`(`id`, `supplierFk`, `nickname`, `street`, `provinceFk`, `postalCode`, `city`, `phone`, `mobile`)
     VALUES

db/routines/vn/functions/intrastat_estimateNet.sql

@@ -0,0 +1,32 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn`.`intrastat_estimateNet`(
+	vSelf INT,
+	vStems INT
+)
+	RETURNS double
+	DETERMINISTIC
+BEGIN
+/**
+* Calcula un valor neto estimado en función de 
+* datos históricos de facturas intrastat.
+*
+* @param vSelf Id de intrastat
+* @param vStems Número de unidades
+* @return vNet
+*/
+	DECLARE vNet DOUBLE;
+
+	SELECT ROUND(vStems / (SUM(average) / COUNT(average)), 2) INTO vNet
+		FROM (
+			SELECT *, stems / net average
+				FROM invoiceInIntrastat
+				WHERE intrastatFk = vSelf
+					AND net
+					AND stems > 0
+				ORDER BY dated DESC
+				LIMIT 20
+		) sub;
+
+	RETURN vNet/2;
+END$$
+DELIMITER ;

db/routines/vn/procedures/fustControl.sql

@@ -1,79 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`fustControl`(vFromDated DATE, vToDated DATE)
-BEGIN
-	
-	DECLARE vSijsnerClientFk INT DEFAULT 19752;
-
-	DECLARE vDateStart DATETIME;
-	DECLARE vDateEnd DATETIME;
-
-	SET vDateStart = vFromDated;
-	SET vDateEnd = util.Dayend(vToDated);
-
-	SELECT p.id FustCode, 
-			CAST(sent.stucks AS DECIMAL(10,0)) FH, 
-			CAST(tp.stucks AS DECIMAL(10,0)) Tickets, 
-			CAST(-sj.stucks AS DECIMAL(10,0)) Sijsner, 
-			CAST(IFNULL(sent.stucks,0) - IFNULL(tp.stucks,0) + IFNULL(sj.stucks,0) AS DECIMAL(10,0)) saldo
-		FROM vn.packaging p
-		LEFT JOIN (
-			SELECT FustCode, sum(fustQuantity) stucks
-				FROM (
-				SELECT IFNULL(pe.equivalentFk ,b.packagingFk) FustCode, s.quantity / b.packing AS fustQuantity
-					FROM vn.sale s 
-						JOIN vn.ticket t ON t.id = s.ticketFk 
-						JOIN vn.warehouse w ON w.id = t.warehouseFk 
-						JOIN vn.warehouseAlias wa ON wa.id = w.aliasFk 
-						JOIN cache.last_buy lb ON lb.item_id = s.itemFk AND lb.warehouse_id = t.warehouseFk 
-						JOIN vn.buy b ON b.id = lb.buy_id 
-						JOIN vn.packaging p ON p.id = b.packagingFk 
-						LEFT JOIN vn.packageEquivalent pe ON pe.packagingFk = p.id
-						JOIN vn.address a ON a.id = t.addressFk 
-						JOIN vn.province p2 ON p2.id = a.provinceFk 
-						JOIN vn.country c ON c.id = p2.countryFk 
-					WHERE t.shipped BETWEEN vDateStart AND vDateEnd
-						AND wa.name = 'VNH'
-						AND p.isPackageReturnable 
-						AND c.country = 'FRANCIA') sub 
-					GROUP BY FustCode) sent ON sent.FustCode = p.id
-		LEFT JOIN (
-			SELECT FustCode, sum(quantity) stucks
-				FROM (
-				SELECT IFNULL(pe.equivalentFk ,tp.packagingFk) FustCode, tp.quantity
-					FROM vn.ticketPackaging tp 
-						JOIN vn.ticket t ON t.id = tp.ticketFk 
-						JOIN vn.warehouse w ON w.id = t.warehouseFk 
-						JOIN vn.warehouseAlias wa ON wa.id = w.aliasFk 
-						JOIN vn.packaging p ON p.id = tp.packagingFk 
-						LEFT JOIN vn.packageEquivalent pe ON pe.packagingFk = p.id
-						JOIN vn.address a ON a.id = t.addressFk 
-						JOIN vn.province p2 ON p2.id = a.provinceFk 
-						JOIN vn.country c ON c.id = p2.countryFk 
-					WHERE t.shipped BETWEEN vDateStart AND vDateEnd
-						AND wa.name = 'VNH'
-						AND p.isPackageReturnable 
-						AND c.country = 'FRANCIA'
-						AND t.clientFk != vSijsnerClientFk
-						AND tp.quantity > 0) sub 
-					GROUP BY FustCode) tp ON tp.FustCode = p.id
-		LEFT JOIN (
-			SELECT FustCode, sum(quantity) stucks
-				FROM (
-				SELECT IFNULL(pe.equivalentFk ,tp.packagingFk) FustCode, tp.quantity
-					FROM vn.ticketPackaging tp 
-						JOIN vn.ticket t ON t.id = tp.ticketFk 
-						JOIN vn.warehouse w ON w.id = t.warehouseFk 
-						JOIN vn.warehouseAlias wa ON wa.id = w.aliasFk 
-						JOIN vn.packaging p ON p.id = tp.packagingFk 
-						LEFT JOIN vn.packageEquivalent pe ON pe.packagingFk = p.id
-					WHERE t.shipped BETWEEN TIMESTAMPADD(DAY, 1, vDateStart ) AND TIMESTAMPADD(DAY, 1, vDateEnd )
-						AND wa.name = 'VNH'
-						AND p.isPackageReturnable 
-						AND t.clientFk = vSijsnerClientFk) sub 
-					GROUP BY FustCode) sj ON sj.FustCode = p.id
-		WHERE sent.stucks 
-			OR tp.stucks
-			OR sj.stucks;
-
-END$$
-DELIMITER ;

db/routines/vn/procedures/fustControlDetail.sql

@@ -1,36 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`fustControlDetail`(vFromDated DATE, vToDated DATE)
-BEGIN
-	
-	DECLARE vSijsnerClientFk INT DEFAULT 19752;
-
-	DECLARE vDateStart DATETIME;
-	DECLARE vDateEnd DATETIME;
-
-	SET vDateStart = vFromDated;
-	SET vDateEnd = util.Dayend(vToDated);
-	
-	SELECT a.nickname shopName,
-			a.city , 
-			IFNULL(pe.equivalentFk ,tp.packagingFk) FustCode, 
-			tp.quantity,
-			tp.ticketFk,
-			CONCAT('From ', vFromDated,' to ', vToDated) AS dateRange
-				FROM vn.ticketPackaging tp 
-					JOIN vn.ticket t ON t.id = tp.ticketFk 
-					JOIN vn.warehouse w ON w.id = t.warehouseFk 
-					JOIN vn.warehouseAlias wa ON wa.id = w.aliasFk 
-					JOIN vn.packaging p ON p.id = tp.packagingFk 
-					LEFT JOIN vn.packageEquivalent pe ON pe.packagingFk = p.id
-					JOIN vn.address a ON a.id = t.addressFk 
-					JOIN vn.province p2 ON p2.id = a.provinceFk 
-					JOIN vn.country c ON c.id = p2.countryFk 
-				WHERE t.shipped BETWEEN vFromDated AND util.dayend(vToDated)
-					AND wa.name = 'VNH'
-					AND p.isPackageReturnable 
-					AND c.country = 'FRANCIA'
-					AND t.clientFk != vSijsnerClientFk
-					AND tp.quantity > 0;
-				
-END$$
-DELIMITER ;

db/routines/vn/procedures/itemPlacementSupplyStockGetTargetList.sql

@@ -8,16 +8,9 @@ BEGIN
  * @param vItemFk Identificador de vn.item
  * @param vSectorFk Identificador de vn.sector
  */
-	DECLARE vWarehouseAliasFk INT;
-
-	SELECT w.aliasFk INTO vWarehouseAliasFk
-		FROM vn.sector s
-		JOIN vn.warehouse w ON w.id = s.warehouseFk
-		WHERE s.id = vSectorFk;
-
 	SELECT ish.shelvingFk shelving,
 			p.code parking,
-		sum(ish.visible) as stockTotal,
+			SUM(ish.visible) stockTotal,
 			ish.created,
 			p.pickingOrder
 		FROM vn.itemShelving ish
@@ -25,10 +18,12 @@ BEGIN
 			JOIN vn.parking p ON p.id = sh.parkingFk
 			JOIN vn.sector sc ON sc.id = p.sectorFk
 			JOIN vn.warehouse w ON w.id = sc.warehouseFk
-			WHERE w.aliasFk = vWarehouseAliasFk
+		WHERE sc.id = vSectorFk
 			AND ish.visible > 0
 			AND ish.itemFk = vItemFk
 		GROUP BY ish.id
-		ORDER BY (sc.id = vSectorFk) DESC, sh.priority DESC, ish.created, p.pickingOrder;
+		ORDER BY sh.priority DESC,
+			ish.created, 
+			p.pickingOrder;
 END$$
 DELIMITER ;

db/routines/vn/triggers/warehouse_afterUpdate.sql

@@ -1,12 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`warehouse_afterUpdate`
-	AFTER UPDATE ON `warehouse`
-	FOR EACH ROW
-BEGIN
-	IF NEW.isFeedStock IS TRUE AND OLD.isFeedStock IS FALSE THEN
-		INSERT IGNORE INTO warehouseAlias(`name`) VALUES(NEW.`name`);
-		INSERT IGNORE INTO warehouseJoined(warehouseFk, warehouseAliasFk)
-			VALUES(NEW.id,LAST_INSERT_ID());
-	END IF;
-END$$
-DELIMITER ;

db/routines/vn/views/warehouseJoined.sql

@@ -1,6 +0,0 @@
-CREATE OR REPLACE DEFINER=`root`@`localhost`
-	SQL SECURITY DEFINER
-	VIEW `vn`.`warehouseJoined`
-AS SELECT `wj`.`warehouse_id` AS `warehouseFk`,
-	`wj`.`warehouse_alias_id` AS `warehouseAliasFk`
-FROM `vn2008`.`warehouse_joined` `wj`

db/routines/vn/views/zoneEstimatedDelivery.sql

@@ -14,7 +14,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost`
 		JOIN saleVolume sv ON sv.ticketFk = t.id
 		LEFT JOIN lastHourProduction lhp ON lhp.warehouseFk = t.warehouseFk
 		JOIN warehouse w ON w.id = t.warehouseFk
-		JOIN warehouseAlias wa ON wa.id = w.aliasFk
 		STRAIGHT_JOIN `zone` z ON z.id = t.zoneFk
 		LEFT JOIN zoneClosure zc ON zc.zoneFk = t.zoneFk
 			AND zc.dated = util.VN_CURDATE()

db/routines/vn2008/functions/intrastat_neto.sql

@@ -1,20 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn2008`.`intrastat_neto`(intINSTRASTAT INTEGER,intUNIDADES INTEGER)
-	RETURNS double
-	DETERMINISTIC
-BEGIN
-
-	DECLARE n DOUBLE;
-
-	SELECT ROUND(intUNIDADES / (SUM(MEDIA) / COUNT(media)), 2) INTO n FROM
-		(SELECT *, unidades / neto MEDIA
-			FROM intrastat_data
-		WHERE intrastat_id = intINSTRASTAT AND neto
-				AND unidades > 0
-		ORDER BY odbc_date DESC
-		LIMIT 20) t;
-	-- JGF 01/06 per a evitar Kg en negatiu
-	RETURN n/2;
-
-END$$
-DELIMITER ;

db/routines/vn2008/procedures/desglose_volume.sql

@@ -1,82 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn2008`.`desglose_volume`(IN vAgencyFk INT)
-BEGIN
-	
-    DECLARE vStarted DATETIME DEFAULT TIMESTAMP(util.VN_CURDATE());
-    DECLARE vEnded DATETIME DEFAULT TIMESTAMP(util.VN_CURDATE(), '23:59:59');
-    DECLARE vIsHolland BOOL;
-    
-   	SELECT (wa.name = 'Holanda') INTO vIsHolland
-   		FROM vn.agency a 
-   			JOIN vn.warehouseAlias wa ON wa.id = a.warehouseAliasFk 
-   			WHERE a.id = vAgencyFk;
-	
-   	IF vIsHolland THEN
-   	
-   		DROP TEMPORARY TABLE IF EXISTS tmp.ticket_PackagingEstimated;
-		CREATE TEMPORARY TABLE tmp.ticket_PackagingEstimated
-		(
-	         ticketFk INT PRIMARY KEY
-	        ,carros DECIMAL(5,1) DEFAULT 0
-	    );
-   	
-   		INSERT INTO tmp.ticket_PackagingEstimated(ticketFk, carros)
-		SELECT sv.ticketFk, ROUND(vc.dutchCompressionRate * sum(sv.volume) / vc.trolleyM3,0)
-			FROM vn.ticket t
-	        JOIN vn.saleVolume sv ON sv.ticketFk = t.id
-	        JOIN vn.agencyMode am ON am.id = t.agencyModeFk 
-	        JOIN vn.volumeConfig vc
-	            WHERE t.shipped BETWEEN vStarted AND vEnded
-	            AND am.agencyFk = vAgencyFk
-	            GROUP BY t.id;
-	           
-	    SELECT 	a.nickname Provincia, 
-				count(*) expediciones, 
-				0 Bultos, 
-				sum(tpe.carros) Prevision
-	        FROM vn.ticket t
-	        	JOIN vn.address a ON a.id = t.addressFk 
-		        JOIN tmp.ticket_PackagingEstimated tpe ON tpe.ticketFk = t.id
-	        GROUP BY a.nickname;
-   	
-   	ELSE
-   	
-   		DROP TEMPORARY TABLE IF EXISTS tmp.ticket_PackagingEstimated;
-		CREATE TEMPORARY TABLE tmp.ticket_PackagingEstimated
-		(
-	         ticketFk INT PRIMARY KEY
-	        ,boxes INT DEFAULT 0
-	    );
-   	
-		INSERT INTO tmp.ticket_PackagingEstimated(ticketFk, boxes)
-		SELECT sv.ticketFk, CEIL(1000 * sum(sv.volume) / vc.standardFlowerBox)
-			FROM vn.ticket t
-	        JOIN vn.saleVolume sv ON sv.ticketFk = t.id
-	        JOIN vn.agencyMode am ON am.id = t.agencyModeFk 
-	        JOIN vn.volumeConfig vc
-	            WHERE t.shipped BETWEEN vStarted AND vEnded
-	            AND IFNULL(t.packages,0) = 0
-	            AND am.agencyFk = vAgencyFk
-	            GROUP BY t.id;
-		
-		
-		SELECT 	p.name Provincia, 
-				count(*) expediciones, 
-				sum(t.packages) Bultos, 
-				sum(tpe.boxes) Prevision
-	        FROM vn.ticket t
-		        JOIN vn.address a ON a.id = t.addressFk 
-		        JOIN vn.province p ON a.provinceFk = p.id
-		        JOIN vn.agencyMode am ON am.id = t.agencyModeFk 
-		        JOIN tmp.ticket_PackagingEstimated tpe ON tpe.ticketFk = t.id
-		    WHERE t.warehouseFk = 60
-	            AND t.shipped BETWEEN vStarted AND vEnded
-	            AND am.agencyFk = vAgencyFk
-	        GROUP BY p.name;
-	       
-	 END IF;
-           SELECT * FROM tmp.ticket_PackagingEstimated;
-     DROP TEMPORARY TABLE tmp.ticket_PackagingEstimated;
-
-END$$
-DELIMITER ;

db/routines/vn2008/views/Articles_botanical.sql

@@ -1,7 +0,0 @@
-CREATE OR REPLACE DEFINER=`root`@`localhost`
-	SQL SECURITY DEFINER
-	VIEW `vn2008`.`Articles_botanical`
-AS SELECT `ab`.`itemFk` AS `Id_Article`,
-	`ab`.`genusFk` AS `genus_id`,
-	`ab`.`specieFk` AS `specie_id`
-FROM `vn`.`itemBotanical` `ab`

db/routines/vn2008/views/agency.sql

@@ -4,7 +4,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost`
 AS SELECT `a`.`id` AS `agency_id`,
 	`a`.`name` AS `name`,
 	`a`.`warehouseFk` AS `warehouse_id`,
-	`a`.`warehouseAliasFk` AS `warehouse_alias_id`,
 	`a`.`isOwn` AS `propios`,
 	`a`.`workCenterFk` AS `workCenterFk`
 FROM `vn`.`agency` `a`

db/routines/vn2008/views/bionic_updating_options.sql

@@ -1,6 +0,0 @@
-CREATE OR REPLACE DEFINER=`root`@`localhost`
-	SQL SECURITY DEFINER
-	VIEW `vn2008`.`bionic_updating_options`
-AS SELECT `t`.`id` AS `buo_id`,
-	`t`.`description` AS `description`
-FROM `vn`.`ticketUpdateAction` `t`

db/routines/vn2008/views/businessReasonEnd.sql

@@ -1,6 +0,0 @@
-CREATE OR REPLACE DEFINER=`root`@`localhost`
-	SQL SECURITY DEFINER
-	VIEW `vn2008`.`businessReasonEnd`
-AS SELECT `b`.`id` AS `id`,
-	`b`.`reason` AS `reason`
-FROM `vn`.`businessReasonEnd` `b`

db/routines/vn2008/views/cl_dev.sql

@@ -1,6 +0,0 @@
-CREATE OR REPLACE DEFINER=`root`@`localhost`
-	SQL SECURITY DEFINER
-	VIEW `vn2008`.`cl_dev`
-AS SELECT `c`.`id` AS `id`,
-	`c`.`description` AS `devolucion`
-FROM `vn`.`claimRedelivery` `c`

db/routines/vn2008/views/cl_est.sql

@@ -1,7 +0,0 @@
-CREATE OR REPLACE DEFINER=`root`@`localhost`
-	SQL SECURITY DEFINER
-	VIEW `vn2008`.`cl_est`
-AS SELECT `c`.`id` AS `id`,
-	`c`.`description` AS `estado`,
-	`c`.`roleFk` AS `roleFk`
-FROM `vn`.`claimState` `c`

db/versions/10857-navyArborvitae/00-firstScript.sql

@@ -0,0 +1,8 @@
+ALTER TABLE vn.agency 
+	CHANGE warehouseAliasFk warehouseAliasFk__ SMALLINT(5) UNSIGNED DEFAULT NULL NULL COMMENT '@deprecated 2024-01-23 refs #5167';
+
+ALTER TABLE vn.warehouse 
+	CHANGE aliasFk aliasFk__ SMALLINT(5) UNSIGNED DEFAULT NULL NULL COMMENT '@deprecated 2024-01-23 refs #5167';
+
+RENAME TABLE vn.warehouseAlias TO vn.warehouseAlias__;
+ALTER TABLE vn.warehouseAlias__ COMMENT='@deprecated 2024-01-23 refs #5167';

db/versions/10863-brownIvy/00-firstScript.sql

@@ -0,0 +1,4 @@
+-- Place your SQL code here
+UPDATE vn.supplier
+    SET name = UPPER(name),
+    nickname = UPPER(nickname);

db/versions/10871-wheatCyca/00-firstScript.sql

@@ -0,0 +1 @@
+REVOKE SELECT ON TABLE vn2008.Articles_botanical FROM buyer, administrative;

e2e/paths/13-supplier/01_summary_and_descriptor.spec.js

@@ -24,7 +24,7 @@ describe('Supplier summary & descriptor path', () => {
     it(`should confirm there's data on the summary header`, async() => {
         const result = await page.waitToGetProperty(selectors.supplierSummary.header, 'innerText');
 
-        expect(result).toContain('Plants SL - 1');
+        expect(result).toContain('PLANTS SL - 1');
     });
 
     it(`should confirm there's data on the summary basic data`, async() => {

e2e/paths/13-supplier/03_fiscal_data.spec.js

@@ -24,7 +24,7 @@ describe('Supplier fiscal data path', () => {
             country: null,
             postcode: null,
             city: 'Valencia',
-            socialName: 'Farmer King SL',
+            socialName: 'FARMER KING SL',
             taxNumber: '12345678Z',
             account: '0123456789',
             sageWithholding: 'retencion estimacion objetiva',
@@ -46,7 +46,7 @@ describe('Supplier fiscal data path', () => {
             country: 'España',
             postcode: '46000',
             city: 'Valencia',
-            socialName: 'Farmer King SL',
+            socialName: 'FARMER KING SL',
             taxNumber: '12345678Z',
             account: '0123456789',
             sageWithholding: 'RETENCION ESTIMACION OBJETIVA',

loopback/locale/en.json

@@ -204,6 +204,7 @@
 	"It was not able to remove the next expeditions:": "It was not able to remove the next expeditions: {{expeditions}}",
 	"Incorrect pin": "Incorrect pin.",
 	"The notification subscription of this worker cant be modified": "The notification subscription of this worker cant be modified",
+	"Name should be uppercase": "Name should be uppercase",
 	"Fecha fuera de rango": "Fecha fuera de rango",
 	"There is no zone for these parameters 34": "There is no zone for these parameters 34"
 }

loopback/locale/es.json

@@ -337,5 +337,6 @@
 	"You already have the mailAlias": "Ya tienes este alias de correo",
 	"The alias cant be modified": "Este alias de correo no puede ser modificado",
 	"No tickets to invoice": "No hay tickets para facturar",
+	"Name should be uppercase": "El nombre debe ir en mayúscula",
 	"An email is necessary": "Es necesario un email"
 }

modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js

@@ -8,14 +8,14 @@ describe('InvoiceIn filter()', () => {
         try {
             const ctx = {
                 args: {
-                    search: 'Plants SL',
+                    search: 'PLANTS SL',
                 }
             };
 
             const result = await models.InvoiceIn.filter(ctx, {}, options);
 
             expect(result.length).toEqual(5);
-            expect(result[0].supplierName).toEqual('Plants SL');
+            expect(result[0].supplierName).toEqual('PLANTS SL');
 
             await tx.rollback();
         } catch (e) {

modules/supplier/back/methods/supplier/specs/getSummary.spec.js

@@ -5,7 +5,7 @@ describe('Supplier getSummary()', () => {
         const supplier = await app.models.Supplier.getSummary(1);
 
         expect(supplier.id).toEqual(1);
-        expect(supplier.name).toEqual('Plants SL');
+        expect(supplier.name).toEqual('PLANTS SL');
         expect(supplier.nif).toEqual('06089160W');
         expect(supplier.account).toEqual('4100000001');
         expect(supplier.payDay).toEqual(15);

modules/supplier/back/methods/supplier/specs/newSupplier.spec.js

@@ -25,13 +25,13 @@ describe('Supplier newSupplier()', () => {
         try {
             const options = {transaction: tx};
             ctx.args = {
-                name: 'newSupplier',
+                name: 'NEWSUPPLIER',
                 nif: '12345678Z'
             };
 
             const result = await models.Supplier.newSupplier(ctx, options);
 
-            expect(result.name).toEqual('newSupplier');
+            expect(result.name).toEqual('NEWSUPPLIER');
             await tx.rollback();
         } catch (e) {
             await tx.rollback();

modules/supplier/back/methods/supplier/specs/updateFiscalData.spec.js

@@ -6,7 +6,7 @@ describe('Supplier updateFiscalData', () => {
     const administrativeId = 5;
     const employeeId = 1;
     const defaultData = {
-        name: 'Plants SL',
+        name: 'PLANTS SL',
         nif: '06089160W',
         account: '4100000001',
         sageTaxTypeFk: 4,
@@ -56,7 +56,7 @@ describe('Supplier updateFiscalData', () => {
         });
 
         ctx.args = {
-            name: 'Weapon Dealer',
+            name: 'WEAPON DEALER',
             nif: 'A68446004',
             account: '4000000005',
             sageTaxTypeFk: 5,
@@ -72,7 +72,7 @@ describe('Supplier updateFiscalData', () => {
 
         const result = await app.models.Supplier.updateFiscalData(ctx, supplierId);
 
-        expect(result.name).toEqual('Weapon Dealer');
+        expect(result.name).toEqual('WEAPON DEALER');
         expect(result.nif).toEqual('A68446004');
         expect(result.account).toEqual('4000000005');
         expect(result.sageTaxTypeFk).toEqual(5);

modules/supplier/back/models/specs/supplier.spec.js

@@ -129,7 +129,7 @@ describe('loopback model Supplier', () => {
             const options = {transaction: tx};
 
             try {
-                const newSupplier = await models.Supplier.create({name: 'Alfred Pennyworth'}, options);
+                const newSupplier = await models.Supplier.create({name: 'ALFRED PENNYWORTH'}, options);
                 const fetchedSupplier = await models.Supplier.findById(newSupplier.id, null, options);
 
                 expect(Number(fetchedSupplier.account)).toEqual(4100000000 + newSupplier.id);

modules/supplier/back/models/supplier.js

@@ -46,6 +46,12 @@ module.exports = Self => {
     Self.validateAsync('postCode', hasValidPostcode, {
         message: `The postcode doesn't exist. Please enter a correct one`
     });
+    Self.validatesFormatOf('name', {
+        message: 'Name should be uppercase',
+        allowNull: false,
+        allowBlank: false,
+        with: /^[^a-z]*$/
+    });
 
     async function hasValidPostcode(err, done) {
         if (!this.postcode)

modules/supplier/front/create/index.html

@@ -12,7 +12,8 @@
             <vn-textfield
                 label="Supplier name"
                 ng-model="$ctrl.supplier.name"
-                vn-focus>
+                vn-focus
+                ng-keyup="$ctrl.supplier.name = $ctrl.supplier.name.toUpperCase()">
             </vn-textfield>
         </vn-horizontal>
     </vn-card>