From 180fb95a0004dd360c8af130f93e30a39b8d3370 Mon Sep 17 00:00:00 2001
From: vicent <vicent@verdnatura.es>
Date: Tue, 16 Nov 2021 10:09:42 +0100
Subject: [PATCH] feat(createAbsence): add backTest

---
 db/dump/fixtures.sql                          |  1 +
 .../back/methods/worker/createAbsence.js      |  9 ++++--
 .../worker/specs/createAbsence.spec.js        | 31 +++++++++++++++++++
 3 files changed, 38 insertions(+), 3 deletions(-)

diff --git a/db/dump/fixtures.sql b/db/dump/fixtures.sql
index 49ff08db98..745a2ee07a 100644
--- a/db/dump/fixtures.sql
+++ b/db/dump/fixtures.sql
@@ -1882,6 +1882,7 @@ INSERT INTO `postgresql`.`calendar_state` (`calendar_state_id`, `type`, `rgb`, `
 
 INSERT INTO `postgresql`.`calendar_employee` (`business_id`, `calendar_state_id`, `date`) 
     VALUES 
+        (1,    6, IF(MONTH(CURDATE()) = 12 AND DAY(CURDATE()) > 10, DATE_ADD(CURDATE(), INTERVAL -10 DAY), DATE_ADD(CURDATE(), INTERVAL 10 DAY))),
         (1106, 1, IF(MONTH(CURDATE()) = 12 AND DAY(CURDATE()) > 10, DATE_ADD(CURDATE(), INTERVAL -10 DAY), DATE_ADD(CURDATE(), INTERVAL 10 DAY))),
         (1106, 1, IF(MONTH(CURDATE()) = 12 AND DAY(CURDATE()) > 10, DATE_ADD(CURDATE(), INTERVAL -11 DAY), DATE_ADD(CURDATE(), INTERVAL 11 DAY))),
         (1106, 1, IF(MONTH(CURDATE()) = 12 AND DAY(CURDATE()) > 10, DATE_ADD(CURDATE(), INTERVAL -12 DAY), DATE_ADD(CURDATE(), INTERVAL 12 DAY))),
diff --git a/modules/worker/back/methods/worker/createAbsence.js b/modules/worker/back/methods/worker/createAbsence.js
index 3045a31690..217191a306 100644
--- a/modules/worker/back/methods/worker/createAbsence.js
+++ b/modules/worker/back/methods/worker/createAbsence.js
@@ -65,12 +65,15 @@ module.exports = Self => {
             if (args.dated < labour.started || (labour.ended != null && args.dated > labour.ended))
                 throw new UserError(`The contract was not active during the selected date`);
 
-            let result = await Self.rawSql(
-                `SELECT COUNT(*) halfDayHolidayCounter
+            const result = await Self.rawSql(
+                `SELECT COUNT(*) halfHolidayCounter
                     FROM vn.calendar c 
                     WHERE c.dayOffTypeFk = 6 AND c.businessFk = ?`, [args.businessFk]);
 
-            if (args.absenceTypeId == 6 && result[0].halfDayHolidayCounter > 0)
+            const hasHalfHoliday = result[0].halfHolidayCounter > 0;
+            const isHalfHoliday = args.absenceTypeId == 6;
+
+            if (isHalfHoliday && hasHalfHoliday)
                 throw new UserError(`Cannot add more than one '1/2 day vacation'`);
 
             const absence = await models.Calendar.create({
diff --git a/modules/worker/back/methods/worker/specs/createAbsence.spec.js b/modules/worker/back/methods/worker/specs/createAbsence.spec.js
index f2c00e8040..e5387c379d 100644
--- a/modules/worker/back/methods/worker/specs/createAbsence.spec.js
+++ b/modules/worker/back/methods/worker/specs/createAbsence.spec.js
@@ -74,4 +74,35 @@ describe('Worker createAbsence()', () => {
             throw e;
         }
     });
+
+    it('should return an error trying to create a "Half holiday" absence', async() => {
+        const ctx = {
+            req: {accessToken: {userId: 19}},
+            args: {
+                businessFk: 1,
+                absenceTypeId: 6,
+                dated: new Date()
+            }
+        };
+
+        const tx = await app.models.Calendar.beginTransaction({});
+
+        try {
+            const options = {transaction: tx};
+
+            let error;
+            await app.models.Worker.createAbsence(ctx, workerId, options).catch(e => {
+                error = e;
+            }).finally(() => {
+                expect(error.message).toEqual(`Cannot add more than one '1/2 day vacation'`);
+            });
+
+            expect(error).toBeDefined();
+
+            await tx.rollback();
+        } catch (e) {
+            await tx.rollback();
+            throw e;
+        }
+    });
 });