From 1939c65fabcdf68ffb351ba5b51bbb3763d8b7e2 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Thu, 14 Dec 2023 12:35:54 +0100
Subject: [PATCH] refs #6264 test: remove force describe for dms test

---
 .../claim-dms/specs/removeFile.spec.js        |  1 -
 .../client-dms/specs/removeFile.spec.js       |  1 -
 .../methods/ticket/specs/uploadFile.spec.js   | 25 +------------------
 .../ticket/back/methods/ticket/uploadFile.js  |  1 +
 .../back/methods/worker-dms/removeFile.js     |  4 ---
 .../worker-dms/specs/removeFile.spec.js       |  1 -
 .../methods/worker/specs/uploadFile.spec.js   |  2 +-
 7 files changed, 3 insertions(+), 32 deletions(-)

diff --git a/modules/claim/back/methods/claim-dms/specs/removeFile.spec.js b/modules/claim/back/methods/claim-dms/specs/removeFile.spec.js
index 108427b4cb..1cd3b16cb6 100644
--- a/modules/claim/back/methods/claim-dms/specs/removeFile.spec.js
+++ b/modules/claim/back/methods/claim-dms/specs/removeFile.spec.js
@@ -1,6 +1,5 @@
 const app = require('vn-loopback/server/server');
 
-// f
 describe('TicketDms removeFile()', () => {
     const ticketDmsId = 1;
     it(`should return an error for a user without enough privileges`, async() => {
diff --git a/modules/client/back/methods/client-dms/specs/removeFile.spec.js b/modules/client/back/methods/client-dms/specs/removeFile.spec.js
index 95c7d2ac4a..6dac712932 100644
--- a/modules/client/back/methods/client-dms/specs/removeFile.spec.js
+++ b/modules/client/back/methods/client-dms/specs/removeFile.spec.js
@@ -1,6 +1,5 @@
 const models = require('vn-loopback/server/server').models;
 
-// f
 describe('ClientDms removeFile()', () => {
     it(`should return an error for a user without enough privileges`, async() => {
         const tx = await models.Client.beginTransaction({});
diff --git a/modules/ticket/back/methods/ticket/specs/uploadFile.spec.js b/modules/ticket/back/methods/ticket/specs/uploadFile.spec.js
index 70d5320767..133c13265b 100644
--- a/modules/ticket/back/methods/ticket/specs/uploadFile.spec.js
+++ b/modules/ticket/back/methods/ticket/specs/uploadFile.spec.js
@@ -1,5 +1,5 @@
 const models = require('vn-loopback/server/server').models;
-// f
+
 describe('Ticket uploadFile()', () => {
     it(`should return an error for a user without enough privileges`, async() => {
         const tx = await models.Ticket.beginTransaction({});
@@ -23,27 +23,4 @@ describe('Ticket uploadFile()', () => {
 
         expect(error.message).toEqual(`You don't have enough privileges`);
     });
-
-    // fit(`should uploadFile`, async() => {
-    //     const tx = await models.Ticket.beginTransaction({});
-
-    //     let error;
-    //     try {
-    //         const options = {transaction: tx};
-
-    //         const ticketId = 15;
-    //         const currentUserId = 9;
-    //         const ticketTypeId = 14;
-    //         const ctx = {req: {accessToken: {userId: currentUserId}}, args: {dmsTypeId: ticketTypeId}, result: new ArrayBuffer(20000)};
-
-    //         await models.Ticket.uploadFile(ctx, ticketId, options);
-
-    //         await tx.rollback();
-    //     } catch (e) {
-    //         await tx.rollback();
-    //         error = e;
-    //     }
-
-    //     expect(error.message).toEqual(`You don't have enough privileges`);
-    // });
 });
diff --git a/modules/ticket/back/methods/ticket/uploadFile.js b/modules/ticket/back/methods/ticket/uploadFile.js
index eb563783cc..5b79aa9737 100644
--- a/modules/ticket/back/methods/ticket/uploadFile.js
+++ b/modules/ticket/back/methods/ticket/uploadFile.js
@@ -61,6 +61,7 @@ module.exports = Self => {
 
         try {
             const uploadedFiles = await Dms.uploadFile(ctx, myOptions);
+
             const promises = uploadedFiles.map(dms => TicketDms.create({
                 ticketFk: id,
                 dmsFk: dms.id
diff --git a/modules/worker/back/methods/worker-dms/removeFile.js b/modules/worker/back/methods/worker-dms/removeFile.js
index 9fddc8b4bf..343d6d50b4 100644
--- a/modules/worker/back/methods/worker-dms/removeFile.js
+++ b/modules/worker/back/methods/worker-dms/removeFile.js
@@ -30,14 +30,10 @@ module.exports = Self => {
         }
 
         try {
-            // const dms = await Self.app.models.Dms.findById(id, null, myOptions);
             const WorkerDms = await Self.findOne({
                 where: {document: id}
             }, myOptions);
 
-            // const targetDms = await Self.app.models.Dms.removeFile(ctx, id, myOptions);
-            // const WorkerDms = await Self.findById(+targetDms.reference, null, myOptions);
-
             const targetDms = await Self.app.models.Dms.removeFile(ctx, id, myOptions);
 
             if (!targetDms || !WorkerDms)
diff --git a/modules/worker/back/methods/worker-dms/specs/removeFile.spec.js b/modules/worker/back/methods/worker-dms/specs/removeFile.spec.js
index 82c6c3edde..3efd09464a 100644
--- a/modules/worker/back/methods/worker-dms/specs/removeFile.spec.js
+++ b/modules/worker/back/methods/worker-dms/specs/removeFile.spec.js
@@ -1,6 +1,5 @@
 const app = require('vn-loopback/server/server');
 
-// f
 describe('WorkerDms removeFile()', () => {
     const workerDmsFk = 1;
     it(`should return an error for a user without enough privileges`, async() => {
diff --git a/modules/worker/back/methods/worker/specs/uploadFile.spec.js b/modules/worker/back/methods/worker/specs/uploadFile.spec.js
index 71145ef5f1..7a929cd2ba 100644
--- a/modules/worker/back/methods/worker/specs/uploadFile.spec.js
+++ b/modules/worker/back/methods/worker/specs/uploadFile.spec.js
@@ -1,5 +1,5 @@
 const app = require('vn-loopback/server/server');
-// f
+
 describe('Worker uploadFile()', () => {
     it(`should return an error for a user without enough privileges`, async() => {
         let workerId = 1106;