From 1a869766b9ed7cf8a46ba35cd331111e56e645fc Mon Sep 17 00:00:00 2001
From: ivanm <ivanm@verdnatura.es>
Date: Mon, 5 Feb 2024 08:32:45 +0100
Subject: [PATCH] refs #6444 change code accord to conventions

---
 .../vn/functions/intrastat_estimateNet.sql    | 33 ++++++++++++-------
 1 file changed, 22 insertions(+), 11 deletions(-)

diff --git a/db/routines/vn/functions/intrastat_estimateNet.sql b/db/routines/vn/functions/intrastat_estimateNet.sql
index 99a52ded8d..3ee1ca80fb 100644
--- a/db/routines/vn/functions/intrastat_estimateNet.sql
+++ b/db/routines/vn/functions/intrastat_estimateNet.sql
@@ -1,21 +1,32 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn`.`intrastat_estimateNet`(vIntrastat INT, vUnidades INT)
+CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn`.`intrastat_estimateNet`(
+	vSelf INT,
+	vUnits INT
+)
 	RETURNS double
 	DETERMINISTIC
 BEGIN
-
+/**
+* Calcula un valor neto estimado en función de 
+* datos históricos de facturas intrastat.
+*
+* @param vSelf Id de intrastat
+* @param vUnits Número de unidades
+* @return vNet
+*/
 	DECLARE vNet DOUBLE;
 
-	SELECT ROUND(vUnidades / (SUM(media) / COUNT(media)), 2) INTO vNet
-		FROM (SELECT *, unidades / neto media
-				FROM vn2008.intrastat_data
-				WHERE intrastat_id = vIntrastat
-					AND neto
-					AND unidades > 0
-				ORDER BY odbc_date DESC
-				LIMIT 20) t;
+	SELECT ROUND(vUnits / (SUM(average) / COUNT(average)), 2) INTO vNet
+		FROM (
+			SELECT *, stems / net average
+				FROM invoiceInIntrastat
+				WHERE intrastatFk = vSelf
+					AND net
+					AND stems > 0
+				ORDER BY dated DESC
+				LIMIT 20
+		) sub;
 
 	RETURN vNet/2;
-
 END$$
 DELIMITER ;
\ No newline at end of file