From 1cc199e26bdc79f01fba874300a73ce52fd37ed2 Mon Sep 17 00:00:00 2001
From: alexm <alexm@verdnatura.es>
Date: Wed, 4 May 2022 10:26:13 +0200
Subject: [PATCH] refactor(client-credit)

---
 modules/client/back/models/client-credit.js | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/modules/client/back/models/client-credit.js b/modules/client/back/models/client-credit.js
index 7070dd6ae6..dedc9491aa 100644
--- a/modules/client/back/models/client-credit.js
+++ b/modules/client/back/models/client-credit.js
@@ -7,21 +7,17 @@ module.exports = Self => {
             where: {id: 1}
         });
         const maxCreditRows = clientConfig.maxCreditRows;
-
         const clientCredit = await models.ClientCredit.find({
             where: {clientFk: instance.clientFk},
-            order: 'created DESC'
+            order: 'created DESC',
+            limit: maxCreditRows
         }, ctx.options);
 
-        if (clientCredit.length > maxCreditRows) {
-            const creditToDestroy = [];
-            for (const [index, credit] of clientCredit.entries()) {
-                if (index >= maxCreditRows)
-                    creditToDestroy.push(credit.id);
-            }
-
+        const lastCredit = clientCredit[maxCreditRows - 1];
+        if (lastCredit) {
             await models.ClientCredit.destroyAll({
-                id: {inq: creditToDestroy}
+                clientFk: instance.clientFk,
+                created: {lt: lastCredit.created}
             }, ctx.options);
         }
     });