From 1d398a0acf6b71ccf35b97a8f34bb5b8559d8f31 Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Tue, 12 Mar 2024 08:40:11 +0100
Subject: [PATCH] refactor: refs #7018 Added comment and minor changes

---
 .../vn/procedures/invoiceInTaxMakeByDua.sql      |  2 +-
 ...eInTax_insert.sql => invoiceInTax_recalc.sql} | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)
 rename db/routines/vn/procedures/{invoiceInTax_insert.sql => invoiceInTax_recalc.sql} (79%)

diff --git a/db/routines/vn/procedures/invoiceInTaxMakeByDua.sql b/db/routines/vn/procedures/invoiceInTaxMakeByDua.sql
index 6707486d08..3453516cce 100644
--- a/db/routines/vn/procedures/invoiceInTaxMakeByDua.sql
+++ b/db/routines/vn/procedures/invoiceInTaxMakeByDua.sql
@@ -29,7 +29,7 @@ BEGIN
 			LEAVE l;
 		END IF;
 
-		CALL invoiceInTax_insert(vInvoiceInFk);
+		CALL invoiceInTax_recalc(vInvoiceInFk);
 		CALL invoiceInDueDay_recalc(vInvoiceInFk);
 
 	END LOOP;
diff --git a/db/routines/vn/procedures/invoiceInTax_insert.sql b/db/routines/vn/procedures/invoiceInTax_recalc.sql
similarity index 79%
rename from db/routines/vn/procedures/invoiceInTax_insert.sql
rename to db/routines/vn/procedures/invoiceInTax_recalc.sql
index 761d8b0c53..3b5ce52471 100644
--- a/db/routines/vn/procedures/invoiceInTax_insert.sql
+++ b/db/routines/vn/procedures/invoiceInTax_recalc.sql
@@ -1,13 +1,13 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`invoiceInTax_insert`(
-	vSelf INT
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`invoiceInTax_recalc`(
+	vInvoiceInFk INT
 )
 BEGIN
 /**
- * Inserta los impuestos de una factura, ajustando por
- * tasa de cambio y detalles de compra.
+ * Recalcula y actualiza los impuestos de la factura
+ * usando la última tasa de cambio y detalles de compra. 
  *
- * @param vSelf Id de invoiceInTax
+ * @param vInvoiceInFk Id de factura recibida
  */
 	DECLARE vRate DOUBLE DEFAULT 1;
 	DECLARE vDated DATE;
@@ -15,7 +15,7 @@ BEGIN
 
 	SELECT MAX(rr.dated) INTO vDated
 		FROM referenceRate rr
-			JOIN invoiceIn ii ON ii.id = vSelf
+			JOIN invoiceIn ii ON ii.id = vInvoiceInFk
 		WHERE rr.dated <= ii.issued
 			AND rr.currencyFk = ii.currencyFk;
 
@@ -25,7 +25,7 @@ BEGIN
 			WHERE dated = vDated;
 	END IF;
 
-	DELETE FROM invoiceInTax WHERE invoiceInFk = vSelf;
+	DELETE FROM invoiceInTax WHERE invoiceInFk = vInvoiceInFk;
 
 	SELECT id INTO vExpenseFk
 		FROM expense
@@ -56,7 +56,7 @@ BEGIN
 				JOIN buy b ON b.entryFk = e.id
 				LEFT JOIN referenceRate rr ON rr.currencyFk = ii.currencyFk
 					AND rr.dated = ii.issued
-			WHERE ii.id = vSelf
+			WHERE ii.id = vInvoiceInFk
 			HAVING bi IS NOT NULL;
 END$$
 DELIMITER ;