From 21e2945d4f6b59df9b239fd197b8845dbda7f8ef Mon Sep 17 00:00:00 2001
From: vicent <vicent@verdnatura.es>
Date: Wed, 26 Oct 2022 09:30:17 +0200
Subject: [PATCH] refactor: delete destroyAll

---
 .../methods/item-shelving/deleteItemShelvings.js     | 12 ++++++++----
 .../item-shelving/specs/deleteItemShelvings.spec.js  |  2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/modules/item/back/methods/item-shelving/deleteItemShelvings.js b/modules/item/back/methods/item-shelving/deleteItemShelvings.js
index 0b58970d83..f534b4e9a2 100644
--- a/modules/item/back/methods/item-shelving/deleteItemShelvings.js
+++ b/modules/item/back/methods/item-shelving/deleteItemShelvings.js
@@ -1,6 +1,6 @@
 module.exports = Self => {
     Self.remoteMethod('deleteItemShelvings', {
-        description: 'Deletes the selected orders',
+        description: 'Deletes the selected item shelvings',
         accessType: 'WRITE',
         accepts: [{
             arg: 'itemShelvingIds',
@@ -32,9 +32,13 @@ module.exports = Self => {
         }
 
         try {
-            const deletedItemShelvings = await models.ItemShelving.destroyAll({
-                id: {inq: itemShelvingIds}
-            }, myOptions);
+            const promises = [];
+            for (let itemShelvingId of itemShelvingIds) {
+                const itemShelvingToDelete = models.ItemShelving.destroyById(itemShelvingId, myOptions);
+                promises.push(itemShelvingToDelete);
+            }
+
+            const deletedItemShelvings = await Promise.all(promises);
 
             if (tx) await tx.commit();
 
diff --git a/modules/item/back/methods/item-shelving/specs/deleteItemShelvings.spec.js b/modules/item/back/methods/item-shelving/specs/deleteItemShelvings.spec.js
index a152b59815..b4113d7cf5 100644
--- a/modules/item/back/methods/item-shelving/specs/deleteItemShelvings.spec.js
+++ b/modules/item/back/methods/item-shelving/specs/deleteItemShelvings.spec.js
@@ -10,7 +10,7 @@ describe('ItemShelving deleteItemShelvings()', () => {
             const itemShelvingIds = [1, 2];
             const result = await models.ItemShelving.deleteItemShelvings(itemShelvingIds, options);
 
-            expect(result.count).toEqual(2);
+            expect(result.length).toEqual(2);
 
             await tx.rollback();
         } catch (e) {